DERHANSEN\SfEventMgt\Controller\EventController::saveRegistrationAction()

Complexity

Conditions	11
Paths	69

Size

Total Lines	122
Code Lines	84

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	0

<?php
    #[Extbase\Validate([
        'validator' => RegistrationFieldValidator::class,
        'param' => 'registration',
    ])]
    #[Extbase\Validate([
        'validator' => RegistrationValidator::class,
        'param' => 'registration',
    ])]
    public function saveRegistrationAction(Registration $registration, Event $event): ResponseInterface
    {
        $event = $this->eventEvaluationService->evaluateForSaveRegistrationAction(
            $this->request,
            $this->settings,
            $event
        );
        if (is_null($event) && isset($this->settings['event']['errorHandling'])) {
            return $this->handleEventNotFoundError($this->settings);
        }
        $autoConfirmation = (bool)($this->settings['registration']['autoConfirmation'] ?? false) ||
            $event->getEnableAutoconfirm();
        [$success, $result] = $this->registrationService->checkRegistrationSuccess($event, $registration);

It seems like $event can also be of type null; however, parameter $event of DERHANSEN\SfEventMgt\Service\RegistrationService::checkRegistrationSuccess() does only seem to accept DERHANSEN\SfEventMgt\Domain\Model\Event, maybe add an additional type check?

        // Save registration if no errors
        $registrationUid = 0;
        if ($success) {
            $isWaitlistRegistration = $this->registrationService->isWaitlistRegistration(
                $event,

It seems like $event can also be of type null; however, parameter $event of DERHANSEN\SfEventMgt\Service\RegistrationService::isWaitlistRegistration() does only seem to accept DERHANSEN\SfEventMgt\Domain\Model\Event, maybe add an additional type check?

                $registration->getAmountOfRegistrations()
            );
            $linkValidity = (int)($this->settings['confirmation']['linkValidity'] ?? 3600);
            if ($linkValidity === 0) {
                // Use 3600 seconds as default value if not set or zero
                $linkValidity = 3600;
            }
            $confirmationUntil = new DateTime();
            $confirmationUntil->add(new DateInterval('PT' . $linkValidity . 'S'));
            $price = $this->registrationService->evaluateRegistrationPrice($event, $registration, $this->request);

It seems like $event can also be of type null; however, parameter $event of DERHANSEN\SfEventMgt\Service\RegistrationService::evaluateRegistrationPrice() does only seem to accept DERHANSEN\SfEventMgt\Domain\Model\Event, maybe add an additional type check?

            $registration->setEvent($event);
            $registration->setPid($event->getPid());
            $registration->setRegistrationDate(new DateTime());
            $registration->setConfirmationUntil($confirmationUntil);
            $registration->setLanguage($this->getCurrentLanguageCode());
            $registration->setFeUser($this->registrationService->getCurrentFeUserObject());
            $registration->setWaitlist($isWaitlistRegistration);
            $registration->setPrice($price);

            $this->registrationRepository->add($registration);

            // Persist registration, so we have an UID
            $this->persistAll();
            $registrationUid = $registration->getUid();

            if ($isWaitlistRegistration) {
                $messageType = MessageType::REGISTRATION_WAITLIST_NEW;
            } else {
                $messageType = MessageType::REGISTRATION_NEW;
            }

            $this->eventDispatcher->dispatch(new AfterRegistrationSavedEvent($registration, $this, $this->request));

            // Send notifications to user and admin if confirmation link should be sent
            if (!$autoConfirmation) {
                $this->notificationService->sendUserMessage(
                    $this->request,
                    $event,

It seems like $event can also be of type null; however, parameter $event of DERHANSEN\SfEventMgt\Service\NotificationService::sendUserMessage() does only seem to accept DERHANSEN\SfEventMgt\Domain\Model\Event, maybe add an additional type check?

                    $registration,
                    $this->settings,
                    $messageType
                );
                $this->notificationService->sendAdminMessage(
                    $this->request,
                    $event,

It seems like $event can also be of type null; however, parameter $event of DERHANSEN\SfEventMgt\Service\NotificationService::sendAdminMessage() does only seem to accept DERHANSEN\SfEventMgt\Domain\Model\Event, maybe add an additional type check?

                    $registration,
                    $this->settings,
                    $messageType
                );
            }

            // Create given amount of registrations if necessary
            $modifyCreateDependingRegistrationsEvent = new ModifyCreateDependingRegistrationsEvent(
                $registration,
                ($registration->getAmountOfRegistrations() > 1),
                $this,
                $this->request
            );
            $this->eventDispatcher->dispatch($modifyCreateDependingRegistrationsEvent);
            $createDependingRegistrations = $modifyCreateDependingRegistrationsEvent->getCreateDependingRegistrations();
            if ($createDependingRegistrations) {
                $this->registrationService->createDependingRegistrations($registration);
            }

            // Flush page cache for event, since new registration has been added
            $this->eventCacheService->flushEventCache($event->getUid(), $event->getPid());
        }

        if ($autoConfirmation && $success) {
            return $this->redirect(
                'confirmRegistration',
                null,
                null,
                [
                    'reguid' => $registration->getUid(),
                    'hmac' => $this->hashService->hmac(
                        'reg-' . $registration->getUid(),
                        HashScope::RegistrationUid->value
                    ),
                ]
            );
        }

        return $this->redirect(
            'saveRegistrationResult',
            null,
            null,
            [
                'result' => $result,
                'eventuid' => $event->getUid(),
                'reguid' => $registrationUid,
                'hmac' => $this->hashService->hmac(
                    'event-' . $event->getUid() . '-reg-' . $registrationUid,
                    HashScope::SaveRegistrationResult->value
                ),