DERHANSEN\SfBanners\ViewHelpers\Flash\ParamsViewHelper

Complexity

Total Complexity

6

Size/Duplication

Total Lines	57
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	0

Importance

Changes

0

2 Methods

Rating	Name	Duplication	Size	Complexity
A	getSettings()	0	9	1
B	render()	0	24	5

<?php
namespace DERHANSEN\SfBanners\ViewHelpers\Flash;

/*
 * This file is part of the TYPO3 CMS project.
 *
 * It is free software; you can redistribute it and/or modify it under
 * the terms of the GNU General Public License, either version 2
 * of the License, or any later version.
 *
 * For the full copyright and license information, please read the
 * LICENSE.txt file that was distributed with this source code.
 *
 * The TYPO3 project - inspiring people to share!
 */

use TYPO3\CMS\Fluid\Core\ViewHelper\AbstractViewHelper;

/**
 * Flash params viewhelper
 *
 * @author Torben Hansen <derhansen@gmail.com>
 */
class ParamsViewHelper extends AbstractViewHelper
{
    /**
     * @var \TYPO3\CMS\Extbase\Configuration\ConfigurationManagerInterface
     * @inject
     */
    protected $configurationManager;

    /**
     * Returns TypoSript settings for the extension
     *
     * @return array
     */
    public function getSettings()
    {
        $typoScript = $this->configurationManager->getConfiguration(
            \TYPO3\CMS\Extbase\Configuration\ConfigurationManagerInterface::CONFIGURATION_TYPE_SETTINGS,
            'SfBanners',
            'Pi1'
        );
        return $typoScript;
    }

    /**
     * Returns the requested flash variable depending on the setting in the banner.
     * If no value is set in the banner object, the default value from TS setting
     * is returned
     *
     * @param \DERHANSEN\SfBanners\Domain\Model\Banner $banner The banner
     * @param string $flashSetting Flash settings
     * @return string
     */
    public function render($banner = null, $flashSetting = '')
    {
        $settings = $this->getSettings();
        $retVal = '';
        switch ($flashSetting) {
            case 'wmode':
                if ($banner->getFlashWmode() != '') {
                    $retVal = $banner->getFlashWmode();

It seems like $banner is not always an object, but can also be of type null. Maybe add an additional type check?

                } else {
                    $retVal = $settings['defaultFlashVars']['wmode'];
                }
                break;
            case 'allowScriptAccess':
                if ($banner->getFlashAllowScriptAccess() != '') {
                    $retVal = $banner->getFlashAllowScriptAccess();
                } else {
                    $retVal = $settings['defaultFlashVars']['allowScriptAccess'];
                }
                break;
            default:

The default body in a switch statement must start on the line following the statement.

Blank line found at end of control structure

        }
        return $retVal;
    }
}