ChangePasswordValidatorTest::validatePasswordComplexityDataProvider() - Code Metrics - Inspection of "[TASK] Add feUserPasswordHash to ChangePassword DT..." - derhansen/fe_change_pwd - Measure and Improve Code Quality continuously with Scrutinizer

Passed
Push — master ( d8df74...725a8f )

by Torben
created 2021-08-22 12:05 UTC
validatePasswordComplexityDataProvider() B

↳ Parent: ChangePasswordValidatorTest
Complexity

Conditions	1
Paths	1
Size

Total Lines	96
Code Lines	69
Duplication

Lines	0
Ratio	0 %
Importance

Changes
Metric	Value
eloc	69
c	0
b	0
f	0
dl	0
loc	96
rs	8.6763
cc	1
nc	1
nop	0
How to fix Long Method

<?php

/*
 * This file is part of the Extension "fe_change_pwd" for TYPO3 CMS.
 *
 * For the full copyright and license information, please read the
 * LICENSE.txt file that was distributed with this source code.
 */

namespace Derhansen\FeChangePwd\Tests\Unit\Validation\Validator;

use Derhansen\FeChangePwd\Domain\Model\Dto\ChangePassword;
use Derhansen\FeChangePwd\Service\LocalizationService;
use Derhansen\FeChangePwd\Service\OldPasswordService;
use Derhansen\FeChangePwd\Service\SettingsService;
use Derhansen\FeChangePwd\Validation\Validator\ChangePasswordValidator;
use TYPO3\TestingFramework\Core\Unit\UnitTestCase;

/**
 * Class ChangePasswordValidatorTest
 */
class ChangePasswordValidatorTest extends UnitTestCase
{
    /**
     * @var ChangePasswordValidator
     */
    protected $validator;

    /**
     * Initialize validator
     */
    public function initialize()
    {
        $this->validator = $this->getAccessibleMock(

            ChangePasswordValidator::class,
            ['translateErrorMessage', 'getValidator'],
            [],
            '',
            false
        );
    }

    /**
     * @return array
     */
    public function validatePasswordComplexityDataProvider()
    {
        return [
            'no password given' => [
                '',
                '',
                true,
                []
            ],
            'passwords not equal' => [
                'password1',
                'password2',
                true,
                []
            ],
            'length below min length' => [
                'password',
                'password',
                true,
                [
                    'passwordComplexity' => [
                        'minLength' => 9,
                        'capitalCharCheck' => 0,
                        'lowerCaseCharCheck' => 0,
                        'digitCheck' => 0,
                        'specialCharCheck' => 0,
                    ]
                ]
            ],
            'no capital char' => [
                'password',
                'password',
                true,
                [
                    'passwordComplexity' => [
                        'minLength' => 7,
                        'capitalCharCheck' => 1,
                        'lowerCaseCharCheck' => 0,
                        'digitCheck' => 0,
                        'specialCharCheck' => 0,
                    ]
                ]
            ],
            'no lower case char' => [
                'PASSWORD',
                'PASSWORD',
                true,
                [
                    'passwordComplexity' => [
                        'minLength' => 7,
                        'capitalCharCheck' => 0,
                        'lowerCaseCharCheck' => 1,
                        'digitCheck' => 0,
                        'specialCharCheck' => 0,
                    ]
                ]
            ],
            'no digit' => [
                'password',
                'password',
                true,
                [
                    'passwordComplexity' => [
                        'minLength' => 7,
                        'capitalCharCheck' => 0,
                        'lowerCaseCharCheck' => 0,
                        'digitCheck' => 1,
                        'specialCharCheck' => 0,
                    ]
                ]
            ],
            'no special char' => [
                'password',
                'password',
                true,
                [
                    'passwordComplexity' => [
                        'minLength' => 7,
                        'capitalCharCheck' => 0,
                        'lowerCaseCharCheck' => 0,
                        'digitCheck' => 0,
                        'specialCharCheck' => 1,
                    ]
                ]
            ],
            'strong password' => [
                'Th!s_i$_a_$+r0ng_passw0rd#',
                'Th!s_i$_a_$+r0ng_passw0rd#',
                false,
                [
                    'passwordComplexity' => [
                        'minLength' => 20,
                        'capitalCharCheck' => 1,
                        'lowerCaseCharCheck' => 1,
                        'digitCheck' => 1,
                        'specialCharCheck' => 1,
                    ]
                ]
            ],
        ];
    }

    /**
     * @test
     * @dataProvider validatePasswordComplexityDataProvider
     */
    public function validatePasswordComplexityTest($password1, $password2, $expected, $settings)
    {
        $this->initialize();

        $changePassword = new ChangePassword();
        $changePassword->setPassword1($password1);
        $changePassword->setPassword2($password2);

        $mockSettingsService = static::getMockBuilder(SettingsService::class)
        $mockSettingsService = static::/** @scrutinizer ignore-call */ getMockBuilder(SettingsService::class)
            ->disableOriginalConstructor()
            ->getMock();
        $mockSettingsService->expects(self::once())->method('getSettings')->willReturn($settings);
        $this->validator->_set('settingsService', $mockSettingsService);

        $mockLocalizationService = static::getMockBuilder(LocalizationService::class)
            ->disableOriginalConstructor()
            ->getMock();
        $mockLocalizationService->expects(self::any())->method('translate')->willReturn('');
        $this->validator->_set('localizationService', $mockLocalizationService);

        self::assertEquals($expected, $this->validator->validate($changePassword)->hasErrors());
    }

    /**
     * @test
     */
    public function noCurrentPasswordGivenTest()
    {
        $this->initialize();

        $changePassword = new ChangePassword();
        $changePassword->setCurrentPassword('');

        $settings = [
            'requireCurrentPassword' => [
                'enabled' => 1
            ]
        ];

        $mockSettingsService = static::getMockBuilder(SettingsService::class)
        $mockSettingsService = static::/** @scrutinizer ignore-call */ getMockBuilder(SettingsService::class)
            ->disableOriginalConstructor()
            ->getMock();
        $mockSettingsService->expects(self::once())->method('getSettings')->willReturn($settings);
        $this->validator->_set('settingsService', $mockSettingsService);

        $mockLocalizationService = static::getMockBuilder(LocalizationService::class)
            ->disableOriginalConstructor()
            ->getMock();
        $mockLocalizationService->expects(self::any())->method('translate')->willReturn('');
        $this->validator->_set('localizationService', $mockLocalizationService);

        self::assertEquals(1570880411, $this->validator->validate($changePassword)->getErrors()[0]->getCode());
    }

    /**
     * @test
     */
    public function currentPasswordWrongTest()
    {
        $this->initialize();

        $changePassword = new ChangePassword();
        $changePassword->setCurrentPassword('invalid');

        $settings = [
            'requireCurrentPassword' => [
                'enabled' => 1
            ]
        ];

        $mockSettingsService = static::getMockBuilder(SettingsService::class)
        $mockSettingsService = static::/** @scrutinizer ignore-call */ getMockBuilder(SettingsService::class)
            ->disableOriginalConstructor()
            ->getMock();
        $mockSettingsService->expects(self::once())->method('getSettings')->willReturn($settings);
        $this->validator->_set('settingsService', $mockSettingsService);

        $mockLocalizationService = static::getMockBuilder(LocalizationService::class)
            ->disableOriginalConstructor()
            ->getMock();
        $mockLocalizationService->expects(self::any())->method('translate')->willReturn('');
        $this->validator->_set('localizationService', $mockLocalizationService);

        $mockOldPasswordService = static::getMockBuilder(OldPasswordService::class)
            ->disableOriginalConstructor()
            ->getMock();
        $mockOldPasswordService->expects(self::any())->method('checkEqualsOldPassword')
            ->willReturn(false);
        $this->validator->_set('oldPasswordService', $mockOldPasswordService);

        self::assertEquals(1570880417, $this->validator->validate($changePassword)->getErrors()[0]->getCode());
    }

    /**
     * @test
     */
    public function currentPasswordValidationSkipped()
    {
        $this->initialize();

        $changePassword = new ChangePassword();
        $changePassword->setCurrentPassword('123456');
        $changePassword->setSkipCurrentPasswordCheck(true);

        $settings = [
            'requireCurrentPassword' => [
                'enabled' => 1
            ]
        ];

        $mockSettingsService = static::getMockBuilder(SettingsService::class)
        $mockSettingsService = static::/** @scrutinizer ignore-call */ getMockBuilder(SettingsService::class)
            ->disableOriginalConstructor()
            ->getMock();
        $mockSettingsService->expects(self::once())->method('getSettings')->willReturn($settings);
        $this->validator->_set('settingsService', $mockSettingsService);

        $mockLocalizationService = static::getMockBuilder(LocalizationService::class)
            ->disableOriginalConstructor()
            ->getMock();
        $mockLocalizationService->expects(self::any())->method('translate')->willReturn('');
        $this->validator->_set('localizationService', $mockLocalizationService);

        self::assertEquals(1537701950, $this->validator->validate($changePassword)->getErrors()[0]->getCode());
    }
}

derhansen / fe_change_pwd

Push — master ( d8df74...725a8f )

validatePasswordComplexityDataProvider() B

Complexity

Size

Duplication

Importance

How to fix Long Method

Long Method

Duplication Side-by-Side

Filter issues like
