Derhansen\FeChangePwd\Controller\PasswordController

Complexity

Total Complexity

11

Size/Duplication

Total Lines	101
Duplicated Lines	0 %

Importance

Changes	2
Bugs	0	Features	0

7 Methods

Rating	Name	Duplication	Size	Complexity
A	setFeUserPasswordHashToArguments()	0	10	1
A	updateAction()	0	16	3
A	getErrorFlashMessage()	0	3	1
A	injectFrontendUserService()	0	3	1
A	initializeUpdateAction()	0	11	3
A	getFrontendUser()	0	3	1
A	editAction()	0	10	1

<?php

declare(strict_types=1);

/*
 * This file is part of the Extension "fe_change_pwd" for TYPO3 CMS.
 *
 * For the full copyright and license information, please read the
 * LICENSE.txt file that was distributed with this source code.
 */

namespace Derhansen\FeChangePwd\Controller;

use Derhansen\FeChangePwd\Domain\Model\Dto\ChangePassword;
use Derhansen\FeChangePwd\Event\AfterPasswordUpdatedEvent;
use Derhansen\FeChangePwd\Service\FrontendUserService;
use Psr\Http\Message\ResponseInterface;
use TYPO3\CMS\Extbase\Annotation as Extbase;
use TYPO3\CMS\Extbase\Mvc\Controller\ActionController;
use TYPO3\CMS\Extbase\Security\Exception\InvalidHashException;
use TYPO3\CMS\Extbase\Utility\LocalizationUtility;
use TYPO3\CMS\Frontend\Authentication\FrontendUserAuthentication;

/**
 * Class PasswordController
 */
class PasswordController extends ActionController
{
    protected FrontendUserService $frontendUserService;

    public function injectFrontendUserService(FrontendUserService $frontendUserService): void
    {
        $this->frontendUserService = $frontendUserService;
    }

    /**
     * Edit action
     *
     * @return ResponseInterface
     */
    public function editAction(): ResponseInterface
    {
        $changePassword = new ChangePassword();
        $changePassword->setChangeHmac($this->frontendUserService->getChangeHmac());
        $this->view->assignMultiple([
            'changePasswordReason' => $this->frontendUserService->getMustChangePasswordReason(),
            'changePassword' => $changePassword,
        ]);

        return $this->htmlResponse();
    }

    /**
     * Ensure a valid changeHmac is provided
     *
     * @throws \TYPO3\CMS\Extbase\Mvc\Exception\NoSuchArgumentException
     * @throws InvalidHashException
     */
    public function initializeUpdateAction(): void
    {
        $changePasswordArray = $this->request->getArgument('changePassword');
        $changeHmac = $changePasswordArray['changeHmac'] ? (string)$changePasswordArray['changeHmac'] : '';
        if (!$this->frontendUserService->validateChangeHmac($changeHmac)) {
            throw new InvalidHashException(
                'Possible CSRF detected. Ensure a valid "changeHmac" is provided.',
                1572672118931
            );
        }
        $this->setFeUserPasswordHashToArguments($changePasswordArray);

It seems like $changePasswordArray can also be of type string; however, parameter $changePasswordArray of Derhansen\FeChangePwd\Controller\PasswordController::setFeUserPasswordHashToArguments() does only seem to accept array, maybe add an additional type check?

    }

    /**
     * Update action
     *
     * @param \Derhansen\FeChangePwd\Domain\Model\Dto\ChangePassword $changePassword
     * @return ResponseInterface
     * @Extbase\Validate(param="changePassword", validator="Derhansen\FeChangePwd\Validation\Validator\ChangePasswordValidator")
     */
    public function updateAction(ChangePassword $changePassword): ResponseInterface
    {
        $this->frontendUserService->updatePassword($changePassword->getPassword1());

        $this->eventDispatcher->dispatch(new AfterPasswordUpdatedEvent($changePassword, $this));

        if (isset($this->settings['afterPasswordChangeAction']) &&
            $this->settings['afterPasswordChangeAction'] === 'redirect') {
            $this->addFlashMessage(
                LocalizationUtility::translate('passwordUpdated', 'FeChangePwd'),
                LocalizationUtility::translate('passwordUpdated.title', 'FeChangePwd')
            );
            $this->redirect('edit');
        }

        return $this->htmlResponse();
    }

    /**
     * Sets the current fe_user password (hashed) to request argument "changePassword"
     *
     * @param array $changePasswordArray
     * @throws \TYPO3\CMS\Extbase\Mvc\Exception\NoSuchArgumentException
     */
    protected function setFeUserPasswordHashToArguments(array $changePasswordArray): void
    {
        $changePasswordArgument = $this->arguments->getArgument('changePassword');
        $propertyMapping = $changePasswordArgument->getPropertyMappingConfiguration();
        $propertyMapping->allowProperties('feUserPasswordHash');

        $changePasswordArray['feUserPasswordHash'] = $this->getFrontendUser()->user['password'];
        $arguments = $this->request->getArguments();
        $arguments['changePassword'] = $changePasswordArray;
        $this->request->setArguments($arguments);
    }

    /**
     * Suppress default flash messages
     *
     * @return bool
     */
    protected function getErrorFlashMessage(): bool
    {
        return false;
    }

    protected function getFrontendUser(): FrontendUserAuthentication
    {
        return $GLOBALS['TSFE']->fe_user;
    }
}