Deployer\ProcessRunner\ProcessRunner::run()

Complexity

Conditions	6
Paths	40

Size

Total Lines	46
Code Lines	34

Duplication

Lines	0
Ratio	0 %

Importance

Changes

0

<?php
    public function run(Host $host, string $command, array $config = []): string
    {
        $defaults = [
            'timeout' => $host->get('default_timeout', 300),
            'idle_timeout' => null,
            'cwd' => getenv('DEPLOYER_ROOT') !== false ? getenv('DEPLOYER_ROOT') : (defined('DEPLOYER_DEPLOY_FILE') ? dirname(DEPLOYER_DEPLOY_FILE) : null),

The constant Deployer\ProcessRunner\DEPLOYER_DEPLOY_FILE was not found. Maybe you did not declare it correctly or list all dependencies?

            'real_time_output' => false,
            'shell' => 'bash -s',
        ];
        $config = array_merge($defaults, $config);

        $this->pop->command($host, 'run', $command);

        $terminalOutput = $this->pop->callback($host, $config['real_time_output']);
        $callback = function ($type, $buffer) use ($host, $terminalOutput) {
            $this->logger->printBuffer($host, $type, $buffer);
            $terminalOutput($type, $buffer);
        };

        $command = str_replace('%secret%', $config['secret'] ?? '', $command);
        $command = str_replace('%sudo_pass%', $config['sudo_pass'] ?? '', $command);

        $process = Process::fromShellCommandline($config['shell'])
            ->setInput($command)
            ->setTimeout($config['timeout'])
            ->setIdleTimeout($config['idle_timeout']);

        if ($config['cwd'] !== null) {
            $process->setWorkingDirectory($config['cwd']);
        }

        try {
            $process->mustRun($callback);
            return $process->getOutput();
        } catch (ProcessFailedException $exception) {
            throw new RunException(
                $host,
                $command,
                $process->getExitCode(),

It seems like $process->getExitCode() can also be of type null; however, parameter $exitCode of Deployer\Exception\RunException::__construct() does only seem to accept integer, maybe add an additional type check?

                $process->getOutput(),
                $process->getErrorOutput(),
            );
        } catch (ProcessTimedOutException $exception) {
            throw new TimeoutException(
                $command,
                $exception->getExceededTimeout(),
            );