Parser - Code Metrics - Inspection of "Deployer v7" - deployphp/deployer - Measure and Improve Code Quality continuously with Scrutinizer

Test Setup Failed

Pull Request — master (#1904)

by Anton

created 2020-04-25 19:50 UTC

Parser A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	104
Duplicated Lines	9.62 %

Coupling/Cohesion

Components	0
Dependencies	4

Importance

Changes

Metric	Value
dl	10
loc	104
rs	10
c	0
b	0
f	0
wmc	8
lcom	0
cbo	4

3 Methods

Rating	Name	Duplication	Size	Complexity
A	toBuilder()	0	6	1
B	toComponents()	10	32	6
A	toVersion()	0	12	1

How to fix Duplicated Code

<?php

namespace Deployer\Component\Version;

use Deployer\Component\Version\Exception\InvalidStringRepresentationException;

/**
 * Parses the string representation of a version number.
 *
 * @author Kevin Herrera <[email protected]>
 */
class Parser
{
    /**
     * The build metadata component.
     */
    const BUILD = 'build';

    /**
     * The major version number component.
     */
    const MAJOR = 'major';

    /**
     * The minor version number component.
     */
    const MINOR = 'minor';

    /**
     * The patch version number component.
     */
    const PATCH = 'patch';

    /**
     * The pre-release version number component.
     */
    const PRE_RELEASE = 'pre';

    /**
     * Returns a Version builder for the string representation.
     *
     * @param string $version The string representation.
     *
     * @return Builder A Version builder.
     */
    public static function toBuilder($version)
    {
        return Builder::create()->importComponents(
            self::toComponents($version)
        );
    }

    /**
     * Returns the components of the string representation.
     *
     * @param string $version The string representation.
     *
     * @return array The components of the version.
     *
     * @throws InvalidStringRepresentationException If the string representation
     *                                              is invalid.
     */
    public static function toComponents($version)
    {
        if (!Validator::isVersion($version)) {
            throw new InvalidStringRepresentationException($version);
        }

        if (false !== strpos($version, '+')) {
            list($version, $build) = explode('+', $version);

            $build = explode('.', $build);
        }

        if (false !== strpos($version, '-')) {
            list($version, $pre) = explode('-', $version);

            $pre = explode('.', $pre);
        }

        list(
            $major,
            $minor,
            $patch
        ) = explode('.', $version);

        return array(
            self::MAJOR => intval($major),
            self::MINOR => intval($minor),
            self::PATCH => intval($patch),
            self::PRE_RELEASE => isset($pre) ? $pre : array(),
            self::BUILD => isset($build) ? $build : array(),
        );
    }

    /**
     * Returns a Version instance for the string representation.
     *
     * @param string $version The string representation.
     *
     * @return Version A Version instance.
     */
    public static function toVersion($version)
    {
        $components = self::toComponents($version);

        return new Version(
            $components['major'],
/**
 * @return array|string
 */
function returnsDifferentValues($x) {
    if ($x) {
        return 'foo';
    }

    return array();
}

$x = returnsDifferentValues($y);
if (is_array($x)) {
    // $x is an array.
}
            $components['minor'],
/**
 * @return array|string
 */
function returnsDifferentValues($x) {
    if ($x) {
        return 'foo';
    }

    return array();
}

$x = returnsDifferentValues($y);
if (is_array($x)) {
    // $x is an array.
}
            $components['patch'],
/**
 * @return array|string
 */
function returnsDifferentValues($x) {
    if ($x) {
        return 'foo';
    }

    return array();
}

$x = returnsDifferentValues($y);
if (is_array($x)) {
    // $x is an array.
}
            $components['pre'],
/**
 * @return array|string
 */
function returnsDifferentValues($x) {
    if ($x) {
        return 'foo';
    }

    return array();
}

$x = returnsDifferentValues($y);
if (is_array($x)) {
    // $x is an array.
}
            $components['build']
/**
 * @return array|string
 */
function returnsDifferentValues($x) {
    if ($x) {
        return 'foo';
    }

    return array();
}

$x = returnsDifferentValues($y);
if (is_array($x)) {
    // $x is an array.
}
        );
    }
}


1		<?php
2
3		namespace Deployer\Component\Version;
4
5		use Deployer\Component\Version\Exception\InvalidStringRepresentationException;
6
7		/**
8		* Parses the string representation of a version number.
9		*
10		* @author Kevin Herrera <[email protected]>
11		*/
12		class Parser
13		{
14		/**
15		* The build metadata component.
16		*/
17		const BUILD = 'build';
18
19		/**
20		* The major version number component.
21		*/
22		const MAJOR = 'major';
23
24		/**
25		* The minor version number component.
26		*/
27		const MINOR = 'minor';
28
29		/**
30		* The patch version number component.
31		*/
32		const PATCH = 'patch';
33
34		/**
35		* The pre-release version number component.
36		*/
37		const PRE_RELEASE = 'pre';
38
39		/**
40		* Returns a Version builder for the string representation.
41		*
42		* @param string $version The string representation.
43		*
44		* @return Builder A Version builder.
45		*/
46		public static function toBuilder($version)
47		{
48		return Builder::create()->importComponents(
49		self::toComponents($version)
50		);
51		}
52
53		/**
54		* Returns the components of the string representation.
55		*
56		* @param string $version The string representation.
57		*
58		* @return array The components of the version.
59		*
60		* @throws InvalidStringRepresentationException If the string representation
61		* is invalid.
62		*/
63		public static function toComponents($version)
64		{
65		if (!Validator::isVersion($version)) {
66		throw new InvalidStringRepresentationException($version);
67		}
68
69	View Code Duplication	if (false !== strpos($version, '+')) {
70		list($version, $build) = explode('+', $version);
71
72		$build = explode('.', $build);
73		}
74
75	View Code Duplication	if (false !== strpos($version, '-')) {
76		list($version, $pre) = explode('-', $version);
77
78		$pre = explode('.', $pre);
79		}
80
81		list(
82		$major,
83		$minor,
84		$patch
85		) = explode('.', $version);
86
87		return array(
88		self::MAJOR => intval($major),
89		self::MINOR => intval($minor),
90		self::PATCH => intval($patch),
91		self::PRE_RELEASE => isset($pre) ? $pre : array(),
92		self::BUILD => isset($build) ? $build : array(),
93		);
94		}
95
96		/**
97		* Returns a Version instance for the string representation.
98		*
99		* @param string $version The string representation.
100		*
101		* @return Version A Version instance.
102		*/
103		public static function toVersion($version)
104		{
105		$components = self::toComponents($version);
106
107		return new Version(
108		$components['major'],
		0 ignored issues – show Bug introduced 2020-04-25 19:51 UTC by Report Bug Copy Issue Report It seems like `$components['major']` can also be of type `array`; however, `Deployer\Component\Version\Version::__construct()` does only seem to accept `integer`, maybe add an additional type check? If a method or function can return multiple different values and unless you are sure that you only can receive a single value in this context, we recommend to add an additional type check: /** * @return array\|string */ function returnsDifferentValues($x) { if ($x) { return 'foo'; } return array(); } $x = returnsDifferentValues($y); if (is_array($x)) { // $x is an array. } If this a common case that PHP Analyzer should handle natively, please let us know by opening an issue. Loading history...
109		$components['minor'],
		0 ignored issues – show Bug introduced 2020-04-25 19:51 UTC by Report Bug Copy Issue Report It seems like `$components['minor']` can also be of type `array`; however, `Deployer\Component\Version\Version::__construct()` does only seem to accept `integer`, maybe add an additional type check? If a method or function can return multiple different values and unless you are sure that you only can receive a single value in this context, we recommend to add an additional type check: /** * @return array\|string */ function returnsDifferentValues($x) { if ($x) { return 'foo'; } return array(); } $x = returnsDifferentValues($y); if (is_array($x)) { // $x is an array. } If this a common case that PHP Analyzer should handle natively, please let us know by opening an issue. Loading history...
110		$components['patch'],
		0 ignored issues – show Bug introduced 2020-04-25 19:51 UTC by Report Bug Copy Issue Report It seems like `$components['patch']` can also be of type `array`; however, `Deployer\Component\Version\Version::__construct()` does only seem to accept `integer`, maybe add an additional type check? If a method or function can return multiple different values and unless you are sure that you only can receive a single value in this context, we recommend to add an additional type check: /** * @return array\|string */ function returnsDifferentValues($x) { if ($x) { return 'foo'; } return array(); } $x = returnsDifferentValues($y); if (is_array($x)) { // $x is an array. } If this a common case that PHP Analyzer should handle natively, please let us know by opening an issue. Loading history...
111		$components['pre'],
		0 ignored issues – show Bug introduced 2020-04-25 19:51 UTC by Report Bug Copy Issue Report It seems like `$components['pre']` can also be of type `integer`; however, `Deployer\Component\Version\Version::__construct()` does only seem to accept `array`, maybe add an additional type check? If a method or function can return multiple different values and unless you are sure that you only can receive a single value in this context, we recommend to add an additional type check: /** * @return array\|string */ function returnsDifferentValues($x) { if ($x) { return 'foo'; } return array(); } $x = returnsDifferentValues($y); if (is_array($x)) { // $x is an array. } If this a common case that PHP Analyzer should handle natively, please let us know by opening an issue. Loading history...
112		$components['build']
		0 ignored issues – show Bug introduced 2020-04-25 19:51 UTC by Report Bug Copy Issue Report It seems like `$components['build']` can also be of type `integer`; however, `Deployer\Component\Version\Version::__construct()` does only seem to accept `array`, maybe add an additional type check? If a method or function can return multiple different values and unless you are sure that you only can receive a single value in this context, we recommend to add an additional type check: /** * @return array\|string */ function returnsDifferentValues($x) { if ($x) { return 'foo'; } return array(); } $x = returnsDifferentValues($y); if (is_array($x)) { // $x is an array. } If this a common case that PHP Analyzer should handle natively, please let us know by opening an issue. Loading history...
113		);
114		}
115		}
116

deployphp / deployer

GitHub Access Token became invalid

Pull Request — master (#1904)

Parser A

Complexity

Size/Duplication

Coupling/Cohesion

Importance

3 Methods

How to fix Duplicated Code

Duplicated Code

Duplication Side-by-Side

Filter issues like