ProcessRunner::run() - Code Metrics - Inspection of "Add checks for fromShellCommandline method" - deployphp/deployer - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — master ( f968f3...d9c744 )

by Anton

created 2019-12-15 14:51 UTC

ProcessRunner::run() A

↳ Parent: ProcessRunner

Complexity

Conditions	2
Paths	2

Size

Total Lines

Duplication

Lines	5
Ratio	21.74 %

Code Coverage

Tests	10
CRAP Score	2.003

Importance

Changes

Metric	Value
cc	2
nc	2
nop	3
dl	5
loc	23
ccs	10
cts	11
cp	0.9091
crap	2.003
rs	9.552
c	0
b	0
f	0

<?php
/* (c) Anton Medvedev <[email protected]>
 *
 * For the full copyright and license information, please view the LICENSE
 * file that was distributed with this source code.
 */

namespace Deployer\Utility;

use Deployer\Deployer;
use Symfony\Component\Process\Exception\ProcessFailedException;
use Symfony\Component\Process\Process;

class ProcessRunner
{
    /**
     * @var ProcessOutputPrinter
     */
    private $pop;

    public function __construct(ProcessOutputPrinter $pop)
    {
        $this->pop = $pop;
    }

    /**
     * Runs a command, consider deployer global configs (timeout,...)
     *
     * @param string $hostname
     * @param string $command
     * @param array $config
     *
     * @return string
     *
     * @throws ProcessFailedException When the process does not return a 0 exit code.
     */
    public function run($hostname, string $command, array $config = [])
    {
        $defaults = [
            'timeout' => Deployer::getDefault('default_timeout', 300),
            'tty' => false,
        ];
        $config = array_merge($defaults, $config);

        $this->pop->command($hostname, $command);

        if (method_exists('Symfony\Component\Process\Process', 'fromShellCommandline')) {
            $process = Process::fromShellCommandline($command);
        } else {
            $process = new Process($command);
        }

        $process
            ->setTimeout($config['timeout'])
            ->setTty($config['tty'])
            ->mustRun($this->pop->callback($hostname));

        return $process->getOutput();
    }
}


1			<?php
2			/* (c) Anton Medvedev <[email protected]>
3			*
4			* For the full copyright and license information, please view the LICENSE
5			* file that was distributed with this source code.
6			*/
7
8			namespace Deployer\Utility;
9
10			use Deployer\Deployer;
11			use Symfony\Component\Process\Exception\ProcessFailedException;
12			use Symfony\Component\Process\Process;
13
14			class ProcessRunner
15			{
16			/**
17			* @var ProcessOutputPrinter
18			*/
19			private $pop;
20
21	10		public function __construct(ProcessOutputPrinter $pop)
22			{
23	10		$this->pop = $pop;
24	10		}
25
26			/**
27			* Runs a command, consider deployer global configs (timeout,...)
28			*
29			* @param string $hostname
30			* @param string $command
31			* @param array $config
32			*
33			* @return string
34			*
35			* @throws ProcessFailedException When the process does not return a 0 exit code.
36			*/
37	10		public function run($hostname, string $command, array $config = [])
38			{
39			$defaults = [
40	10		'timeout' => Deployer::getDefault('default_timeout', 300),
41			'tty' => false,
42			];
43	10		$config = array_merge($defaults, $config);
44
45	10		$this->pop->command($hostname, $command);
46
47	10	View Code Duplication	if (method_exists('Symfony\Component\Process\Process', 'fromShellCommandline')) {
48	10		$process = Process::fromShellCommandline($command);
49			} else {
50			$process = new Process($command);
51			}
52
53			$process
54	10		->setTimeout($config['timeout'])
55	10		->setTty($config['tty'])
56	10		->mustRun($this->pop->callback($hostname));
57
58	10		return $process->getOutput();
59			}
60			}
61

deployphp / deployer

GitHub Access Token became invalid

Push — master ( f968f3...d9c744 )

ProcessRunner::run() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like