Configurable::testConfig() - Code Metrics - Inspection of "Update" - deniskoronets/Laravel-GridView - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 481507...e81850 )

by Denis

created 2018-11-09 13:20 UTC

Configurable::testConfig() B

↳ Parent: Configurable

Complexity

Conditions	10
Paths	15

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
cc	10
nc	15
nop	0
dl	0
loc	46
rs	7.3115
c	0
b	0
f	0

How to fix Complexity

<?php

namespace Woo\GridView\Traits;

use Woo\GridView\Exceptions\GridViewConfigException;

trait Configurable
{
    /**
     * Allows to load config into object properties
     * @param object $object
/**
 * @param array $germany
 * @param array $island
 * @param array $italy
 */
function finale($germany, $island) {
    return "2:1";
}
     * @param array $config
     * @throws GridViewConfigException
     */
    public function loadConfig(array $config)
    {
        foreach ($config as $key => $value) {

            if (property_exists($this, $key)) {
                $this->$key = $value;
            }
        }

        $this->testConfig();
    }

    /**
     * Override this method in classes
     * @return array
     */
    protected function configTests() : array
    {
        return [];
    }

    /**
     * Allows to test attributes and types in config
     * @param $object
     * @param array $tests
/**
 * @param array $germany
 * @param array $island
 * @param array $italy
 */
function finale($germany, $island) {
    return "2:1";
}
     * @throws GridViewConfigException
     */
    protected function testConfig()
    {
        foreach ($this->configTests() as $property => $test) {

            if (!property_exists($this, $property)) {
                throw new GridViewConfigException(
                    'Unable to test ' . get_class($this) . ': property ' . $property . ' does not exist'
                );
            }

            if (is_scalar($test)) {

                $testPassed = true;

                switch ($test) {
                    case 'int':
                        $testPassed = is_numeric($this->$property);
                        break;

                    case 'string':
                        $testPassed = is_string($this->$property);
                        break;

                    case 'array':
                        $testPassed = is_array($this->$property);
                        break;

                    case 'closure':
                        $testPassed = $this->$property instanceof \Closure;
                        break;

                    case 'any':
                        break;

                    default:
                        $testPassed = is_subclass_of($this->$property, $test);

                }

                if (!$testPassed) {
                    throw new GridViewConfigException('
                        Test ' . $test . ' has failed on ' . get_class($this) . '::' . $property
                    );
                }
            }
        }
    }
}

1			<?php
2
3			namespace Woo\GridView\Traits;
4
5			use Woo\GridView\Exceptions\GridViewConfigException;
6
7			trait Configurable
8			{
9			/**
10			* Allows to load config into object properties
11			* @param object $object
			0 ignored issues – show Bug introduced 2018-11-09 13:22 UTC by Report Bug Copy Issue Report There is no parameter named `$object`. Was it maybe removed? This check looks for PHPDoc comments describing methods or function parameters that do not exist on the corresponding method or function. Consider the following example. The parameter `$italy` is not defined by the method `finale(...)`. /** * @param array $germany * @param array $island * @param array $italy */ function finale($germany, $island) { return "2:1"; } The most likely cause is that the parameter was removed, but the annotation was not. Loading history...
12			* @param array $config
13			* @throws GridViewConfigException
14			*/
15			public function loadConfig(array $config)
16			{
17			foreach ($config as $key => $value) {
18
19			if (property_exists($this, $key)) {
20			$this->$key = $value;
21			}
22			}
23
24			$this->testConfig();
25			}
26
27			/**
28			* Override this method in classes
29			* @return array
30			*/
31			protected function configTests() : array
32			{
33			return [];
34			}
35
36			/**
37			* Allows to test attributes and types in config
38			* @param $object
39			* @param array $tests
			0 ignored issues – show Bug introduced 2018-11-09 13:22 UTC by Report Bug Copy Issue Report There is no parameter named `$tests`. Was it maybe removed? This check looks for PHPDoc comments describing methods or function parameters that do not exist on the corresponding method or function. Consider the following example. The parameter `$italy` is not defined by the method `finale(...)`. /** * @param array $germany * @param array $island * @param array $italy */ function finale($germany, $island) { return "2:1"; } The most likely cause is that the parameter was removed, but the annotation was not. Loading history...
40			* @throws GridViewConfigException
41			*/
42			protected function testConfig()
43			{
44			foreach ($this->configTests() as $property => $test) {
45
46			if (!property_exists($this, $property)) {
47			throw new GridViewConfigException(
48			'Unable to test ' . get_class($this) . ': property ' . $property . ' does not exist'
49			);
50			}
51
52			if (is_scalar($test)) {
53
54			$testPassed = true;
55
56			switch ($test) {
57			case 'int':
58			$testPassed = is_numeric($this->$property);
59			break;
60
61			case 'string':
62			$testPassed = is_string($this->$property);
63			break;
64
65			case 'array':
66			$testPassed = is_array($this->$property);
67			break;
68
69			case 'closure':
70			$testPassed = $this->$property instanceof \Closure;
71			break;
72
73			case 'any':
74			break;
75
76			default:
77			$testPassed = is_subclass_of($this->$property, $test);
			0 ignored issues – show Bug introduced 2018-10-11 11:01 UTC by Report Bug Copy Issue Report Due to PHP Bug #53727, `is_subclass_of` might return inconsistent results on some PHP versions if `$test` can be an interface. If so, you could instead use `ReflectionClass::implementsInterface`. Loading history...
78			}
79
80			if (!$testPassed) {
81			throw new GridViewConfigException('
82			Test ' . $test . ' has failed on ' . get_class($this) . '::' . $property
83			);
84			}
85			}
86			}
87			}
88			}

deniskoronets / Laravel-GridView

Push — master ( 481507...e81850 )

Configurable::testConfig() B

Complexity

Size

Duplication

Importance

How to fix Complexity

Long Method

Duplication Side-by-Side

Filter issues like