ResponseTest::testErrorFactory() - Code Metrics - Inspection of "Response factory methods" - demvsystems/jsend - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Pull Request — master (#11)

by DEMV

created 2018-05-30 09:37 UTC

ResponseTest::testErrorFactory() A

↳ Parent: ResponseTest

Complexity

Conditions	1
Paths	1

Size

Total Lines	8
Code Lines	5

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
dl	0
loc	8
rs	9.4285
c	1
b	0
f	0
cc	1
eloc	5
nc	1
nop	0

<?php

namespace Demv\JSend\Test;

use Demv\JSend\JSend;
use Demv\JSend\JSendResponse;
use Demv\JSend\ResponseFactory;
use Demv\JSend\Status;
use Demv\JSend\StatusInterface;
use PHPUnit\Framework\TestCase;

final class ResponseTest extends TestCase
{
    public function testDefaultHttpStatusCode(): void
    {
        $this->assertEquals(200, JSend::getDefaultHttpStatusCode(ResponseFactory::instance()->success()));
        $this->assertEquals(200, JSend::getDefaultHttpStatusCode(ResponseFactory::instance()->fail()));
        $this->assertEquals(500, JSend::getDefaultHttpStatusCode(ResponseFactory::instance()->error(['message' => 'wtf'])));
        $this->assertEquals(400, JSend::getDefaultHttpStatusCode(ResponseFactory::instance()->error(['message' => 'wtf', 'code' => 400])));
    }

    public function testSuccessFactory(): void
    {
        $response = JSendResponse::success(['Erfolgreich!']);

        $this->assertTrue($response->getStatus()->isSuccess());
        $this->assertEquals(['Erfolgreich!'], $response->getData());
    }

    public function testFailFactory(): void
    {
        $response = JSendResponse::fail(['Irgendwas lief schief']);

        $this->assertTrue($response->getStatus()->isFail());
        $this->assertEquals(['Irgendwas lief schief'], $response->getData());
    }

    public function testErrorFactory(): void
    {
        $response = JSendResponse::error('Es ist ein Fehler aufgetreten');

        $this->assertTrue($response->getStatus()->isError());
        $this->assertEmpty($response->getData());
        $this->assertEquals('Es ist ein Fehler aufgetreten', $response->getError()->getMessage());
    }

    public function testSuccessConversion(): void
    {
        $json = '{"status": "success", "data": ["Holy", "Moly"]}';

        $success = new DummyResponse();
        $success->withBody(new DummyStream($json));
        $success->withStatus(214);

        $response = ResponseFactory::instance()->convert($success);
        $this->assertTrue($response->getStatus()->isSuccess());
        $this->assertEquals(['Holy', 'Moly'], $response->getData());
        $this->assertJsonStringEqualsJsonString($json, json_encode($response));
    }

    public function testFailConversion(): void
    {
        $fail = new DummyResponse();
        $fail->withBody(new DummyStream('{"status": "fail", "data": null}'));

        $response = ResponseFactory::instance()->convert($fail);
        $this->assertTrue($response->getStatus()->isFail());
        $this->assertEmpty($response->getData());
        $this->assertJsonStringEqualsJsonString('{"status": "fail", "data": null}', json_encode($response));
    }

    public function testErrorConversion(): void
    {
        $json = '{"status": "error", "data": ["Invalid"], "message": "Something is not right..."}';

        $error = new DummyResponse();
        $error->withBody(new DummyStream($json));
        $error->withStatus(501);

        $result         = json_decode($json, true);
        $result['code'] = $error->getStatusCode();

        $response = ResponseFactory::instance()->convert($error);
        $this->assertTrue($response->getStatus()->isError());
        $this->assertEquals(['Invalid'], $response->getData());
        $this->assertJsonStringEqualsJsonString(json_encode($result), json_encode($response));
        $this->assertEquals('Something is not right...', $response->getError()->getMessage());
        $this->assertEquals($error->getStatusCode(), $response->getError()->getCode());
    }

    public function testMapping(): void
    {
        $response = new JSendResponse(Status::translate(1), null);
        $this->assertTrue($response->getStatus()->isSuccess());

        $response = new JSendResponse(Status::translate(0), null);
        $this->assertTrue($response->getStatus()->isFail());

        $response = new JSendResponse(Status::translate(-1), null);
        $this->assertTrue($response->getStatus()->isError());

        $response = new JSendResponse(Status::translate(true), null);
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
        $this->assertTrue($response->getStatus()->isSuccess());

        $response = new JSendResponse(Status::translate(false), null);
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
        $this->assertTrue($response->getStatus()->isFail());

        $response = new JSendResponse(Status::translate(false, [false => StatusInterface::STATUS_ERROR]), null);
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
        $this->assertTrue($response->getStatus()->isError());
    }

    public function testPsr7Response(): void
    {
        $response = JSendResponse::success(['Erfolgreich!'])->asResponse(200);
        $this->assertEquals(200, $response->getStatusCode());
        $this->assertEquals('{"status":"success","data":["Erfolgreich!"]}', $response->getBody()->getContents());

        $response = JSendResponse::fail(['Irgendwas lief schief'])->asResponse(400);
        $this->assertEquals(400, $response->getStatusCode());
        $this->assertEquals('{"status":"fail","data":["Irgendwas lief schief"]}', $response->getBody()->getContents());

        $response = JSendResponse::error('Es ist ein Fehler aufgetreten', 404)->asResponse(500);
        $this->assertEquals(500, $response->getStatusCode());
        $this->assertEquals('{"status":"error","message":"Es ist ein Fehler aufgetreten","code":404}', $response->getBody()->getContents());
    }
}


1		<?php
2
3		namespace Demv\JSend\Test;
4
5		use Demv\JSend\JSend;
6		use Demv\JSend\JSendResponse;
7		use Demv\JSend\ResponseFactory;
8		use Demv\JSend\Status;
9		use Demv\JSend\StatusInterface;
10		use PHPUnit\Framework\TestCase;
11
12		final class ResponseTest extends TestCase
13		{
14		public function testDefaultHttpStatusCode(): void
15		{
16		$this->assertEquals(200, JSend::getDefaultHttpStatusCode(ResponseFactory::instance()->success()));
17		$this->assertEquals(200, JSend::getDefaultHttpStatusCode(ResponseFactory::instance()->fail()));
18		$this->assertEquals(500, JSend::getDefaultHttpStatusCode(ResponseFactory::instance()->error(['message' => 'wtf'])));
19		$this->assertEquals(400, JSend::getDefaultHttpStatusCode(ResponseFactory::instance()->error(['message' => 'wtf', 'code' => 400])));
20		}
21
22	View Code Duplication	public function testSuccessFactory(): void
23		{
24		$response = JSendResponse::success(['Erfolgreich!']);
25
26		$this->assertTrue($response->getStatus()->isSuccess());
27		$this->assertEquals(['Erfolgreich!'], $response->getData());
28		}
29
30	View Code Duplication	public function testFailFactory(): void
31		{
32		$response = JSendResponse::fail(['Irgendwas lief schief']);
33
34		$this->assertTrue($response->getStatus()->isFail());
35		$this->assertEquals(['Irgendwas lief schief'], $response->getData());
36		}
37
38		public function testErrorFactory(): void
39		{
40		$response = JSendResponse::error('Es ist ein Fehler aufgetreten');
41
42		$this->assertTrue($response->getStatus()->isError());
43		$this->assertEmpty($response->getData());
44		$this->assertEquals('Es ist ein Fehler aufgetreten', $response->getError()->getMessage());
45		}
46
47		public function testSuccessConversion(): void
48		{
49		$json = '{"status": "success", "data": ["Holy", "Moly"]}';
50
51		$success = new DummyResponse();
52		$success->withBody(new DummyStream($json));
53		$success->withStatus(214);
54
55		$response = ResponseFactory::instance()->convert($success);
56		$this->assertTrue($response->getStatus()->isSuccess());
57		$this->assertEquals(['Holy', 'Moly'], $response->getData());
58		$this->assertJsonStringEqualsJsonString($json, json_encode($response));
59		}
60
61		public function testFailConversion(): void
62		{
63		$fail = new DummyResponse();
64		$fail->withBody(new DummyStream('{"status": "fail", "data": null}'));
65
66		$response = ResponseFactory::instance()->convert($fail);
67		$this->assertTrue($response->getStatus()->isFail());
68		$this->assertEmpty($response->getData());
69		$this->assertJsonStringEqualsJsonString('{"status": "fail", "data": null}', json_encode($response));
70		}
71
72		public function testErrorConversion(): void
73		{
74		$json = '{"status": "error", "data": ["Invalid"], "message": "Something is not right..."}';
75
76		$error = new DummyResponse();
77		$error->withBody(new DummyStream($json));
78		$error->withStatus(501);
79
80		$result = json_decode($json, true);
81		$result['code'] = $error->getStatusCode();
82
83		$response = ResponseFactory::instance()->convert($error);
84		$this->assertTrue($response->getStatus()->isError());
85		$this->assertEquals(['Invalid'], $response->getData());
86		$this->assertJsonStringEqualsJsonString(json_encode($result), json_encode($response));
87		$this->assertEquals('Something is not right...', $response->getError()->getMessage());
88		$this->assertEquals($error->getStatusCode(), $response->getError()->getCode());
89		}
90
91		public function testMapping(): void
92		{
93		$response = new JSendResponse(Status::translate(1), null);
94		$this->assertTrue($response->getStatus()->isSuccess());
95
96		$response = new JSendResponse(Status::translate(0), null);
97		$this->assertTrue($response->getStatus()->isFail());
98
99		$response = new JSendResponse(Status::translate(-1), null);
100		$this->assertTrue($response->getStatus()->isError());
101
102		$response = new JSendResponse(Status::translate(true), null);
		0 ignored issues – show Documentation introduced 2018-02-06 20:49 UTC by Report Bug Copy Issue Report `true` is of type `boolean`, but the function expects a `integer`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
103		$this->assertTrue($response->getStatus()->isSuccess());
104
105		$response = new JSendResponse(Status::translate(false), null);
		0 ignored issues – show Documentation introduced 2018-02-06 20:49 UTC by Report Bug Copy Issue Report `false` is of type `boolean`, but the function expects a `integer`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
106		$this->assertTrue($response->getStatus()->isFail());
107
108		$response = new JSendResponse(Status::translate(false, [false => StatusInterface::STATUS_ERROR]), null);
		0 ignored issues – show Documentation introduced 2018-02-06 20:49 UTC by Report Bug Copy Issue Report `false` is of type `boolean`, but the function expects a `integer`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
109		$this->assertTrue($response->getStatus()->isError());
110		}
111
112		public function testPsr7Response(): void
113		{
114		$response = JSendResponse::success(['Erfolgreich!'])->asResponse(200);
115		$this->assertEquals(200, $response->getStatusCode());
116		$this->assertEquals('{"status":"success","data":["Erfolgreich!"]}', $response->getBody()->getContents());
117
118		$response = JSendResponse::fail(['Irgendwas lief schief'])->asResponse(400);
119		$this->assertEquals(400, $response->getStatusCode());
120		$this->assertEquals('{"status":"fail","data":["Irgendwas lief schief"]}', $response->getBody()->getContents());
121
122		$response = JSendResponse::error('Es ist ein Fehler aufgetreten', 404)->asResponse(500);
123		$this->assertEquals(500, $response->getStatusCode());
124		$this->assertEquals('{"status":"error","message":"Es ist ein Fehler aufgetreten","code":404}', $response->getBody()->getContents());
125		}
126		}
127

demvsystems / jsend

Pull Request — master (#11)

ResponseTest::testErrorFactory() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like