VideoController - Code Metrics - deltcod/LaravelTube - Measure and Improve Code Quality continuously with Scrutinizer

VideoController A
last analyzed 2017-07-28 07:27 UTC

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	202
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	8

Test Coverage

Coverage

100%

Importance

Changes	4
Bugs	0	Features	0

Metric	Value
wmc	11
c	4
b	0
f	0
lcom	1
cbo	8
dl	0
loc	202
ccs	55
cts	55
cp	1
rs	10

10 Methods

Rating	Name	Size	Complexity
A	getAllVideos()	6	1
A	getBestVideos()	6	1
A	getVideosUser()	7	1
A	getVideosForCategory()	6	1
A	getVideosForSearch()	6	1
A	store()	19	1
A	show()	6	1
A	update()	8	1
A	destroy()	10	1
A	saveAndConvert()	10	1

<?php

namespace App\Http\Controllers;

use App\Http\Requests\VideoUploadRequest;
use App\Repositories\UserRepository as User;
use App\Repositories\VideoRepository as Video;
use App\Transformers\VideoTransformer;
use Chrisbjr\ApiGuard\Http\Controllers\ApiGuardController;
use Illuminate\Http\Request;
use Illuminate\Support\Facades\Storage;
use Linkthrow\Ffmpeg\Classes\FFMPEG;

/**
 * Class VideoController.
 */
class VideoController extends ApiGuardController
{
    /**
     * @var VideoTransformer
     */
    protected $videoTransformer;

    /**
     * @var Video
     */
    protected $video;

    /**
     * @var array
     */
    protected $apiMethods = [
        'getAllVideos' => [
            'keyAuthentication' => false,
        ],
        'show' => [
            'keyAuthentication' => false,
        ],
        'getBestVideos' => [
            'keyAuthentication' => false,
        ],
        'getVideosUser' => [
            'keyAuthentication' => false,
        ],
        'getVideosForCategory' => [
            'keyAuthentication' => false,
        ],
        'getVideosForSearch' => [
            'keyAuthentication' => false,
        ],
        'store' => [
            'limits' => [
                'key' => [
                    'increment' => '1 hour',
                    'limit'     => 10,
                ],
            ],
        ],
    ];

    /**
     * VideoController constructor.
     *
     * @param VideoTransformer $videoTransformer
     * @param Video            $video
     * @param User             $user
     */
    public function __construct(Video $video, User $user, VideoTransformer $videoTransformer)
    {
        parent::__construct();

        $this->videoTransformer = $videoTransformer;
        $this->video = $video;
        $this->user = $user;
    }

    /**
     * Return all Videos.
     */
    public function getAllVideos()
    {
        $video = $this->video->all();

        return $this->response->withCollection($video, $this->videoTransformer);
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
    }

    /**
     * Return the best Videos.
     */
    public function getBestVideos()
    {
        $video = $this->video->best();

        return $this->response->withCollection($video, $this->videoTransformer);
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
    }

    /**
     * Return Videos only user.
     */
    public function getVideosUser($id)
    {
        $user = $this->user->findOrFail($id);
        $video = $user->getVideos;

        return $this->response->withCollection($video, $this->videoTransformer);
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
    }

    /**
     * Return Videos for Category.
     */
    public function getVideosForCategory($name)
    {
        $video = $this->video->findBy('category', $name);

        return $this->response->withCollection($video, $this->videoTransformer);
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
    }

    /**
     * Return Videos for Search.
     */
    public function getVideosForSearch($search)
    {
        $video = $this->video->search('name', $search);

        return $this->response->withCollection($video, $this->videoTransformer);
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
    }

    /**
     * Store a newly created video in storage.
     *
     * @param VideoUploadRequest $request
     *
     * @return mixed
     */
    public function store(VideoUploadRequest $request)
    {
        $user = $this->user->authenticated();
        $file = $request->video;

        $nameFile = str_replace(' ', '', $request->input('name').$user->id);

        $data = [
            'name'     => $request->input('name'),
            'category' => $request->input('category'),
            'path'     => Storage::url('videos/'.$nameFile),
            'user_id'  => $user->id,
        ];

        $video = $this->video->create($data);

        $this->saveAndConvert($file, $nameFile);

        return $this->response->withItem($video, $this->videoTransformer);
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
    }

    /**
     * @param $id
     *
     * @return mixed
     */
    public function show($id)
    {
        $video = $this->video->findOrFail($id);

        return $this->response->withItem($video, $this->videoTransformer);
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
    }

    /**
     * Update the specified video in storage.
     *
     * @param Request $request
     * @param $id
     *
     * @return mixed
     */
    public function update(Request $request, $id)
    {
        $video = $this->video->findOrFail($id);

        $this->video->update($request->all(), $id);

        return $this->response->withItem($video, $this->videoTransformer);
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
    }

    /**
     * Remove the specified video from storage.
     *
     * @param $id
     *
     * @return mixed
     */
    public function destroy($id)
    {
        $video = $this->video->findOrFail($id);

        $nameFile = str_replace('storage/', '', $video->path);

        Storage::disk('public')->delete([$nameFile.'.mp4', $nameFile.'.webm']);

        $this->video->delete($id);
    }

    /**
     * Save and Convert to webm video.
     *
     * @param $video
     * @param $name
     */
    private function saveAndConvert($video, $name)
    {
        Storage::disk('public')->put('videos/'.$name.'.mp4', file_get_contents($video->getRealPath()));

        FFMPEG::convert()
            ->input($video->getRealPath())
            ->output(storage_path('app/public/videos/').$name.'.webm')
            ->overwrite(true)
            ->go();
    }
}


1		<?php
2
3		namespace App\Http\Controllers;
4
5		use App\Http\Requests\VideoUploadRequest;
6		use App\Repositories\UserRepository as User;
7		use App\Repositories\VideoRepository as Video;
8		use App\Transformers\VideoTransformer;
9		use Chrisbjr\ApiGuard\Http\Controllers\ApiGuardController;
10		use Illuminate\Http\Request;
11		use Illuminate\Support\Facades\Storage;
12		use Linkthrow\Ffmpeg\Classes\FFMPEG;
13
14		/**
15		* Class VideoController.
16		*/
17		class VideoController extends ApiGuardController
18		{
19		/**
20		* @var VideoTransformer
21		*/
22		protected $videoTransformer;
23
24		/**
25		* @var Video
26		*/
27		protected $video;
28
29		/**
30		* @var array
31		*/
32		protected $apiMethods = [
33		'getAllVideos' => [
34		'keyAuthentication' => false,
35		],
36		'show' => [
37		'keyAuthentication' => false,
38		],
39		'getBestVideos' => [
40		'keyAuthentication' => false,
41		],
42		'getVideosUser' => [
43		'keyAuthentication' => false,
44		],
45		'getVideosForCategory' => [
46		'keyAuthentication' => false,
47		],
48		'getVideosForSearch' => [
49		'keyAuthentication' => false,
50		],
51		'store' => [
52		'limits' => [
53		'key' => [
54		'increment' => '1 hour',
55		'limit' => 10,
56		],
57		],
58		],
59		];
60
61		/**
62		* VideoController constructor.
63		*
64		* @param VideoTransformer $videoTransformer
65		* @param Video $video
66		* @param User $user
67		*/
68	12	public function __construct(Video $video, User $user, VideoTransformer $videoTransformer)
69		{
70	12	parent::__construct();
71
72	12	$this->videoTransformer = $videoTransformer;
73	12	$this->video = $video;
74	12	$this->user = $user;
75	12	}
76
77		/**
78		* Return all Videos.
79		*/
80	5	public function getAllVideos()
81		{
82	5	$video = $this->video->all();
83
84	5	return $this->response->withCollection($video, $this->videoTransformer);
		0 ignored issues – show Documentation introduced 2017-07-27 08:37 UTC by Report Bug Copy Issue Report `$this->videoTransformer` is of type `object<App\Transformers\VideoTransformer>`, but the function expects a `callable`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
85		}
86
87		/**
88		* Return the best Videos.
89		*/
90	1	public function getBestVideos()
91		{
92	1	$video = $this->video->best();
93
94	1	return $this->response->withCollection($video, $this->videoTransformer);
		0 ignored issues – show Documentation introduced 2017-07-27 08:37 UTC by Report Bug Copy Issue Report `$this->videoTransformer` is of type `object<App\Transformers\VideoTransformer>`, but the function expects a `callable`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
95		}
96
97		/**
98		* Return Videos only user.
99		*/
100	1	public function getVideosUser($id)
101		{
102	1	$user = $this->user->findOrFail($id);
103	1	$video = $user->getVideos;
104
105	1	return $this->response->withCollection($video, $this->videoTransformer);
		0 ignored issues – show Documentation introduced 2017-07-27 08:37 UTC by Report Bug Copy Issue Report `$this->videoTransformer` is of type `object<App\Transformers\VideoTransformer>`, but the function expects a `callable`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
106		}
107
108		/**
109		* Return Videos for Category.
110		*/
111	1	public function getVideosForCategory($name)
112		{
113	1	$video = $this->video->findBy('category', $name);
114
115	1	return $this->response->withCollection($video, $this->videoTransformer);
		0 ignored issues – show Documentation introduced 2017-07-27 08:37 UTC by Report Bug Copy Issue Report `$this->videoTransformer` is of type `object<App\Transformers\VideoTransformer>`, but the function expects a `callable`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
116		}
117
118		/**
119		* Return Videos for Search.
120		*/
121	1	public function getVideosForSearch($search)
122		{
123	1	$video = $this->video->search('name', $search);
124
125	1	return $this->response->withCollection($video, $this->videoTransformer);
		0 ignored issues – show Documentation introduced 2017-07-27 08:37 UTC by Report Bug Copy Issue Report `$this->videoTransformer` is of type `object<App\Transformers\VideoTransformer>`, but the function expects a `callable`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
126		}
127
128		/**
129		* Store a newly created video in storage.
130		*
131		* @param VideoUploadRequest $request
132		*
133		* @return mixed
134		*/
135	1	public function store(VideoUploadRequest $request)
136		{
137	1	$user = $this->user->authenticated();
138	1	$file = $request->video;
		0 ignored issues – show Bug introduced 2017-07-27 08:37 UTC by Report Bug Copy Issue Report The property `video` does not seem to exist in `App\Http\Requests\VideoUploadRequest`. An attempt at access to an undefined property has been detected. This may either be a typographical error or the property has been renamed but there are still references to its old name. If you really want to allow access to undefined properties, you can define magic methods to allow access. See the php core documentation on Overloading. Loading history...
139	1	$nameFile = str_replace(' ', '', $request->input('name').$user->id);
140
141		$data = [
142	1	'name' => $request->input('name'),
143	1	'category' => $request->input('category'),
144	1	'path' => Storage::url('videos/'.$nameFile),
145	1	'user_id' => $user->id,
146	1	];
147
148	1	$video = $this->video->create($data);
149
150	1	$this->saveAndConvert($file, $nameFile);
151
152	1	return $this->response->withItem($video, $this->videoTransformer);
		0 ignored issues – show Documentation introduced 2017-07-27 08:37 UTC by Report Bug Copy Issue Report `$this->videoTransformer` is of type `object<App\Transformers\VideoTransformer>`, but the function expects a `callable`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
153		}
154
155		/**
156		* @param $id
157		*
158		* @return mixed
159		*/
160	2	public function show($id)
161		{
162	2	$video = $this->video->findOrFail($id);
163
164	1	return $this->response->withItem($video, $this->videoTransformer);
		0 ignored issues – show Documentation introduced 2017-07-27 08:37 UTC by Report Bug Copy Issue Report `$this->videoTransformer` is of type `object<App\Transformers\VideoTransformer>`, but the function expects a `callable`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
165		}
166
167		/**
168		* Update the specified video in storage.
169		*
170		* @param Request $request
171		* @param $id
172		*
173		* @return mixed
174		*/
175	1	public function update(Request $request, $id)
176		{
177	1	$video = $this->video->findOrFail($id);
178
179	1	$this->video->update($request->all(), $id);
180
181	1	return $this->response->withItem($video, $this->videoTransformer);
		0 ignored issues – show Documentation introduced 2017-07-27 08:37 UTC by Report Bug Copy Issue Report `$this->videoTransformer` is of type `object<App\Transformers\VideoTransformer>`, but the function expects a `callable`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
182		}
183
184		/**
185		* Remove the specified video from storage.
186		*
187		* @param $id
188		*
189		* @return mixed
190		*/
191	1	public function destroy($id)
192		{
193	1	$video = $this->video->findOrFail($id);
194
195	1	$nameFile = str_replace('storage/', '', $video->path);
196
197	1	Storage::disk('public')->delete([$nameFile.'.mp4', $nameFile.'.webm']);
198
199	1	$this->video->delete($id);
200	1	}
201
202		/**
203		* Save and Convert to webm video.
204		*
205		* @param $video
206		* @param $name
207		*/
208	1	private function saveAndConvert($video, $name)
209		{
210	1	Storage::disk('public')->put('videos/'.$name.'.mp4', file_get_contents($video->getRealPath()));
211
212	1	FFMPEG::convert()
213	1	->input($video->getRealPath())
214	1	->output(storage_path('app/public/videos/').$name.'.webm')
215	1	->overwrite(true)
216	1	->go();
217	1	}
218		}
219

deltcod / LaravelTube

VideoController A last analyzed 2017-07-28 07:27 UTC

Complexity

Size/Duplication

Coupling/Cohesion

Test Coverage

Importance

10 Methods

Duplication Side-by-Side

Filter issues like

VideoController A
last analyzed 2017-07-28 07:27 UTC