UserController - Code Metrics - deltcod/LaravelTube - Measure and Improve Code Quality continuously with Scrutinizer

UserController A
last analyzed 2017-07-28 07:27 UTC

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	119
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	4

Test Coverage

Coverage

100%

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
wmc	7
c	1
b	0
f	0
lcom	1
cbo	4
dl	0
loc	119
ccs	34
cts	34
cp	1
rs	10

4 Methods

Rating	Name	Size	Complexity
A	getAllUsers()	6	1
A	update()	21	2
A	delete()	4	1
A	storeImage()	11	1

<?php

namespace App\Http\Controllers;

use App\Http\Requests\UserUpdateRequest;
use App\Repositories\UserRepository as User;
use App\Transformers\UserTransformer;
use Chrisbjr\ApiGuard\Http\Controllers\ApiGuardController;
use Illuminate\Support\Facades\Storage;

/**
 * Class UserController.
 */
class UserController extends ApiGuardController
{
    /**
     * @var UserTransformer
     */
    protected $userTransformer;

    /**
     * @var array
     */
    protected $apiMethods = [
        'getAllUsers' => [
            'keyAuthentication' => false,
        ],
        'show' => [
            'keyAuthentication' => false,
        ],
    ];

    /**
     * UserController constructor.
     *
     * @param User            $user
     * @param UserTransformer $userTransformer
     */
    public function __construct(User $user, UserTransformer $userTransformer)
    {
        parent::__construct();

        $this->userTransformer = $userTransformer;
        $this->user = $user;
    }

    /**
     * Get all users.
     *
     * @return mixed
     */
    public function getAllUsers()
    {
        $user = $this->user->all();

        return $this->response->withCollection($user, $this->userTransformer);
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
    }

    /**
     * Get user find id.
     *
     * @param $id
     *
     * @return mixed
     */
    public function show($id)
    {
        $user = $this->user->findOrFail($id);

        return $this->response->withItem($user, $this->userTransformer);
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
    }

    /**
     * Update user.
     *
     * @param UserUpdateRequest $request
     * @param $id
     *
     * @return mixed
     */
    public function update(UserUpdateRequest $request, $id)
    {
        $user = $this->user->findOrFail($id);

        if ($request->avatar != '') {
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
            $path = $this->storeImage($request->avatar, $user);
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
        } else {
            $path = $user->avatar;
        }

        $data = [
            'name'     => $request->input('name'),
            'email'    => $request->input('email'),
            'password' => bcrypt($request->input('password')),

            'avatar'   => $path,
        ];

        $this->user->update($data, $id);

        return $this->response->withItem($user, $this->userTransformer);
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
    }

    /**
     * Delete user.
     *
     * @param $id
     */
    public function delete($id)
    {
        $this->user->delete($id);
    }

    /**
     * Store image avatar.
     *
     * @param $image
     * @param $user
     *
     * @return mixed
     */
    private function storeImage($image, $user)
    {
        $path = Storage::url('images/avatars/'.$user->id.'.'.$image->getClientOriginalExtension());

        Storage::disk('public')->put(
            'images/avatars/'.$user->id.'.'.$image->getClientOriginalExtension(),
            file_get_contents($image->getRealPath())
        );

        return $path;
    }
}


1		<?php
2
3		namespace App\Http\Controllers;
4
5		use App\Http\Requests\UserUpdateRequest;
6		use App\Repositories\UserRepository as User;
7		use App\Transformers\UserTransformer;
8		use Chrisbjr\ApiGuard\Http\Controllers\ApiGuardController;
9		use Illuminate\Support\Facades\Storage;
10
11		/**
12		* Class UserController.
13		*/
14		class UserController extends ApiGuardController
15		{
16		/**
17		* @var UserTransformer
18		*/
19		protected $userTransformer;
20
21		/**
22		* @var array
23		*/
24		protected $apiMethods = [
25		'getAllUsers' => [
26		'keyAuthentication' => false,
27		],
28		'show' => [
29		'keyAuthentication' => false,
30		],
31		];
32
33		/**
34		* UserController constructor.
35		*
36		* @param User $user
37		* @param UserTransformer $userTransformer
38		*/
39	5	public function __construct(User $user, UserTransformer $userTransformer)
40		{
41	5	parent::__construct();
42
43	5	$this->userTransformer = $userTransformer;
44	5	$this->user = $user;
45	5	}
46
47		/**
48		* Get all users.
49		*
50		* @return mixed
51		*/
52	4	public function getAllUsers()
53		{
54	4	$user = $this->user->all();
55
56	4	return $this->response->withCollection($user, $this->userTransformer);
		0 ignored issues – show Documentation introduced 2017-07-27 08:37 UTC by Report Bug Copy Issue Report `$this->userTransformer` is of type `object<App\Transformers\UserTransformer>`, but the function expects a `callable`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
57		}
58
59		/**
60		* Get user find id.
61		*
62		* @param $id
63		*
64		* @return mixed
65		*/
66	1	public function show($id)
67		{
68	1	$user = $this->user->findOrFail($id);
69
70	1	return $this->response->withItem($user, $this->userTransformer);
		0 ignored issues – show Documentation introduced 2017-07-27 08:37 UTC by Report Bug Copy Issue Report `$this->userTransformer` is of type `object<App\Transformers\UserTransformer>`, but the function expects a `callable`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
71		}
72
73		/**
74		* Update user.
75		*
76		* @param UserUpdateRequest $request
77		* @param $id
78		*
79		* @return mixed
80		*/
81	2	public function update(UserUpdateRequest $request, $id)
82		{
83	2	$user = $this->user->findOrFail($id);
84
85	2	if ($request->avatar != '') {
		0 ignored issues – show Documentation introduced 2017-07-27 08:37 UTC by Report Bug Copy Issue Report The property `avatar` does not exist on `object<App\Http\Requests\UserUpdateRequest>`. Since you implemented `__get`, maybe consider adding a @property annotation. Since your code implements the magic getter `_get`, this function will be called for any read access on an undefined variable. You can add the `@property` annotation to your class or interface to document the existence of this variable. <?php /** * @property int $x * @property int $y * @property string $text */ class MyLabel { private $properties; private $allowedProperties = array('x', 'y', 'text'); public function __get($name) { if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) { return $properties[$name]; } else { return null; } } public function __set($name, $value) { if (in_array($name, $this->allowedProperties)) { $properties[$name] = $value; } else { throw new \LogicException("Property $name is not defined."); } } } If the property has read access only, you can use the @property-read annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property. Loading history...
86	1	$path = $this->storeImage($request->avatar, $user);
		0 ignored issues – show Documentation introduced 2017-07-27 08:37 UTC by Report Bug Copy Issue Report The property `avatar` does not exist on `object<App\Http\Requests\UserUpdateRequest>`. Since you implemented `__get`, maybe consider adding a @property annotation. Since your code implements the magic getter `_get`, this function will be called for any read access on an undefined variable. You can add the `@property` annotation to your class or interface to document the existence of this variable. <?php /** * @property int $x * @property int $y * @property string $text */ class MyLabel { private $properties; private $allowedProperties = array('x', 'y', 'text'); public function __get($name) { if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) { return $properties[$name]; } else { return null; } } public function __set($name, $value) { if (in_array($name, $this->allowedProperties)) { $properties[$name] = $value; } else { throw new \LogicException("Property $name is not defined."); } } } If the property has read access only, you can use the @property-read annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property. Loading history...
87	1	} else {
88	1	$path = $user->avatar;
89		}
90
91		$data = [
92	2	'name' => $request->input('name'),
93	2	'email' => $request->input('email'),
94	2	'password' => bcrypt($request->input('password')),
		0 ignored issues – show Bug introduced 2017-07-27 08:37 UTC by Report Bug Copy Issue Report It seems like `$request->input('password')` targeting `Illuminate\Http\Request::input()` can also be of type `array`; however, `bcrypt()` does only seem to accept `string`, maybe add an additional type check? This check looks at variables that are passed out again to other methods. If the outgoing method call has stricter type requirements than the method itself, an issue is raised. An additional type check may prevent trouble. Loading history...
95	2	'avatar' => $path,
96	2	];
97
98	2	$this->user->update($data, $id);
99
100	2	return $this->response->withItem($user, $this->userTransformer);
		0 ignored issues – show Documentation introduced 2017-07-27 08:37 UTC by Report Bug Copy Issue Report `$this->userTransformer` is of type `object<App\Transformers\UserTransformer>`, but the function expects a `callable`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
101		}
102
103		/**
104		* Delete user.
105		*
106		* @param $id
107		*/
108	1	public function delete($id)
109		{
110	1	$this->user->delete($id);
111	1	}
112
113		/**
114		* Store image avatar.
115		*
116		* @param $image
117		* @param $user
118		*
119		* @return mixed
120		*/
121	1	private function storeImage($image, $user)
122		{
123	1	$path = Storage::url('images/avatars/'.$user->id.'.'.$image->getClientOriginalExtension());
124
125	1	Storage::disk('public')->put(
126	1	'images/avatars/'.$user->id.'.'.$image->getClientOriginalExtension(),
127	1	file_get_contents($image->getRealPath())
128	1	);
129
130	1	return $path;
131		}
132		}
133

deltcod / LaravelTube

UserController A last analyzed 2017-07-28 07:27 UTC

Complexity

Size/Duplication

Coupling/Cohesion

Test Coverage

Importance

4 Methods

Duplication Side-by-Side

Filter issues like

UserController A
last analyzed 2017-07-28 07:27 UTC