User::update() - Code Metrics - Inspection of "fix scrutinizer config to new version" - delboy1978uk/user - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — master ( aab8f3...c0357c )

by Derek Stephen

created 2022-01-03 15:03 UTC

User::update() A

↳ Parent: User

Complexity

Conditions	2
Paths	2

Size

Total Lines	10
Code Lines	5

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	6
CRAP Score	2

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
cc	2
eloc	5
c	1
b	0
f	0
nc	2
nop	1
dl	0
loc	10
ccs	6
cts	6
cp	1
crap	2
rs	10

<?php

namespace Del\Collection;

use Del\Entity\User as UserEntity;
use Doctrine\Common\Collections\ArrayCollection;
use LogicException;

class User extends ArrayCollection
{
    /**
     * @param UserEntity $user
     * @return $this
     */
    public function update(UserEntity $user)
    {
        $key = $this->findKey($user);
        if($key) {

            $this->offsetSet($key,$user);
            return $this;

        }
        throw new LogicException('User was not in the collection.');
    }

    /**
     * @param UserEntity $user
     */
    public function append(UserEntity $user)
    {
        $this->add($user);
    }

    /**
     * @return UserEntity|null
     */
    public function current()
    {
        return parent::current();
    }

    /**
     * @param UserEntity $user
     * @return bool|int
     */
    public function findKey(UserEntity $user)
    {
        $it = $this->getIterator();
        $it->rewind();
        while($it->valid()) {
            if($it->current()->getId() == $user->getId()) {
                return $it->key();

            }
            $it->next();
        }
        return false;
    }



    public function findById($id)
    {
        $it = $this->getIterator();
        $it->rewind();
        while($it->valid()) {
            if($it->current()->getId() == $id) {
                return $it->current();
            }
            $it->next();
        }

        return false;
    }

}

1		<?php
2
3		namespace Del\Collection;
4
5		use Del\Entity\User as UserEntity;
6		use Doctrine\Common\Collections\ArrayCollection;
7		use LogicException;
8
9		class User extends ArrayCollection
10		{
11		/**
12		* @param UserEntity $user
13		* @return $this
14		*/
15	1	public function update(UserEntity $user)
16		{
17	1	$key = $this->findKey($user);
18	1	if($key) {
19
20	1	$this->offsetSet($key,$user);
21	1	return $this;
22
23		}
24	1	throw new LogicException('User was not in the collection.');
25		}
26
27		/**
28		* @param UserEntity $user
29		*/
30	4	public function append(UserEntity $user)
31		{
32	4	$this->add($user);
33	4	}
34
35		/**
36		* @return UserEntity\|null
37		*/
38	1	public function current()
39		{
40	1	return parent::current();
41		}
42
43		/**
44		* @param UserEntity $user
45		* @return bool\|int
46		*/
47	2	public function findKey(UserEntity $user)
48		{
49	2	$it = $this->getIterator();
50	2	$it->rewind();
51	2	while($it->valid()) {
52	2	if($it->current()->getId() == $user->getId()) {
53	1	return $it->key();
		0 ignored issues – show Bug Best Practice introduced 2022-01-03 15:06 UTC by Report Bug Copy Issue Report The expression `return $it->key()` also could return the type `string` which is incompatible with the documented return type `boolean\|integer`. Loading history...
54		}
55	2	$it->next();
56		}
57	2	return false;
58		}
59
60
61
62	2	public function findById($id)
63		{
64	2	$it = $this->getIterator();
65	2	$it->rewind();
66	2	while($it->valid()) {
67	2	if($it->current()->getId() == $id) {
68	1	return $it->current();
69		}
70	2	$it->next();
71		}
72
73	1	return false;
74		}
75
76		}

delboy1978uk / user

Push — master ( aab8f3...c0357c )

User::update() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like