UserCommand::execute() - Code Metrics - Inspection of "fix merge conflict" - delboy1978uk/user - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( f71fc9...354854 )

by Derek Stephen

created 2019-10-27 01:16 UTC

UserCommand::execute() A

↳ Parent: UserCommand

Complexity

Conditions	2
Paths	2

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	12
CRAP Score	2

Importance

Changes

Metric	Value
dl	0
loc	15
ccs	12
cts	12
cp	1
rs	9.7666
c	0
b	0
f	0
cc	2
nc	2
nop	2
crap	2

<?php

namespace Del\Console;

use DateTime;
use Del\Common\ContainerService;
use Del\Criteria\UserCriteria;
use Del\Service\UserService;
use Symfony\Component\Console\Command\Command;
use Symfony\Component\Console\Input\InputArgument;
use Symfony\Component\Console\Input\InputInterface;
use Symfony\Component\Console\Input\InputOption;
use Symfony\Component\Console\Output\OutputInterface;

class UserCommand extends Command
{
    /** @var UserService $userService */
    private $userService;

    /**
     * UserCommand constructor.
     * @throws \Doctrine\ORM\ORMException
     */
    public function __construct()
    {
        parent::__construct();
        $container = ContainerService::getInstance()->getContainer();
        $this->userService = $container[UserService::class];
    }

    /**
     *
     */
    protected function configure()
    {
        $this
            ->setName('reset-pass')
            ->setDescription('Resets a user\'s password')
            ->addArgument(
                'email',
                InputArgument::REQUIRED,
                'The email of the user'
            )->addArgument(
                'newPassword',
                InputArgument::REQUIRED,
                'The email of the user'
            )
        ;
    }

    /**
     * @param InputInterface $input
     * @param OutputInterface $output
     * @return int|void|null
     * @throws \Doctrine\ORM\OptimisticLockException
     */
    protected function execute(InputInterface $input, OutputInterface $output)
    {
        $email = $input->getArgument('email');
        $pass = $input->getArgument('newPassword');
        $criteria = new UserCriteria();
        $criteria->setEmail($email);
/**
 * @return array|string
 */
function returnsDifferentValues($x) {
    if ($x) {
        return 'foo';
    }

    return array();
}

$x = returnsDifferentValues($y);
if (is_array($x)) {
    // $x is an array.
}
        $user = $this->userService->findOneByCriteria($criteria);
        if ($user === null) {
            $output->writeln('No User Found.');
        } else {
            $this->userService->changePassword($user, $pass);
/**
 * @return array|string
 */
function returnsDifferentValues($x) {
    if ($x) {
        return 'foo';
    }

    return array();
}

$x = returnsDifferentValues($y);
if (is_array($x)) {
    // $x is an array.
}
            $this->userService->saveUser($user);
            $output->writeln('Password changed for '.$email);
        }
    }
}


1		<?php
2
3		namespace Del\Console;
4
5		use DateTime;
6		use Del\Common\ContainerService;
7		use Del\Criteria\UserCriteria;
8		use Del\Service\UserService;
9		use Symfony\Component\Console\Command\Command;
10		use Symfony\Component\Console\Input\InputArgument;
11		use Symfony\Component\Console\Input\InputInterface;
12		use Symfony\Component\Console\Input\InputOption;
13		use Symfony\Component\Console\Output\OutputInterface;
14
15		class UserCommand extends Command
16		{
17		/** @var UserService $userService */
18		private $userService;
19
20		/**
21		* UserCommand constructor.
22		* @throws \Doctrine\ORM\ORMException
23		*/
24	2	public function __construct()
25		{
26	2	parent::__construct();
27	2	$container = ContainerService::getInstance()->getContainer();
28	2	$this->userService = $container[UserService::class];
29	2	}
30
31		/**
32		*
33		*/
34	2	protected function configure()
35		{
36		$this
37	2	->setName('reset-pass')
38	2	->setDescription('Resets a user\'s password')
39	2	->addArgument(
40	2	'email',
41	2	InputArgument::REQUIRED,
42	2	'The email of the user'
43	2	)->addArgument(
44	2	'newPassword',
45	2	InputArgument::REQUIRED,
46	2	'The email of the user'
47		)
48		;
49	2	}
50
51		/**
52		* @param InputInterface $input
53		* @param OutputInterface $output
54		* @return int\|void\|null
55		* @throws \Doctrine\ORM\OptimisticLockException
56		*/
57	2	protected function execute(InputInterface $input, OutputInterface $output)
58		{
59	2	$email = $input->getArgument('email');
60	2	$pass = $input->getArgument('newPassword');
61	2	$criteria = new UserCriteria();
62	2	$criteria->setEmail($email);
		0 ignored issues – show Bug introduced 2019-09-14 19:48 UTC by Report Bug Copy Issue Report It seems like `$email` defined by `$input->getArgument('email')` on line `59` can also be of type `array<integer,string>` or `null`; however, `Del\Criteria\UserCriteria::setEmail()` does only seem to accept `string`, maybe add an additional type check? If a method or function can return multiple different values and unless you are sure that you only can receive a single value in this context, we recommend to add an additional type check: /** * @return array\|string */ function returnsDifferentValues($x) { if ($x) { return 'foo'; } return array(); } $x = returnsDifferentValues($y); if (is_array($x)) { // $x is an array. } If this a common case that PHP Analyzer should handle natively, please let us know by opening an issue. Loading history...
63	2	$user = $this->userService->findOneByCriteria($criteria);
64	2	if ($user === null) {
65	1	$output->writeln('No User Found.');
66		} else {
67	1	$this->userService->changePassword($user, $pass);
		0 ignored issues – show Bug introduced 2019-09-14 19:48 UTC by Report Bug Copy Issue Report It seems like `$pass` defined by `$input->getArgument('newPassword')` on line `60` can also be of type `array<integer,string>` or `null`; however, `Del\Service\UserService::changePassword()` does only seem to accept `string`, maybe add an additional type check? If a method or function can return multiple different values and unless you are sure that you only can receive a single value in this context, we recommend to add an additional type check: /** * @return array\|string */ function returnsDifferentValues($x) { if ($x) { return 'foo'; } return array(); } $x = returnsDifferentValues($y); if (is_array($x)) { // $x is an array. } If this a common case that PHP Analyzer should handle natively, please let us know by opening an issue. Loading history...
68	1	$this->userService->saveUser($user);
69	1	$output->writeln('Password changed for '.$email);
70		}
71	2	}
72		}
73

delboy1978uk / user

Push — master ( f71fc9...354854 )

UserCommand::execute() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like