UserCommand::execute() - Code Metrics - Inspection of "inject service into command" - delboy1978uk/user - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 354854...ac89c9 )

by Derek Stephen

created 2020-01-19 21:58 UTC

UserCommand::execute() A

↳ Parent: UserCommand

Complexity

Conditions	2
Paths	2

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	0
CRAP Score	6

Importance

Changes

Metric	Value
dl	0
loc	15
ccs	0
cts	12
cp	0
rs	9.7666
c	0
b	0
f	0
cc	2
nc	2
nop	2
crap	6

<?php

namespace Del\Console;

use DateTime;
use Del\Common\ContainerService;
use Del\Criteria\UserCriteria;
use Del\Service\UserService;
use Symfony\Component\Console\Command\Command;
use Symfony\Component\Console\Input\InputArgument;
use Symfony\Component\Console\Input\InputInterface;
use Symfony\Component\Console\Input\InputOption;
use Symfony\Component\Console\Output\OutputInterface;

class UserCommand extends Command
{
    /** @var UserService $userService */
    private $userService;

    /**
     * UserCommand constructor.
     * @throws \Doctrine\ORM\ORMException
     */
    public function __construct(UserService $userService)
    {
        parent::__construct();
        $this->userService = $userService;
    }

    /**
     *
     */
    protected function configure()
    {
        $this
            ->setName('reset-pass')
            ->setDescription('Resets a user\'s password')
            ->addArgument(
                'email',
                InputArgument::REQUIRED,
                'The email of the user'
            )->addArgument(
                'newPassword',
                InputArgument::REQUIRED,
                'The email of the user'
            )
        ;
    }

    /**
     * @param InputInterface $input
     * @param OutputInterface $output
     * @return int|void|null
     * @throws \Doctrine\ORM\OptimisticLockException
     */
    protected function execute(InputInterface $input, OutputInterface $output)
    {
        $email = $input->getArgument('email');
        $pass = $input->getArgument('newPassword');
        $criteria = new UserCriteria();
        $criteria->setEmail($email);
/**
 * @return array|string
 */
function returnsDifferentValues($x) {
    if ($x) {
        return 'foo';
    }

    return array();
}

$x = returnsDifferentValues($y);
if (is_array($x)) {
    // $x is an array.
}
        $user = $this->userService->findOneByCriteria($criteria);
        if ($user === null) {
            $output->writeln('No User Found.');
        } else {
            $this->userService->changePassword($user, $pass);
/**
 * @return array|string
 */
function returnsDifferentValues($x) {
    if ($x) {
        return 'foo';
    }

    return array();
}

$x = returnsDifferentValues($y);
if (is_array($x)) {
    // $x is an array.
}
            $this->userService->saveUser($user);
            $output->writeln('Password changed for '.$email);
        }
    }
}


1			<?php
2
3			namespace Del\Console;
4
5			use DateTime;
6			use Del\Common\ContainerService;
7			use Del\Criteria\UserCriteria;
8			use Del\Service\UserService;
9			use Symfony\Component\Console\Command\Command;
10			use Symfony\Component\Console\Input\InputArgument;
11			use Symfony\Component\Console\Input\InputInterface;
12			use Symfony\Component\Console\Input\InputOption;
13			use Symfony\Component\Console\Output\OutputInterface;
14
15			class UserCommand extends Command
16			{
17			/** @var UserService $userService */
18			private $userService;
19
20			/**
21			* UserCommand constructor.
22			* @throws \Doctrine\ORM\ORMException
23			*/
24			public function __construct(UserService $userService)
25			{
26			parent::__construct();
27			$this->userService = $userService;
28			}
29
30			/**
31			*
32			*/
33			protected function configure()
34			{
35			$this
36			->setName('reset-pass')
37			->setDescription('Resets a user\'s password')
38			->addArgument(
39			'email',
40			InputArgument::REQUIRED,
41			'The email of the user'
42			)->addArgument(
43			'newPassword',
44			InputArgument::REQUIRED,
45			'The email of the user'
46			)
47			;
48			}
49
50			/**
51			* @param InputInterface $input
52			* @param OutputInterface $output
53			* @return int\|void\|null
54			* @throws \Doctrine\ORM\OptimisticLockException
55			*/
56			protected function execute(InputInterface $input, OutputInterface $output)
57			{
58			$email = $input->getArgument('email');
59			$pass = $input->getArgument('newPassword');
60			$criteria = new UserCriteria();
61			$criteria->setEmail($email);
			0 ignored issues – show Bug introduced 2019-09-14 19:48 UTC by Report Bug Copy Issue Report It seems like `$email` defined by `$input->getArgument('email')` on line `58` can also be of type `array<integer,string>` or `null`; however, `Del\Criteria\UserCriteria::setEmail()` does only seem to accept `string`, maybe add an additional type check? If a method or function can return multiple different values and unless you are sure that you only can receive a single value in this context, we recommend to add an additional type check: /** * @return array\|string */ function returnsDifferentValues($x) { if ($x) { return 'foo'; } return array(); } $x = returnsDifferentValues($y); if (is_array($x)) { // $x is an array. } If this a common case that PHP Analyzer should handle natively, please let us know by opening an issue. Loading history...
62			$user = $this->userService->findOneByCriteria($criteria);
63			if ($user === null) {
64			$output->writeln('No User Found.');
65			} else {
66			$this->userService->changePassword($user, $pass);
			0 ignored issues – show Bug introduced 2019-09-14 19:48 UTC by Report Bug Copy Issue Report It seems like `$pass` defined by `$input->getArgument('newPassword')` on line `59` can also be of type `array<integer,string>` or `null`; however, `Del\Service\UserService::changePassword()` does only seem to accept `string`, maybe add an additional type check? If a method or function can return multiple different values and unless you are sure that you only can receive a single value in this context, we recommend to add an additional type check: /** * @return array\|string */ function returnsDifferentValues($x) { if ($x) { return 'foo'; } return array(); } $x = returnsDifferentValues($y); if (is_array($x)) { // $x is an array. } If this a common case that PHP Analyzer should handle natively, please let us know by opening an issue. Loading history...
67			$this->userService->saveUser($user);
68			$output->writeln('Password changed for '.$email);
69			}
70			}
71			}
72

delboy1978uk / user

Push — master ( 354854...ac89c9 )

UserCommand::execute() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like