Del\Collection\User

Complexity

Total Complexity

10

Size/Duplication

Total Lines	65
Duplicated Lines	0 %

Test Coverage

Coverage

100%

Importance

Changes	1
Bugs	0	Features	0

5 Methods

Rating	Name	Duplication	Size	Complexity
A	update()	0	10	2
A	findById()	0	12	3
A	append()	0	3	1
A	findKey()	0	11	3
A	current()	0	3	1

<?php

namespace Del\Collection;

use Del\Entity\User as UserEntity;
use Doctrine\Common\Collections\ArrayCollection;
use LogicException;

class User extends ArrayCollection
{
    /**
     * @param UserEntity $user
     * @return $this
     */
    public function update(UserEntity $user)
    {
        $key = $this->findKey($user);
        if($key) {

            $this->offsetSet($key,$user);

$key of type integer|true is incompatible with the type Doctrine\Common\Collections\TKey|null expected by parameter $offset of Doctrine\Common\Collections\ArrayCollection::offsetSet().

            return $this;

        }
        throw new LogicException('User was not in the collection.');
    }

    /**
     * @param UserEntity $user
     */
    public function append(UserEntity $user)
    {
        $this->add($user);
    }

    /**
     * @return UserEntity|null
     */
    public function current()
    {
        return parent::current();
    }

    /**
     * @param UserEntity $user
     * @return bool|int
     */
    public function findKey(UserEntity $user)
    {
        $it = $this->getIterator();
        $it->rewind();
        while($it->valid()) {
            if($it->current()->getId() == $user->getId()) {
                return $it->key();

The expression return $it->key() also could return the type string which is incompatible with the documented return type boolean|integer.

            }
            $it->next();
        }
        return false;
    }



    public function findById($id)
    {
        $it = $this->getIterator();
        $it->rewind();
        while($it->valid()) {
            if($it->current()->getId() == $id) {
                return $it->current();
            }
            $it->next();
        }

        return false;
    }

}