Del\Person\Collection\PersonCollection

Complexity

Total Complexity

10

Size/Duplication

Total Lines	56
Duplicated Lines	0 %

Test Coverage

Coverage

100%

Importance

Changes	1
Bugs	0	Features	0

5 Methods

Rating	Name	Duplication	Size	Complexity
A	current()	0	3	1
A	update()	0	11	2
A	findKey()	0	14	3
A	findById()	0	14	3
A	append()	0	3	1

<?php

declare(strict_types=1);

namespace Del\Person\Collection;

use Del\Person\Entity\Person as PersonEntity;
use Doctrine\Common\Collections\ArrayCollection;
use LogicException;

class PersonCollection extends ArrayCollection
{

    public function update(PersonEntity $person): void
    {
        $key = $this->findKey($person);

        if($key) {
            $this->offsetSet($key,$person);

$key of type integer|true is incompatible with the type Doctrine\Common\Collections\TKey|null expected by parameter $offset of Doctrine\Common\Collections\ArrayCollection::offsetSet().

            return;
        }

        throw new LogicException('Person was not in the collection.');
    }

    public function append(PersonEntity $person)
    {
        $this->add($person);
    }

    public function current(): ?PersonEntity
    {
        return parent::current();
    }

    public function findKey(PersonEntity $person): int|bool
    {
        $it = $this->getIterator();
        $it->rewind();

        while($it->valid()) {
            if($it->current()->getId() == $person->getId()) {
                return $it->key();

The expression return $it->key() could return the type double|null|string which is incompatible with the type-hinted return boolean|integer. Consider adding an additional type-check to rule them out.

            }

            $it->next();
        }

        return false;
    }

    public function findById($id): PersonEntity|bool
    {
        $it = $this->getIterator();
        $it->rewind();

        while($it->valid()) {
            if($it->current()->getId() == $id) {
                return $it->current();
            }

            $it->next();
        }

        return false;
    }
}