Del\Person\Service\PersonService

Complexity

Total Complexity

17

Size/Duplication

Total Lines	96
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	2

Test Coverage

Coverage

77.78%

Importance

Changes

0

8 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	4	1
C	createFromArray()	0	14	9
A	toArray()	0	14	1
A	savePerson()	0	4	1
A	getRepository()	0	4	1
A	deletePerson()	0	4	1
A	findByCriteria()	0	4	1
A	findOneByCriteria()	0	5	2

<?php

namespace Del\Person\Service;

use Del\Person\Criteria\PersonCriteria;
use Del\Person\Entity\Person;
use Del\Person\Repository\PersonRepository;
use Doctrine\ORM\EntityManager;
use Barnacle\Container;

class PersonService
{
    /** @var EntityManager $em */
    protected $em;

    /**
     * PersonService constructor.
     * @param EntityManager $entityManager
     */
    public function __construct(EntityManager $entityManager)

You have injected the EntityManager via parameter $entityManager. This is generally not recommended as it might get closed and become unusable. Instead, it is recommended to inject the ManagerRegistry and retrieve the EntityManager via getManager() each time you need it.

    {
        $this->em = $entityManager;
    }

   /** 
    * @param array $data
    * @return Person
    */
    public function createFromArray(array $data): Person
    {
        $person = new Person();
        isset($data['id']) ? $person->setId($data['id']) : null;
        isset($data['firstname']) ? $person->setFirstname($data['firstname']) : null;
        isset($data['middlename']) ? $person->setMiddlename($data['middlename']) : null;
        isset($data['lastname']) ? $person->setLastname($data['lastname']) : null;
        isset($data['aka']) ? $person->setAka($data['aka']) : null;
        isset($data['dob']) ? $person->setDob($data['dob']) : null;
        isset($data['birthplace']) ? $person->setBirthplace($data['birthplace']) : null;
        isset($data['country']) ? $person->setCountry($data['country']) : null;

        return $person;
    }

    /**
     * @param Person $person
     * @return array
     */
    public function toArray(Person $person): array
    {
        $data = [
            'id' => $person->getId(),
            'firstname' => $person->getFirstname(),
            'middlename' => $person->getMiddlename(),
            'lastname' => $person->getLastname(),
            'aka' => $person->getAka(),
            'dob' => $person->getDob(),
            'birthplace' => $person->getBirthplace(),
            'country' => $person->getCountry(),
        ];
        return $data;
    }

    /**
     * @param Person $person
     * @return Person
     */
    public function savePerson(Person $person): Person
    {
        return $this->getRepository()->save($person);
    }

    /**
     * @param Person $person
     */
    public function deletePerson(Person $person): void
    {
        $this->getRepository()->delete($person);
    }

    /**
     * @param PersonCriteria $criteria
     * @return Person[]
     */
    public function findByCriteria(PersonCriteria $criteria)
    {
        return $this->getRepository()->findByCriteria($criteria);

The method findByCriteria() does not exist on Doctrine\Common\Persistence\ObjectRepository. Did you maybe mean findBy()?

    }

    /**
     * @param PersonCriteria $criteria
     * @return Person|null
     */
    public function findOneByCriteria(PersonCriteria $criteria)
    {
        $results = $this->findByCriteria($criteria);
        return (isset($results[0])) ? $results[0] : null;
    }

    /**
     * @return \Doctrine\Common\Persistence\ObjectRepository|\Doctrine\ORM\EntityRepository
     */
    protected function getRepository()
    {
        return $this->em->getRepository(Person::class);
    }
}