Del\Service\Person

Complexity

Total Complexity

15

Size/Duplication

Total Lines	82
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	3

Test Coverage

Coverage

93.94%

Importance

Changes	7
Bugs	0	Features	0

7 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	4	1
C	createFromArray()	0	13	9
A	toArray()	0	14	1
A	savePerson()	0	4	1
A	deletePerson()	0	4	1
A	findByCriteria()	0	4	1
A	getRepository()	0	4	1

<?php

namespace Del\Service;

use Del\Criteria\PersonCriteria;
use Del\Entity\Person as PersonEntity;
use Del\Repository\Person as PersonRepository;
use Doctrine\ORM\EntityManager;
use Pimple\Container;

class Person
{
    /** @var EntityManager $em */
    protected $em;

    public function __construct(EntityManager $em)

You have injected the EntityManager via parameter $em. This is generally not recommended as it might get closed and become unusable. Instead, it is recommended to inject the ManagerRegistry and retrieve the EntityManager via getManager() each time you need it.

    {
        $this->em = $em;
    }

   /** 
    * @param array $data
    * @return PersonEntity
    */
    public function createFromArray(array $data)
    {
        $person = new PersonEntity();
        isset($data['id']) ? $person->setId($data['id']) : null;
        isset($data['firstname']) ? $person->setFirstname($data['firstname']) : null;
        isset($data['middlename']) ? $person->setMiddlename($data['middlename']) : null;
        isset($data['lastname']) ? $person->setLastname($data['lastname']) : null;
        isset($data['aka']) ? $person->setAka($data['aka']) : null;
        isset($data['dob']) ? $person->setDob($data['dob']) : null;
        isset($data['birthplace']) ? $person->setBirthplace($data['birthplace']) : null;
        isset($data['country']) ? $person->setCountry($data['country']) : null;
        return $person;
    }

    /**
     * @param array $person
     * @return PersonEntity
     */
    public function toArray(PersonEntity $person)
    {
        $data = [
            'id' => $person->getId(),
            'firstname' => $person->getFirstname(),
            'middlename' => $person->getMiddlename(),
            'lastname' => $person->getLastname(),
            'aka' => $person->getAka(),
            'dob' => $person->getDob(),
            'birthplace' => $person->getBirthplace(),
            'country' => $person->getCountry(),
        ];
        return $data;
    }

    /**
     * @param PersonEntity $person
     * @return PersonEntity
     */
    public function savePerson(PersonEntity $person)
    {
        return $this->getRepository()->save($person);
    }

    /**
     * @param PersonEntity $person
     * @return PersonEntity
     */
    public function deletePerson(PersonEntity $person)
    {
        return $this->getRepository()->delete($person);
    }

    /**
     * @param PersonCriteria $criteria
     * @return array
     */
    public function findByCriteria(PersonCriteria $criteria)
    {
        return $this->getRepository()->findByCriteria($criteria);
    }

   /**
    * @return PersonRepository
    */
    protected function getRepository()
    {
        return $this->em->getRepository('Del\Entity\Person');
    }
}