Del\Passport\PassportControl

Complexity

Total Complexity

12

Size/Duplication

Total Lines	120
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	4

Test Coverage

Coverage

0%

Importance

Changes

0

9 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	4	1
A	isAuthorized()	0	4	1
A	grantEntitlement()	0	13	3
A	revokeEntitlement()	0	4	1
A	createNewRole()	0	7	1
A	removeRole()	0	5	1
A	findRole()	0	6	1
A	findPassportRole()	0	13	2
A	findUserPassport()	0	8	1

<?php

namespace Del\Passport;

use Del\Passport\Passport;
use Del\Passport\Entity\PassportRole;
use Del\Passport\Entity\Role;
use Doctrine\Common\Collections\Collection;
use Doctrine\ORM\EntityManager;

class PassportControl
{
    /** @var EntityManager */
    private $entityManager;

    /**
     * PassportControl constructor.
     * @param EntityManager $entityManager
     */
    public function __construct(EntityManager $entityManager)
    {
        $this->entityManager = $entityManager;
    }

    /**
     * @param PassportInterface $passport
     * @param ResourceInterface $resource
     * @return bool
     */
    public function isAuthorized(PassportInterface $passport, ResourceInterface $resource): bool

The parameter $passport is not used and could be removed.

The parameter $resource is not used and could be removed.

    {
        return true;
    }

    /**
     * @param PassportInterface $passport
     * @param RoleInterface $role
     * @param ResourceInterface $resource
     * @return bool
     */
    public function grantEntitlement(PassportInterface $passport, RoleInterface $role, ResourceInterface $resource = null): bool
    {
        $userId = $passport->getUserId();
        $resource ? $resourceId = $resource->getResourceId() : null;
        $entitlement = new PassportRole();
        $entitlement->setUserId($userId);
        $entitlement->setRole($role);

$role of type object<Del\Passport\RoleInterface> is not a sub-type of object<Del\Passport\Entity\Role>. It seems like you assume a concrete implementation of the interface Del\Passport\RoleInterface to be always present.

        $resourceId ? $entitlement->setEntityId($resourceId) : null;

The variable $resourceId does not seem to be defined for all execution paths leading up to this point.

        $this->entityManager->persist($entitlement);
        $this->entityManager->flush($entitlement);

        return true;
    }

    /**
     * @param PassportInterface $passport
     * @param RoleInterface $role
     * @param ResourceInterface $resource
     * @return bool
     */
    public function revokeEntitlement(PassportInterface $passport, RoleInterface $role, ResourceInterface $resource): bool

The parameter $passport is not used and could be removed.

The parameter $role is not used and could be removed.

The parameter $resource is not used and could be removed.

    {
        return true;
    }

    /**
     * @param int $userId

There is no parameter named $userId. Was it maybe removed?

     * @return PassportInterface
     */
    public function createNewRole(RoleInterface $role): RoleInterface
    {
        $this->entityManager->persist($role);
        $this->entityManager->flush($role);

        return $role;
    }

    /**
     * @param int $userId

There is no parameter named $userId. Was it maybe removed?

     * @return PassportInterface
     */
    public function removeRole(RoleInterface $role): void
    {
        $this->entityManager->remove($role);
        $this->entityManager->flush($role);
    }

    /**
     * @param string $name
     * @return Role|null
     */
    public function findRole(string $name): ?Role
    {
        return $this->entityManager->getRepository(Role::class)->findOneBy([
            'roleName' => $name,
        ]);
    }

    /**
     * @param string $name
     * @param int $id
     * @return PassportRole|null
     */
    public function findPassportRole(string $name, int $id, int $entityId = null): ?PassportRole
    {
        $criteria = [
            'role' => $name,
            'userId' => $id,
        ];

        if ($entityId) {

The expression $entityId of type null|integer is loosely compared to true; this is ambiguous if the integer can be zero. You might want to explicitly use !== null instead.

            $criteria['entityId'] = $entityId;
        }

        return $this->entityManager->getRepository(PassportRole::class)->findOneBy($criteria);
    }

    /**
     * @param int $id
     * @return Passport
     */
    public function findUserPassport(int $id): Passport
    {
        $roles = $this->entityManager->getRepository(PassportRole::class)->findBy([
            'userId' => $id,
        ]);

        return new Passport($id, $roles);
    }
}