App\Controller\UserController

Complexity

Total Complexity

34

Size/Duplication

Total Lines	383
Duplicated Lines	0 %

Test Coverage

Coverage

29.8%

Importance

Changes

0

7 Methods

Rating	Name	Duplication	Size	Complexity
A	lostPasswordAction()	0	19	4
A	indexAction()	0	16	3
B	resetPassAction()	0	47	9
B	activateAction()	0	48	6
A	init()	0	4	1
A	resendActivationAction()	0	19	4
B	registerAction()	0	51	7

<?php

namespace App\Controller;

use App\Form\User\RegistrationForm;
use App\Form\User\ResetPasswordForm;
use Bone\Mvc\Registry;
use Bone\Service\MailService;
use Del\Common\ContainerService;
use Del\Exception\EmailLinkException;
use Del\Exception\UserException;
use Del\Service\UserService;
use Del\Value\User\State;
use Exception;
use Zend\Validator\EmailAddress;

class UserController extends BaseController
{
    /** @var UserService */
    private $userService;

    public function init()
    {
        $c = ContainerService::getInstance()->getContainer();
        $this->userService = $c['service.user'];
    }

    /**
     * Fetch user details by ID.
     *
     * @SWG\Get(
     *     path="/user/{id}",
     *     tags={"users"},
     *     @SWG\Parameter(
     *         name="id",
     *         in="path",
     *         type="integer",
     *         description="the type of response",
     *         required=false,
     *         default=1
     *     ),
     *     @SWG\Response(response="200", description="Sends user details")
     * )
     *
     */
    public function indexAction()
    {
        if (!$this->httpMethodCheck('GET')) { return; }

        $id = $this->getParam('id');

        /** @var UserService $userSvc */
        $userSvc = ContainerService::getInstance()->getContainer()['service.user'];

        $user = $userSvc->findUserById($id);

It seems like $id can also be of type string; however, parameter $id of Del\Service\UserService::findUserById() does only seem to accept integer, maybe add an additional type check?

        if (!$user) {
            $this->sendJsonResponse(['error' => 'User not found'], 404);
            return;
        }

        $this->sendJsonObjectResponse($user);
    }



    /**
     * Activate from the email link token.
     *
     * @SWG\Get(
     *     path="/user/activate/{email}/{token}",
     *     tags={"users"},
     *     @SWG\Response(response="200", description="Registers a new unactivated user"),
     *     @SWG\Parameter(
     *         name="email",
     *         in="path",
     *         type="string",
     *         description="the users email",
     *         required=true,
     *         default="someone@email.com"
     *     ),
     *     @SWG\Parameter(
     *         name="token",
     *         in="path",
     *         type="string",
     *         description="the email link token",
     *         required=true,
     *         default="r4nd0mT0k3n"
     *     )
     * )
     * @throws Exception
     */
    public function activateAction()
    {
        if (!$this->httpMethodCheck('GET')) { return; }

        $email = $this->getParam('email');
        $token = $this->getParam('token');

        $userService = $this->userService;

        try {

            $link = $userService->findEmailLink($email, $token);

            $user = $link->getUser();
            $user->setState(new State(State::STATE_ACTIVATED));
            $userService->saveUser($user);
            $userService->deleteEmailLink($link);
            $data = ['success' => true];
            $code = 200;

        } catch (EmailLinkException $e) {
            switch ($e->getMessage()) {
                case EmailLinkException::LINK_EXPIRED:
                case EmailLinkException::LINK_NO_MATCH:
                    $data = [
                        'success' => false,
                        'error' => $e->getMessage(),
                    ];
                    $code = 403;
                    break;
                case EmailLinkException::LINK_NOT_FOUND:
                    $data = [
                        'success' => false,
                        'error' => $e->getMessage(),
                    ];
                    $code = 404;
                    break;
                default:
                    $data = [
                        'success' => false,
                        'error' => $e->getMessage(),
                    ];
                    $code = 500;
                    break;
            }
        }

        $this->sendJsonResponse($data, $code);
    }


    /**
     * Refresh the activation email link token.
     *
     * @SWG\Get(
     *     path="/user/activate/resend/{email}",
     *     tags={"users"},
     *     @SWG\Parameter(
     *         name="email",
     *         in="path",
     *         type="string",
     *         description="the email of the user registering",
     *         required=true,
     *         default="someone@email.com"
     *     ),
     *     @SWG\Response(response="200", description="Sends email link details")
     * )
     * @throws Exception
     */
    public function resendActivationAction()
    {
        if (!$this->httpMethodCheck('GET')) { return; }

        $email = $this->getParam('email');

        $user = $this->userService->findUserByEmail($email);
        if (!$user) {
            $this->sendJsonResponse(['error' => UserException::USER_NOT_FOUND], 404);
            return;
        }

        if ($user->getState()->getValue() == State::STATE_ACTIVATED) {
            $this->sendJsonResponse(['error' => UserException::USER_ACTIVATED], 400);
            return;
        }

        $link = $this->userService->generateEmailLink($user);
        $this->sendJsonObjectResponse($link);
    }

    /**
     * Get a lost password email link token.
     *
     * @SWG\Get(
     *     path="/user/lost-password/{email}",
     *     tags={"users"},
     *     @SWG\Parameter(
     *         name="email",
     *         in="path",
     *         type="string",
     *         description="the email of the user",
     *         required=true,
     *         default="someone@email.com"
     *     ),
     *     @SWG\Response(response="200", description="Sends email link details")
     * )
     * @throws Exception
     */
    public function lostPasswordAction()
    {
        if (!$this->httpMethodCheck('GET')) { return; }

        $email = $this->getParam('email');

        $user = $this->userService->findUserByEmail($email);
        if (!$user) {
            $this->sendJsonResponse(['error' => UserException::USER_NOT_FOUND], 404);
            return;
        }

        if ($user->getState()->getValue() == State::STATE_UNACTIVATED) {
            $this->sendJsonResponse(['error' => UserException::USER_UNACTIVATED], 400);
            return;
        }

        $link = $this->userService->generateEmailLink($user);
        $this->sendJsonObjectResponse($link);
    }

    /**
     * Register as a new user. Returns an email link token.
     *
     * @SWG\Post(
     *     path="/user/register",
     *     tags={"users"},
     *     @SWG\Response(response="200", description="Registers a new unactivated user"),
     *     @SWG\Parameter(
     *         name="email",
     *         in="formData",
     *         type="string",
     *         description="the users email",
     *         required=true,
     *         default="someone@email.com"
     *     ),
     *     @SWG\Parameter(
     *         name="password",
     *         in="formData",
     *         type="string",
     *         description="a password for the user",
     *         required=true,
     *         default="password"
     *     ),
     *     @SWG\Parameter(
     *         name="confirm",
     *         in="formData",
     *         type="string",
     *         description="password confirmation",
     *         required=true,
     *         default="password"
     *     )
     * )
     * @throws Exception
     */
    public function registerAction()
    {
        if (!$this->httpMethodCheck('POST')) { return; }
phpinfo(); exit;

Using exit here is not recommended.

        $form = new RegistrationForm('register');

$form = new App\Form\User\RegistrationForm('register') is not reachable.

        if ($this->getRequest()->getMethod() == 'POST') {

            $formData = $this->getRequest()->getParsedBody();
            $form->populate($formData);

            if ($form->isValid()) {
                try {
                    $data = $form->getValues();
                    $user = $this->userService->registerUser($data);
                    $link = $this->userService->generateEmailLink($user);
                    $mail = $this->getMailService();
                    $env = $this->getServerEnvironment();
                    $siteURL = $env->getRequestScheme() . '://' . $env->getHttpHost();
                    $email = $user->getEmail();
                    $token = $link->getToken();

                    $message =
                        <<<END
                        Thank you for registering with $siteURL. You must now activate your account by clicking on the link below.<br /&nbsp;<br />
<a href="$siteURL/user/activate/$email/$token">Activate my Account</a>.
END;

                    $mail->setFrom('noreply@' . $env->getHttpHost())
                        ->setTo($user->getEmail())
                        ->setSubject('Thank you for registering with ' . Registry::ahoy()->get('site')['name'])
                        ->setHeader('MAIL HEADER')
//                        ->setHeader(Template::getHeader())
                        ->setFooter('MAIL FOOTER')
//                        ->setFooter(Template::getFooter())
                        ->setMessage($message)
                        ->send();
                    $this->sendJsonObjectResponse($link);

                } catch (UserException $e) {

                    switch ($e->getMessage()) {
                        case UserException::USER_EXISTS:
                        case UserException::WRONG_PASSWORD:
                            throw new Exception($e->getMessage(), 400);
                            break;
                    }
                    throw $e;
                }
            } else {
                throw new Exception('Invalid request data;', 400);
            }

        }
    }

    /**
     * Resets the users password. Requires an email link token.
     *
     * @SWG\Post(
     *     path="/user/reset-password/{email}/{token}",
     *     tags={"users"},
     *     @SWG\Response(response="200", description="Resets a users email"),
     *     @SWG\Parameter(
     *         name="email",
     *         in="path",
     *         type="string",
     *         description="the email of the user",
     *         required=true,
     *         default="someone@email.com"
     *     ),
     *     @SWG\Parameter(
     *         name="token",
     *         in="path",
     *         type="string",
     *         description="the email link token",
     *         required=true,
     *         default="r4nd0mT0k3n"
     *     ),
     *     @SWG\Parameter(
     *         name="password",
     *         in="formData",
     *         type="string",
     *         description="a password for the user",
     *         required=true,
     *         default="password"
     *     ),
     *     @SWG\Parameter(
     *         name="confirm",
     *         in="formData",
     *         type="string",
     *         description="password confirmation",
     *         required=true,
     *         default="password"
     *     )
     * )
     * @throws Exception
     */
    public function resetPassAction()
    {
        if (!$this->httpMethodCheck('POST')) { return; }

        $email = $this->getParam('email');
        $token = $this->getParam('token');

        $user = $this->userService->findUserByEmail($email);
        if (!$user) {
            $this->sendJsonResponse(['error' => UserException::USER_NOT_FOUND], 404);
            return;
        }

        try {
            $link = $this->userService->findEmailLink($email, $token);
        } catch (EmailLinkException $e) {
            $code = $e->getMessage() == EmailLinkException::LINK_EXPIRED ? 400 : 404;
            $this->sendJsonResponse(['error' => $e->getMessage(), $code]);
            return;
        }

        $form = new ResetPasswordForm('reset-pass');

        $data = $this->getRequest()->getParsedBody();

        $form->populate($data);

It seems like $data can also be of type null and object; however, parameter $data of Del\Form\AbstractForm::populate() does only seem to accept array, maybe add an additional type check?

        if ($form->isValid()) {

            if ($data['password'] == $data['confirm']) {
                $this->userService->changePassword($user, $data['password']);
                $this->userService->deleteEmailLink($link);
                $this->sendJsonResponse(['success' => 'Password successfully changed']);
                return;
            } else {
                $this->sendJsonResponse(['error' => 'Passwords did not match, please try again.'], 400);
            }
        } else {
            $errors = [];
            $fields = $form->getFields();
            foreach ($fields as $field) {
                $validators = $field->getValidators();
                foreach ($validators as $validator) {
                    $errors[$field->getName()] = $validator->getMessages();
                }
            }
            $this->sendJsonResponse(['error' => $errors], 400);
        }
    }
}