OAuth\Repository\ClientRepository

Complexity

Total Complexity

8

Size/Duplication

Total Lines	65
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	3

Test Coverage

Coverage

0%

Importance

Changes	2
Bugs	0	Features	0

4 Methods

Rating	Name	Duplication	Size	Complexity
B	getClientEntity()	0	21	5
A	create()	0	6	1
A	save()	0	5	1
A	delete()	0	5	1

<?php

namespace OAuth\Repository;

use OAuth\Client;
use Doctrine\ORM\EntityRepository;
use League\OAuth2\Server\Entities\ClientEntityInterface;
use League\OAuth2\Server\Repositories\ClientRepositoryInterface;

class ClientRepository extends EntityRepository implements ClientRepositoryInterface
{
    /**
     * @param string $clientIdentifier
     * @param string $grantType
     * @param null|string|null $clientSecret
     * @param bool $mustValidateSecret
     *
     * @return ClientEntityInterface|null
     */
    public function getClientEntity($clientIdentifier, $grantType, $clientSecret = null, $mustValidateSecret = true)
    {
        /** @var Client $client */
        $client = $this->findOneBy([
            'identifier' => $clientIdentifier
        ]);

        if ($client instanceof Client == false) {

It seems like you are loosely comparing two booleans. Considering using the strict comparison === instead.

            return null;
        }

        if (
            $mustValidateSecret === true
            && $client['is_confidential'] === true
            && $clientSecret != $client->getSecret()
        ) {
            return null;
        }

        return $client;
    }

    /**
     * @param Client $client
     * @return Client
     * @throws \Doctrine\ORM\OptimisticLockException
     */
    public function create(Client $client)
    {
        $this->_em->persist($client);
        $this->_em->flush($client);
        return $client;
    }

    /**
     * @param Client $client
     * @return Client
     * @throws \Doctrine\ORM\OptimisticLockException
     */
    public function save(Client $client)
    {
        $this->_em->flush($client);
        return $client;
    }

    /**
     * @param Client $client
     * @throws \Doctrine\ORM\OptimisticLockException
     */
    public function delete(Client $client)
    {
        $this->_em->remove($client);
        $this->_em->flush($client);
    }
}