OAuth\Command\ClientScopeCommand

Complexity

Total Complexity

11

Size/Duplication

Total Lines	98
Duplicated Lines	0 %

Test Coverage

Coverage

0%

Importance

Changes

0

7 Methods

Rating	Name	Duplication	Size	Complexity
A	removeScope()	0	3	1
A	getArgOrGetUpset()	0	5	2
A	configure()	0	4	1
A	execute()	0	14	4
A	addScope()	0	5	1
A	listScopes()	0	3	1
A	__construct()	0	8	1

<?php

namespace OAuth\Command;

use Exception;
use OAuth\Client;
use OAuth\Repository\ScopeRepository;
use OAuth\Scope;
use OAuth\Service\ClientService;
use Symfony\Component\Console\Command\Command;
use Symfony\Component\Console\Helper\QuestionHelper;
use Symfony\Component\Console\Input\InputArgument;
use Symfony\Component\Console\Input\InputInterface;
use Symfony\Component\Console\Output\OutputInterface;
use Symfony\Component\Console\Question\ChoiceQuestion;
use Symfony\Component\Console\Question\ConfirmationQuestion;
use Symfony\Component\Console\Question\Question;

/**
 * Class ClientCommand
 * @package OAuth\Command
 */
class ClientScopeCommand extends Command
{
    /**
     * @var ClientService $clientService
     */
    private $clientService;

    /**
     * @var ScopeRepository $scopeRepository
     */
    private $scopeRepository;

    /** @var QuestionHelper $helper */
    private $helper;

The private property $helper is not used, and could be removed.

    public function __construct(ClientService $clientService, ScopeRepository $scopeRepository)
    {
        $this->clientService = $clientService;
        $this->scopeRepository = $scopeRepository;
        parent::__construct('client:scope');
        $this->addArgument('operation', InputArgument::REQUIRED, 'list, add, or remove.');
        $this->addArgument('client', InputArgument::OPTIONAL, 'The client identifier.');
        $this->addArgument('scope', InputArgument::OPTIONAL, 'The scope name when adding or removing.');
    }

    /**
     * configure options
     */
    protected function configure()
    {
        $this->setDescription('Add, remove, or list scopes for each client.');
        $this->setHelp('Client scope administration');
    }

    /**
     * @param InputInterface $input
     * @param OutputInterface $output
     * @return int|void|null
     * @throws Exception
     */
    protected function execute(InputInterface $input, OutputInterface $output)
    {
        $output->writeln('Client scope administration');
        $operation = $input->getArgument('operation');
        switch ($operation) {
            case 'list';
                $this->listScopes($input, $output);
                break;
            case 'add';
                $this->addScope($input, $output);
                break;
            case 'remove';
                $this->removeScope($input, $output);
                break;
        }
    }

    /**
     * @param string $argName
     * @param string $value
     * @throws Exception
     */
    private function getArgOrGetUpset(InputInterface $input, string $argName)
    {
        $value = $input->getArgument($argName);
        if (!$value) {
            throw new Exception('No ' . $argName . ' provided');
        }
    }

    /**
     * @param InputInterface $input
     * @param OutputInterface $output
     */
    private function listScopes(InputInterface $input, OutputInterface $output)

The parameter $input is not used and could be removed.

    {
        $output->writeln('List scopes for client');
    }

    /**
     * @param InputInterface $input
     * @param OutputInterface $output
     * @throws Exception
     */
    private function addScope(InputInterface $input, OutputInterface $output)
    {
        $client = $this->getArgOrGetUpset($input, 'client');

Are you sure the assignment to $client is correct as $this->getArgOrGetUpset($input, 'client') targeting OAuth\Command\ClientScopeCommand::getArgOrGetUpset() seems to always return null.

        $scope = $this->getArgOrGetUpset($input, 'scope');

Are you sure the assignment to $scope is correct as $this->getArgOrGetUpset($input, 'scope') targeting OAuth\Command\ClientScopeCommand::getArgOrGetUpset() seems to always return null.

        $output->writeln('Scope '. $scope . ', client ' . $client);
    }

    /**
     * @param InputInterface $input
     * @param OutputInterface $output
     */
    private function removeScope(InputInterface $input, OutputInterface $output)

The parameter $input is not used and could be removed.

    {
        $output->writeln('Remove scope for client');
    }
}