OAuth\Repository\AuthCodeRepository

Complexity

Total Complexity

4

Size/Duplication

Total Lines	55
Duplicated Lines	21.82 %

Coupling/Cohesion

Components	1
Dependencies	3

Test Coverage

Coverage

0%

Importance

Changes	1
Bugs	0	Features	0

3 Methods

Rating	Name	Duplication	Size	Complexity
A	getAuthorizationCode()	12	12	2
A	setAuthorizationCode()	0	17	1
A	expireAuthorizationCode()	0	6	1

<?php

namespace OAuth\Repository;

use DateTime;
use Doctrine\ORM\EntityRepository;
use OAuth\AuthCode;

class AuthCodeRepository extends EntityRepository
{
    /**
     * @param $code
     * @return null|array
     */
    public function getAuthorizationCode($code)

This method seems to be duplicated in your project.

    {
        $authCode = $this->findOneBy(['code' => $code]);
        if ($authCode) {
            $authCode = $authCode->toArray();
            /** @var DateTime $date */
            $date = $authCode['expires'];
            $authCode['expires'] = $date->getTimestamp();
            return $authCode;
        }
        return null;
    }

    /**
     * @param $code
     * @param $clientIdentifier
     * @param $userEmail
     * @param $redirectUri
     * @param $expires
     * @param null $scope
     */
    public function setAuthorizationCode($code, $clientIdentifier, $userEmail, $redirectUri, $expires, $scope = null)
    {
        $client = $this->_em->getRepository('YourNamespace\Entity\OAuthClient')->findOneBy(array('client_identifier' => $clientIdentifier));
        $user = $this->_em->getRepository('YourNamespace\Entity\OAuthUser')->findOneBy(['email' => $userEmail]);
        $date = new DateTime();
        $date->setTimestamp($expires);
        $authCode = AuthCode::fromArray([
            'code'           => $code,
            'client'         => $client,
            'user'           => $user,
            'redirect_uri'   => $redirectUri,
            'expires'        => $date,
            'scope'          => $scope,
        ]);
        $this->_em->persist($authCode);
        $this->_em->flush();
    }

    /**
     * @param $code
     */
    public function expireAuthorizationCode($code)
    {
        $authCode = $this->findOneBy(['code' => $code]);
        $this->_em->remove($authCode);

It seems like $authCode defined by $this->findOneBy(array('code' => $code)) on line 59 can also be of type null; however, Doctrine\ORM\EntityManager::remove() does only seem to accept object, maybe add an additional type check?

        $this->_em->flush();
    }
}