BaseController::sendJsonObjectResponse() - Code Metrics - Inspection of "refactor user api test" - delboy1978uk/oauth2-api - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 24cbbe...c65133 )

by Derek Stephen

created 2018-11-09 12:40 UTC

BaseController::sendJsonObjectResponse() A

↳ Parent: BaseController

Complexity

Conditions	2
Paths	2

Size

Total Lines	13
Code Lines	10

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	10
CRAP Score	2.003

Importance

Changes

Metric	Value
eloc	10
dl	0
loc	13
ccs	10
cts	11
cp	0.9091
rs	9.9332
c	0
b	0
f	0
cc	2
nc	2
nop	2
crap	2.003

<?php

namespace App\Controller;

use Bone\Mvc\Controller;
use InvalidArgumentException;
use JMS\Serializer\Serializer;
use JMS\Serializer\SerializerBuilder;
use Psr\Http\Message\ServerRequestInterface;

class BaseController extends Controller
{
    /** @var Serializer */
    protected $serializer;

    public function __construct(ServerRequestInterface $request)
    {
        parent::__construct($request);
        $this->serializer = SerializerBuilder::create()->build();
        $this->disableView();
        $this->disableLayout();
    }

    /**
     * @param $object
     * @param int $statusCode
     */
    public function sendJsonObjectResponse($object, $statusCode = 200)
    {
        if (!is_object($object)) {
            throw new InvalidArgumentException('You must pass an object.');
        }
        $this->disableLayout();
        $this->disableView();
        $this->setHeader('Cache-Control', 'no-cache, must-revalidate');
        $this->setHeader('Expires','Mon, 26 Jul 1997 05:00:00 GMT');
        $this->setHeader('Content-Type','application/json');
        $json = $this->serializer->serialize($object, 'json');
        $this->setBody($json);
        $this->setStatusCode($statusCode);
    }

    protected function httpMethodCheck($method)
    {
        if ($this->getRequest()->getMethod() !== $method) {
            $this->sendJsonResponse(['error' => 'Method not allowed'], 405);

            return false;
        }

        return true;
    }
}

1		<?php
2
3		namespace App\Controller;
4
5		use Bone\Mvc\Controller;
6		use InvalidArgumentException;
7		use JMS\Serializer\Serializer;
8		use JMS\Serializer\SerializerBuilder;
9		use Psr\Http\Message\ServerRequestInterface;
10
11		class BaseController extends Controller
12		{
13		/** @var Serializer */
14		protected $serializer;
15
16	14	public function __construct(ServerRequestInterface $request)
17		{
18	14	parent::__construct($request);
19	14	$this->serializer = SerializerBuilder::create()->build();
20	14	$this->disableView();
21	14	$this->disableLayout();
22	14	}
23
24		/**
25		* @param $object
26		* @param int $statusCode
27		*/
28	5	public function sendJsonObjectResponse($object, $statusCode = 200)
29		{
30	5	if (!is_object($object)) {
31		throw new InvalidArgumentException('You must pass an object.');
32		}
33	5	$this->disableLayout();
34	5	$this->disableView();
35	5	$this->setHeader('Cache-Control', 'no-cache, must-revalidate');
36	5	$this->setHeader('Expires','Mon, 26 Jul 1997 05:00:00 GMT');
37	5	$this->setHeader('Content-Type','application/json');
38	5	$json = $this->serializer->serialize($object, 'json');
39	5	$this->setBody($json);
40	5	$this->setStatusCode($statusCode);
41	5	}
42
43	5	protected function httpMethodCheck($method)
44		{
45	5	if ($this->getRequest()->getMethod() !== $method) {
46		$this->sendJsonResponse(['error' => 'Method not allowed'], 405);
47
48		return false;
49		}
50
51	5	return true;
52		}
53		}

delboy1978uk / oauth2-api

Push — master ( 24cbbe...c65133 )

BaseController::sendJsonObjectResponse() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like