OAuth\Repository\ClientRepository

Complexity

Total Complexity

9

Size/Duplication

Total Lines	66
Duplicated Lines	0 %

Test Coverage

Coverage

34.78%

Importance

Changes

0

4 Methods

Rating	Name	Duplication	Size	Complexity
A	getClientEntity()	0	16	5
A	save()	0	4	1
A	create()	0	12	2
A	delete()	0	4	1

<?php

namespace OAuth\Repository;

use Doctrine\ORM\UnitOfWork;
use OAuth\Client;
use Doctrine\ORM\EntityRepository;
use League\OAuth2\Server\Entities\ClientEntityInterface;
use League\OAuth2\Server\Repositories\ClientRepositoryInterface;
use OAuth\OAuthUser;

class ClientRepository extends EntityRepository implements ClientRepositoryInterface
{
    /**
     * @param string $clientIdentifier
     * @param null|string $grantType
     * @param null|string|null $clientSecret
     * @param bool $mustValidateSecret
     *
     * @return ClientEntityInterface|null
     */
    public function getClientEntity($clientIdentifier, $grantType = null, $clientSecret = null, $mustValidateSecret = true)
    {
        /** @var Client $client */
        $client = $this->findOneBy([
            'identifier' => $clientIdentifier
        ]);

        if ($client instanceof Client == false) {

It seems like you are loosely comparing two booleans. Considering using the strict comparison === instead.

            return null;
        }

        if ($mustValidateSecret === true && $client->isConfidential() === true && $clientSecret != $client->getSecret()) {
            return null;
        }

        return $client;
    }

    /**
     * @param Client $client
     * @return Client
     * @throws \Doctrine\ORM\OptimisticLockException
     */
    public function create(Client $client)
    {
        $em = $this->getEntityManager();
        $user = $client->getUser();
        if ($em->getUnitOfWork()->getEntityState($user) !== UnitOfWork::STATE_MANAGED) {
            /** @var OAuthUser $user */
            $user = $em->merge($user);
            $client->setUser($user);
        }
        $em->persist($client);
        $em->flush();
        return $client;
    }

    /**
     * @param Client $client
     * @return Client
     * @throws \Doctrine\ORM\OptimisticLockException
     */
    public function save(Client $client)
    {
        $this->_em->flush($client);
        return $client;
    }

    /**
     * @param Client $client
     * @throws \Doctrine\ORM\OptimisticLockException
     */
    public function delete(Client $client)
    {
        $this->_em->remove($client);
        $this->_em->flush($client);
    }
}