Del\Image\Strategy\JpegStrategy

Complexity

Total Complexity

5

Size/Duplication

Total Lines	24
Duplicated Lines	0 %

Test Coverage

Coverage

100%

Importance

Changes	1
Bugs	0	Features	1

5 Methods

Rating	Name	Duplication	Size	Complexity
A	create()	0	3	1
A	save()	0	3	1
A	render()	0	3	1
A	handleTransparency()	0	2	1
A	getContentType()	0	3	1

<?php


declare(strict_types=1);


namespace Del\Image\Strategy;


use GdImage;


class JpegStrategy implements ImageTypeStrategyInterface

{

    public function create(string $filename): GdImage

    {

        return \imagecreatefromjpeg($filename);

The expression return imagecreatefromjpeg($filename) could return the type resource which is incompatible with the type-hinted return GdImage. Consider adding an additional type-check to rule them out.

    }


    public function save(GdImage $resource, string $filename, int $compression): void

    {

        \imagejpeg($resource, $filename, $compression);

    }


    public function getContentType(): string

    {

        return 'image/jpeg';

    }


    public function render(GdImage $resource): void

    {

        \imagejpeg($resource);

    }


    public function handleTransparency(GdImage $newImage, GdImage $image): void

    {

        // Jpeg's aren't transparent.

    }

}