Del\Form\Renderer\HorizontalFormRenderer

Complexity

Total Complexity

10

Size/Duplication

Total Lines	85
Duplicated Lines	29.41 %

Coupling/Cohesion

Components	1
Dependencies	4

Test Coverage

Coverage

0%

Importance

Changes

0

6 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	7	1
A	render()	11	11	1
A	setFormAttributes()	14	14	2
A	getMethod()	0	4	2
A	getId()	0	4	2
A	processFields()	0	11	2

<?php
/**
 * User: delboy1978uk
 * Date: 29/11/2016
 * Time: 19:44
 */

namespace Del\Form\Renderer;

use Del\Form\Collection\FieldCollection;
use Del\Form\AbstractForm;
use Del\Form\FormInterface;
use DOMDocument;

class HorizontalFormRenderer implements FormRendererInterface

There is at least one abstract method in this class. Maybe declare it as abstract, or implement the remaining methods: renderFieldBlock, renderFieldLabel

{
    /** @var DOMDocument $dom */
    private $dom;

    /** @var \DomElement $form */
    private $form;

    /** @var bool $displayErrors */
    private $displayErrors;

    public function __construct($name)
    {
        $this->dom = new DOMDocument();
        $form = $this->dom->createElement('form');
        $form->setAttribute('name', $name);
        $this->form = $form;
    }

    /**
     * @param FormInterface $form
     * @param bool $displayErrors
     * @return string
     */
    public function render(FormInterface $form, $displayErrors = true)

This method seems to be duplicated in your project.

    {
        $this->displayErrors = $displayErrors;
        $this->setFormAttributes($form);

        $fields = $form->getFields();
        $this->processFields($fields);

        $this->dom->appendChild($this->form);
        return $this->dom->saveHTML();
    }

    /**
     * @param FormInterface $form
     */
    private function setFormAttributes(FormInterface $form)

This method seems to be duplicated in your project.

    {
        $attributes = $form->getAttributes();
        foreach ($attributes as $key => $value) {
            $this->form->setAttribute($key, $value);
        }

        // set Id as name or method as post if not set
        $method = $this->getMethod($form);
        $id = $this->getId($form);

        $this->form->setAttribute('id', $id);
        $this->form->setAttribute('method', $method);
    }

    /**
     * @param FormInterface $form
     * @return string
     */
    private function getMethod(FormInterface $form)
    {
        return $form->getMethod() ?: AbstractForm::METHOD_POST;
    }

    /**
     * @param FormInterface $form
     * @return string
     */
    private function getId(FormInterface $form)
    {
        return $form->getId() ?: $this->form->getAttribute('name');
    }

    private function processFields(FieldCollection $fields)
    {
        $fields->rewind();
        while ($fields->valid()) {
            $current = $fields->current();
            $child = $current->getRenderer()->render($this->dom, $current, $this->displayErrors);

The call to FieldRendererInterface::render() has too many arguments starting with $this->displayErrors.

            $this->form->appendChild($child);
            $fields->next();
        }
        $fields->rewind();
    }

}