for testing and deploying your application
for finding and fixing issues
for empowering human code reviews
<?php
/**
* User: delboy1978uk
* Date: 19/11/2016
* Time: 12:18
*/
namespace Del\Form\Collection;
use Del\Form\Field\FieldInterface;
class FieldCollection extends AbstractCollection implements CollectionInterface
{
* @param $name
* @return FieldInterface|null
public function findByName($name)
$this->rewind();
while ($this->valid()) {
/** @var FieldInterface $field */
$field = $this->current();
if ($field->getName() == $name) {
return $field;
}
$this->next();
return null;
public function removeByName($name): bool
$key = $this->key();
$this->offsetUnset($key);
$result = true;
$result
This check looks for variable assignements that are either overwritten by other assignments or where the variable is not used subsequently.
$myVar = 'Value'; $higher = false; if (rand(1, 6) > 3) { $higher = true; } else { $higher = false; }
Both the $myVar assignment in line 1 and the $higher assignment in line 2 are dead. The first because $myVar is never used and the second because $higher is always overwritten for every possible time line.
$myVar
$higher
return false;
* @return FieldInterface
public function current(): FieldInterface
return parent::current();
This check looks for variable assignements that are either overwritten by other assignments or where the variable is not used subsequently.
Both the
$myVar
assignment in line 1 and the$higher
assignment in line 2 are dead. The first because$myVar
is never used and the second because$higher
is always overwritten for every possible time line.