Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.
Common duplication problems, and corresponding solutions are:
1 | <?php |
||
7 | View Code Duplication | class ForcedCopy extends AbstractPlugin |
|
|
|||
8 | { |
||
9 | /** |
||
10 | * @inheritdoc |
||
11 | */ |
||
12 | 3 | public function getMethod() |
|
16 | |||
17 | /** |
||
18 | * Copies a file, overwriting any existing files. |
||
19 | * |
||
20 | * @param string $path Path to the existing file. |
||
21 | * @param string $newpath The new path of the file. |
||
22 | * |
||
23 | * @throws FileNotFoundException Thrown if $path does not exist. |
||
24 | * |
||
25 | * @return bool True on success, false on failure. |
||
26 | */ |
||
27 | 9 | public function handle($path, $newpath) |
|
42 | } |
||
43 |
Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation.
You can also find more detailed suggestions in the “Code” section of your repository.