CountryFactory::generate() - Code Metrics - Inspection of "refactor for iso code alphabetical and php7" - delboy1978uk/country - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( a17288...aa8e2a )

by Derek Stephen

created 2019-10-29 02:24 UTC

CountryFactory::generate() A

↳ Parent: CountryFactory

Complexity

Conditions	2
Paths	2

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	6
CRAP Score	2.0116

Importance

Changes

Metric	Value
dl	0
loc	13
ccs	6
cts	7
cp	0.8571
rs	9.8333
c	0
b	0
f	0
cc	2
nc	2
nop	1
crap	2.0116

<?php

namespace Del\Factory;

use Del\Entity\Country;
use Del\CountryException;
use Del\Repository\CountryRepository;

class CountryFactory
{
    /**
     * @var CountryRepository $countryRepository
     */
    private $countryRepository;

    private function __construct()
    {
    }

    private function __clone()
    {
    }

    /**
     * @param string $id
     * @return Country
     */
    public static function generate(string $id): Country
    {
        static $inst = null;

        if ($inst === null) {
            $inst = new CountryFactory();
            $inst->countryRepository = new CountryRepository();
        }

        $data = $inst->countryRepository->findCountryByIsoCode($id);

        return  $inst->countryRepository->createFromArray($data);
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
    }

    /**
     * @param CountryRepository $countryRepository
     */
    public function setCountryRepository(CountryRepository $countryRepository): void
    {
        $this->countryRepository = $countryRepository;
    }
}


1		<?php
2
3		namespace Del\Factory;
4
5		use Del\Entity\Country;
6		use Del\CountryException;
7		use Del\Repository\CountryRepository;
8
9		class CountryFactory
10		{
11		/**
12		* @var CountryRepository $countryRepository
13		*/
14		private $countryRepository;
15
16	1	private function __construct()
17		{
18	1	}
19
20		private function __clone()
21		{
22		}
23
24		/**
25		* @param string $id
26		* @return Country
27		*/
28	3	public static function generate(string $id): Country
29		{
30	3	static $inst = null;
31
32	3	if ($inst === null) {
33	1	$inst = new CountryFactory();
34	1	$inst->countryRepository = new CountryRepository();
35		}
36
37	3	$data = $inst->countryRepository->findCountryByIsoCode($id);
38
39		return $inst->countryRepository->createFromArray($data);
		0 ignored issues – show Documentation introduced 2019-10-29 02:26 UTC by Report Bug Copy Issue Report `$data` is of type `object<Del\Entity\Country>`, but the function expects a `array`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
40		}
41
42		/**
43		* @param CountryRepository $countryRepository
44		*/
45		public function setCountryRepository(CountryRepository $countryRepository): void
46		{
47		$this->countryRepository = $countryRepository;
48		}
49		}
50

delboy1978uk / country

Push — master ( a17288...aa8e2a )

CountryFactory::generate() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like