Del\Common\Value\StringValue

Complexity

Total Complexity

8

Size/Duplication

Total Lines	40
Duplicated Lines	0 %

Coupling/Cohesion

Components	0
Dependencies	1

Test Coverage

Coverage

100%

Importance

Changes	1
Bugs	0	Features	0

3 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	7	2
A	getValue()	0	4	1
B	canBeString()	0	12	5

<?php
/**
 * User: delboy1978uk
 * Date: 13/11/2016
 * Time: 13:26
 */

namespace Del\Common\Value;

use InvalidArgumentException;

class StringValue extends AbstractValue
{
    /**
     * StringValue constructor.
     *
     * @param string $value
     */
    public function __construct($value)
    {
        if(!$this->canBeString($value)) {

The expression $this->canBeString($value) of type boolean|null is loosely compared to false; this is ambiguous if the boolean can be false. You might want to explicitly use !== null instead.

            throw new InvalidArgumentException('You must supply a value.');
        }
        $this->value = (string) $value;
    }

    /**
     * @return string
     */
    public function getValue()
    {
        return parent::getValue();
    }

    /**
     * @param $value
     * @return bool
     */
    private function canBeString($value)
    {
        switch(true) {
            case is_object($value) && method_exists($value, '__toString'):
            case is_null($value):
            case is_scalar($value):
                return true;
                break;

break is not strictly necessary here and could be removed.

            default:
                return false;
        }
    }
}