InternationalisationMiddleware::__construct() - Code Metrics - Inspection of "creating i18n middleware" - delboy1978uk/bonemvc - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — feature/middleware ( 8ea9d8...ecd47e )

by Derek Stephen

created 2019-06-14 01:30 UTC

InternationalisationMiddleware::__construct() A

↳ Parent: InternationalisationMiddleware

Complexity

Conditions	2
Paths	2

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	7
rs	10
c	0
b	0
f	0
cc	2
nc	2
nop	2

<?php

namespace BoneMvc\Module\I18n;

use Locale;
use Psr\Http\Message\ResponseInterface;
use Psr\Http\Message\ServerRequestInterface;
use Psr\Http\Server\MiddlewareInterface;
use Psr\Http\Server\RequestHandlerInterface;
use Zend\Expressive\Helper\UrlHelper;

class InternationalisationMiddleware implements MiddlewareInterface
{
    /** @var UrlHelper  */
    private $helper;

    /** @var string|null  */
    private $defaultLocale;

    /** @var string $fallbackLocale */
    private $fallbackLocale = 'en_US';

    const REGEX_LOCALE = '#^/(?P<locale>[a-z]{2,3}|[a-z]{2}[-_][a-zA-Z]{2})(?:/|$)#';

    /**
     * InternationalisationMiddleware constructor.
     * @param  $helper
     * @param string|null $defaultLocale
     */
    public function __construct( $helper, string $defaultLocale = null)
    {
        $this->helper = $helper;
        if ($defaultLocale) {
''   == false // true
''   == null  // true
'ab' == false // false
'ab' == null  // false

// It is often better to use strict comparison
'' === false // false
'' === null  // false
            $this->defaultLocale = $defaultLocale;
        }
    }

    /**
     * @param ServerRequestInterface $request
     * @param RequestHandlerInterface $handler
     * @return ResponseInterface
     */
    public function process(ServerRequestInterface $request, RequestHandlerInterface $handler) : ResponseInterface
    {
        $uri = $request->getUri();
        die('aye ' . $uri);
        $path = $uri->getPath();
function fx() {
    try {
        doSomething();
        return true;
    }
    catch (\Exception $e) {
        return false;
    }

    return false;
}

        if (! preg_match(self::REGEX_LOCALE, $path, $matches)) {
            Locale::setDefault($this->defaultLocale ?: $this->fallbackLocale);
            return $handler->handle($request);
        }

        $locale = $matches['locale'];
        Locale::setDefault(Locale::canonicalize($locale));
        $this->helper->setBasePath($locale);

        $path = substr($path, strlen($locale) + 1);

        return $handler->handle($request->withUri(
            $uri->withPath($path ?: '/')
        ));
    }
}

1			<?php
2
3			namespace BoneMvc\Module\I18n;
4
5			use Locale;
6			use Psr\Http\Message\ResponseInterface;
7			use Psr\Http\Message\ServerRequestInterface;
8			use Psr\Http\Server\MiddlewareInterface;
9			use Psr\Http\Server\RequestHandlerInterface;
10			use Zend\Expressive\Helper\UrlHelper;
11
12			class InternationalisationMiddleware implements MiddlewareInterface
13			{
14			/** @var UrlHelper */
15			private $helper;
16
17			/** @var string\|null */
18			private $defaultLocale;
19
20			/** @var string $fallbackLocale */
21			private $fallbackLocale = 'en_US';
22
23			const REGEX_LOCALE = '#^/(?P<locale>[a-z]{2,3}\|[a-z]{2}[-_][a-zA-Z]{2})(?:/\|$)#';
24
25			/**
26			* InternationalisationMiddleware constructor.
27			* @param $helper
28			* @param string\|null $defaultLocale
29			*/
30			public function __construct( $helper, string $defaultLocale = null)
31			{
32			$this->helper = $helper;
33			if ($defaultLocale) {
			0 ignored issues – show Bug Best Practice introduced 2019-06-14 01:34 UTC by Report Bug Copy Issue Report The expression `$defaultLocale` of type `null\|string` is loosely compared to `true`; this is ambiguous if the string can be empty. You might want to explicitly use `!== null` instead. In PHP, under loose comparison (like `==`, or `!=`, or `switch` conditions), values of different types might be equal. For `string` values, the empty string `''` is a special case, in particular the following results might be unexpected: '' == false // true '' == null // true 'ab' == false // false 'ab' == null // false // It is often better to use strict comparison '' === false // false '' === null // false Loading history...
34			$this->defaultLocale = $defaultLocale;
35			}
36			}
37
38			/**
39			* @param ServerRequestInterface $request
40			* @param RequestHandlerInterface $handler
41			* @return ResponseInterface
42			*/
43			public function process(ServerRequestInterface $request, RequestHandlerInterface $handler) : ResponseInterface
44			{
45			$uri = $request->getUri();
46			die('aye ' . $uri);
47			$path = $uri->getPath();
			0 ignored issues – show Unused Code introduced 2019-06-14 01:34 UTC by Report Bug Copy Issue Report `$path = $uri->getPath();` does not seem to be reachable. This check looks for unreachable code. It uses sophisticated control flow analysis techniques to find statements which will never be executed. Unreachable code is most often the result of `return`, `die` or `exit` statements that have been added for debug purposes. function fx() { try { doSomething(); return true; } catch (\Exception $e) { return false; } return false; } In the above example, the last `return false` will never be executed, because a return statement has already been met in every possible execution path. Loading history...
48
49			if (! preg_match(self::REGEX_LOCALE, $path, $matches)) {
50			Locale::setDefault($this->defaultLocale ?: $this->fallbackLocale);
51			return $handler->handle($request);
52			}
53
54			$locale = $matches['locale'];
55			Locale::setDefault(Locale::canonicalize($locale));
56			$this->helper->setBasePath($locale);
57
58			$path = substr($path, strlen($locale) + 1);
59
60			return $handler->handle($request->withUri(
61			$uri->withPath($path ?: '/')
62			));
63			}
64			}

delboy1978uk / bonemvc

Push — feature/middleware ( 8ea9d8...ecd47e )

InternationalisationMiddleware::__construct() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like