BoneMvc\Module\Orc\Controller\OrcApiController

Complexity

Total Complexity

11

Size/Duplication

Total Lines	126
Duplicated Lines	100 %

Coupling/Cohesion

Components	1
Dependencies	5

Importance

Changes

0

6 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	4	4	1
A	indexAction()	19	19	2
A	createAction()	18	18	3
A	viewAction()	6	6	1
A	updateAction()	21	21	3
A	deleteAction()	8	8	1

<?php

declare(strict_types=1);

namespace BoneMvc\Module\Orc\Controller;

use BoneMvc\Module\Orc\Collection\OrcCollection;
use BoneMvc\Module\Orc\Form\OrcForm;
use BoneMvc\Module\Orc\Service\OrcService;
use League\Route\Http\Exception\NotFoundException;
use Psr\Http\Message\ResponseInterface;
use Psr\Http\Message\ServerRequestInterface;
use Zend\Diactoros\Response\JsonResponse;

class OrcApiController

This class seems to be duplicated in your project.

{
    /** @param OrcService $service */
    private $service;

    /**
     * @param OrcService $service
     */
    public function __construct(OrcService $service)
    {
        $this->service = $service;
    }

    /**
     * @param ServerRequestInterface $request
     * @param array $args
     * @return ResponseInterface
     * @throws NotFoundException
     * @throws \Doctrine\ORM\NonUniqueResultException
     */
    public function indexAction(ServerRequestInterface $request, array $args): ResponseInterface

The parameter $args is not used and could be removed.

    {
        $params = $request->getQueryParams();
        $limit = $params['limit'];
        $offset = $params['offset'];
        $db = $this->service->getRepository();
        $orcs = new OrcCollection($db->findBy([], null, $limit, $offset));
        $total = $db->getTotalOrcCount();
        $count = count($orcs);
        if ($count < 1) {
            throw new NotFoundException();
        }

        $payload['_embedded'] = $orcs->toArray();

$payload was never initialized. Although not strictly required by PHP, it is generally a good practice to add $payload = array(); before regardless.

        $payload['count'] = $count;
        $payload['total'] = $total;

        return new JsonResponse($payload);
    }

    /**
     * @param ServerRequestInterface $request
     * @param array $args
     * @return ResponseInterface
     * @throws \Doctrine\ORM\ORMException
     * @throws \Doctrine\ORM\OptimisticLockException
     */
    public function createAction(ServerRequestInterface $request, array $args): ResponseInterface

The parameter $args is not used and could be removed.

    {
        $post = json_decode($request->getBody()->getContents(), true) ?: $request->getParsedBody();
        $form = new OrcForm('create');
        $form->populate($post);

        if ($form->isValid()) {
            $data = $form->getValues();
            $orc = $this->service->createFromArray($data);
            $this->service->saveOrc($orc);

            return new JsonResponse($orc->toArray());
        }

        return new JsonResponse([
            'error' => $form->getErrorMessages(),
        ]);
    }

    /**
     * @param ServerRequestInterface $request
     * @param array $args
     * @return ResponseInterface
     * @throws \Doctrine\ORM\EntityNotFoundException
     */
    public function viewAction(ServerRequestInterface $request, array $args): ResponseInterface

The parameter $request is not used and could be removed.

    {
        $orc = $this->service->getRepository()->find($args['id']);

        return new JsonResponse($orc->toArray());
    }

    /**
     * @param ServerRequestInterface $request
     * @param array $args
     * @return ResponseInterface
     * @throws \Doctrine\ORM\EntityNotFoundException
     * @throws \Doctrine\ORM\ORMException
     * @throws \Doctrine\ORM\OptimisticLockException
     */
    public function updateAction(ServerRequestInterface $request, array $args): ResponseInterface
    {
        $db = $this->service->getRepository();
        $orc = $db->find($args['id']);

        $post = json_decode($request->getBody()->getContents(), true) ?: $request->getParsedBody();
        $form = new OrcForm('update');
        $form->populate($post);

        if ($form->isValid()) {
            $data = $form->getValues();
            $orc = $this->service->updateFromArray($orc, $data);
            $this->service->saveOrc($orc);

            return new JsonResponse($orc->toArray());
        }

        return new JsonResponse([
            'error' => $form->getErrorMessages(),
        ]);
    }

    /**
     * @param ServerRequestInterface $request
     * @param array $args
     * @return ResponseInterface
     * @throws \Doctrine\ORM\EntityNotFoundException
     * @throws \Doctrine\ORM\ORMException
     * @throws \Doctrine\ORM\OptimisticLockException
     */
    public function deleteAction(ServerRequestInterface $request, array $args): ResponseInterface

The parameter $request is not used and could be removed.

    {
        $db = $this->service->getRepository();
        $orc = $db->find($args['id']);
        $this->service->deleteOrc($orc);

        return new JsonResponse(['deleted' => true]);
    }
}