Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.
Common duplication problems, and corresponding solutions are:
| 1 | <?php |
||
| 8 | class Paginator |
||
| 9 | { |
||
| 10 | private $currentPage = 1; |
||
| 11 | private $pageCount; |
||
| 12 | private $pagerSize = 5; |
||
| 13 | private $url; |
||
| 14 | private $urlPart = ':page'; |
||
| 15 | |||
| 16 | /** |
||
| 17 | * @param int $pageNum |
||
| 18 | * @return string |
||
| 19 | */ |
||
| 20 | 5 | private function url(int $pageNum): string |
|
| 24 | |||
| 25 | /** |
||
| 26 | * @param $pageCount |
||
| 27 | */ |
||
| 28 | 2 | public function setPageCount(int $pageCount): void |
|
| 32 | |||
| 33 | /** |
||
| 34 | * @param $pageCount |
||
| 35 | */ |
||
| 36 | 5 | public function setPageCountByTotalRecords(int $rowCount, int $numPerPage): void |
|
| 40 | |||
| 41 | /** |
||
| 42 | * @param $url |
||
| 43 | */ |
||
| 44 | 6 | public function setUrl(string $url): void |
|
| 48 | |||
| 49 | /** |
||
| 50 | * @param $replace |
||
| 51 | */ |
||
| 52 | 1 | public function setUrlPart(string $replace): void |
|
| 56 | |||
| 57 | /** |
||
| 58 | * @param int $page_no |
||
| 59 | */ |
||
| 60 | 6 | public function setCurrentPage(int $page_no): void |
|
| 64 | |||
| 65 | /** |
||
| 66 | * @param int $numBoxes an ODD number! |
||
| 67 | */ |
||
| 68 | 7 | public function setPagerSize(int $numBoxes): void |
|
| 75 | |||
| 76 | /** |
||
| 77 | * @return int |
||
| 78 | */ |
||
| 79 | 7 | public function getPagerSize(): int |
|
| 83 | |||
| 84 | /** |
||
| 85 | * @throws PaginatorException |
||
| 86 | */ |
||
| 87 | 8 | private function ensurePageCount() |
|
| 93 | |||
| 94 | /** |
||
| 95 | * @throws PaginatorException |
||
| 96 | */ |
||
| 97 | 7 | private function ensureUrl() |
|
| 103 | |||
| 104 | /** |
||
| 105 | * @return int |
||
| 106 | */ |
||
| 107 | 5 | private function calculateStart(int $pages): int |
|
| 125 | |||
| 126 | /** |
||
| 127 | * @return string |
||
| 128 | * @throws PaginatorException |
||
| 129 | */ |
||
| 130 | 8 | public function render(): string |
|
| 158 | |||
| 159 | /** |
||
| 160 | * @param string $icon |
||
| 161 | * @param bool $fastBackward |
||
| 162 | * @return string |
||
| 163 | */ |
||
| 164 | 6 | private function renderRewind($icon = Icon::BACKWARD, $fastBackward = false) |
|
| 177 | |||
| 178 | /** |
||
| 179 | * @param string $icon |
||
| 180 | * @param bool $fastBackward |
||
| 181 | * @return string |
||
| 182 | */ |
||
| 183 | 6 | private function renderForward($icon = Icon::FORWARD, $fastForward = false) |
|
| 196 | |||
| 197 | /** |
||
| 198 | * @param int $pageNo |
||
| 199 | * @return string |
||
| 200 | */ |
||
| 201 | 6 | private function renderBox(int $pageNo): string |
|
| 217 | } |
||
| 218 |
Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation.
You can also find more detailed suggestions in the “Code” section of your repository.