Application::setSail() - Code Metrics - Inspection of "fix merge error" - delboy1978uk/bone - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — dev-master ( c33e43...966d5f )

by Derek Stephen

created 2017-01-21 17:23 UTC

Application::setSail() A

↳ Parent: Application

Complexity

Conditions	1
Paths	1

Size

Total Lines	7
Code Lines	5

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	7
CRAP Score	1

Importance

Changes

Metric	Value
dl	0
loc	7
ccs	7
cts	7
cp	1
rs	9.4285
c	0
b	0
f	0
cc	1
eloc	5
nc	1
nop	0
crap	1

<?php


namespace Bone\Mvc;

use Zend\Diactoros\ServerRequestFactory;
use Zend\Diactoros\Response;

class Application
{
    private $registry;


    /**
     *  There be nay feckin wi' constructors on board this ship
     *  There be nay copyin' o' th'ship either
     *  This ship is a singleton!
     */
    public function __construct(){}
    public function __clone(){}


    /**
     *  Ahoy! There nay be boardin without yer configuration
     *
     * @param array $config
     * @return Application
     */
    public static function ahoy(array $config)
    {
        static $inst = null;
        if($inst === null)
        {
            $inst = new Application();
            $inst->registry = Registry::ahoy();
            foreach($config as $key => $value)
            {
                $inst->registry->set($key,$value);
            }
        }
        return $inst;
    }

    /**
     *  T' the high seas! Garrr!
     */
    public function setSail()
// Bad
class Router
{
    public function generate($path)
    {
        return $_SERVER['HOST'].$path;
    }
}

// Better
class Router
{
    private $host;

    public function __construct($host)
    {
        $this->host = $host;
    }

    public function generate($path)
    {
        return $this->host.$path;
    }
}

class Controller
{
    public function myAction(Request $request)
    {
        // Instead of
        $page = isset($_GET['page']) ? intval($_GET['page']) : 1;

        // Better (assuming you use the Symfony2 request)
        $page = $request->query->get('page', 1);
    }
}
    {
        $request = ServerRequestFactory::fromGlobals($_SERVER, $_GET, $_POST, $_COOKIE, $_FILES);
        $response = new Response();
        $dispatcher = new Dispatcher($request, $response);
        $dispatcher->fireCannons();
    }
}

1		<?php
2
3
4		namespace Bone\Mvc;
5
6		use Zend\Diactoros\ServerRequestFactory;
7		use Zend\Diactoros\Response;
8
9		class Application
10		{
11		private $registry;
		0 ignored issues – show Unused Code introduced 2016-04-11 07:17 UTC by Report Bug Copy Issue Report The property `$registry` is not used and could be removed. This check marks private properties in classes that are never used. Those properties can be removed. Loading history...
12
13		/**
14		* There be nay feckin wi' constructors on board this ship
15		* There be nay copyin' o' th'ship either
16		* This ship is a singleton!
17		*/
18		public function __construct(){}
19		public function __clone(){}
20
21
22		/**
23		* Ahoy! There nay be boardin without yer configuration
24		*
25		* @param array $config
26		* @return Application
27		*/
28	2	public static function ahoy(array $config)
29	2	{
30	2	static $inst = null;
31	2	if($inst === null)
32	2	{
33	1	$inst = new Application();
34	1	$inst->registry = Registry::ahoy();
35	1	foreach($config as $key => $value)
36		{
37	1	$inst->registry->set($key,$value);
38	2	}
39	1	}
40	2	return $inst;
41		}
42
43		/**
44		* T' the high seas! Garrr!
45		*/
46	1	public function setSail()
		0 ignored issues – show Coding Style introduced 2016-04-11 07:17 UTC by Report Bug Copy Issue Report `setSail` uses the super-global variable `$_SERVER` which is generally not recommended. Instead of super-globals, we recommend to explicitly inject the dependencies of your class. This makes your code less dependent on global state and it becomes generally more testable: // Bad class Router { public function generate($path) { return $_SERVER['HOST'].$path; } } // Better class Router { private $host; public function __construct($host) { $this->host = $host; } public function generate($path) { return $this->host.$path; } } class Controller { public function myAction(Request $request) { // Instead of $page = isset($_GET['page']) ? intval($_GET['page']) : 1; // Better (assuming you use the Symfony2 request) $page = $request->query->get('page', 1); } } Loading history... Coding Style introduced 2016-04-11 07:17 UTC by Report Bug Copy Issue Report `setSail` uses the super-global variable `$_GET` which is generally not recommended. Instead of super-globals, we recommend to explicitly inject the dependencies of your class. This makes your code less dependent on global state and it becomes generally more testable: // Bad class Router { public function generate($path) { return $_SERVER['HOST'].$path; } } // Better class Router { private $host; public function __construct($host) { $this->host = $host; } public function generate($path) { return $this->host.$path; } } class Controller { public function myAction(Request $request) { // Instead of $page = isset($_GET['page']) ? intval($_GET['page']) : 1; // Better (assuming you use the Symfony2 request) $page = $request->query->get('page', 1); } } Loading history... Coding Style introduced 2016-04-11 07:17 UTC by Report Bug Copy Issue Report `setSail` uses the super-global variable `$_POST` which is generally not recommended. Instead of super-globals, we recommend to explicitly inject the dependencies of your class. This makes your code less dependent on global state and it becomes generally more testable: // Bad class Router { public function generate($path) { return $_SERVER['HOST'].$path; } } // Better class Router { private $host; public function __construct($host) { $this->host = $host; } public function generate($path) { return $this->host.$path; } } class Controller { public function myAction(Request $request) { // Instead of $page = isset($_GET['page']) ? intval($_GET['page']) : 1; // Better (assuming you use the Symfony2 request) $page = $request->query->get('page', 1); } } Loading history... Coding Style introduced 2016-04-11 07:17 UTC by Report Bug Copy Issue Report `setSail` uses the super-global variable `$_COOKIE` which is generally not recommended. Instead of super-globals, we recommend to explicitly inject the dependencies of your class. This makes your code less dependent on global state and it becomes generally more testable: // Bad class Router { public function generate($path) { return $_SERVER['HOST'].$path; } } // Better class Router { private $host; public function __construct($host) { $this->host = $host; } public function generate($path) { return $this->host.$path; } } class Controller { public function myAction(Request $request) { // Instead of $page = isset($_GET['page']) ? intval($_GET['page']) : 1; // Better (assuming you use the Symfony2 request) $page = $request->query->get('page', 1); } } Loading history... Coding Style introduced 2017-01-19 23:50 UTC by Report Bug Copy Issue Report `setSail` uses the super-global variable `$_FILES` which is generally not recommended. Instead of super-globals, we recommend to explicitly inject the dependencies of your class. This makes your code less dependent on global state and it becomes generally more testable: // Bad class Router { public function generate($path) { return $_SERVER['HOST'].$path; } } // Better class Router { private $host; public function __construct($host) { $this->host = $host; } public function generate($path) { return $this->host.$path; } } class Controller { public function myAction(Request $request) { // Instead of $page = isset($_GET['page']) ? intval($_GET['page']) : 1; // Better (assuming you use the Symfony2 request) $page = $request->query->get('page', 1); } } Loading history...
47	1	{
48	1	$request = ServerRequestFactory::fromGlobals($_SERVER, $_GET, $_POST, $_COOKIE, $_FILES);
49	1	$response = new Response();
50	1	$dispatcher = new Dispatcher($request, $response);
51	1	$dispatcher->fireCannons();
52		}
53		}

delboy1978uk / bone

Push — dev-master ( c33e43...966d5f )

Application::setSail() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like