BoneUserController::__construct() - Code Metrics - Inspection of "tests" - delboy1978uk/bone-user - Measure and Improve Code Quality continuously with Scrutinizer

Passed
Push — master ( e4b148...d70af7 )

by Derek Stephen
created 2022-03-09 22:13 UTC
BoneUserController::__construct() A

↳ Parent: BoneUserController
Complexity

Conditions	1
Paths	1
Size

Total Lines	13
Code Lines	9
Duplication

Lines	0
Ratio	0 %
Code Coverage

Tests	10
CRAP Score	1
Importance

Changes
Metric	Value
eloc	9
c	0
b	0
f	0
dl	0
loc	13
ccs	10
cts	10
cp	1
rs	9.9666
cc	1
nc	1
nop	8
crap	1
How to fix Many Parameters

<?php declare(strict_types=1);

namespace Bone\User\Controller;

use Bone\Http\Response\HtmlResponse;
use Bone\Http\Response\LayoutResponse;
use Bone\I18n\Form;
use Bone\Controller\Controller;
use Bone\Paseto\PasetoService;
use Bone\Server\SiteConfigAwareInterface;
use Bone\Server\Traits\HasSiteConfigTrait;
use Bone\View\ViewEngine;
use Bone\Server\SessionAwareInterface;
use Bone\Server\Traits\HasSessionTrait;
use Bone\Mail\EmailMessage;
use Bone\Mail\Service\MailService;
use Bone\User\Form\LoginForm;
use Bone\User\Form\PersonForm;
use Bone\User\Form\RegistrationForm;
use Bone\User\Form\ResetPasswordForm;
use DateTime;
use Del\Entity\User;
use Del\Exception\EmailLinkException;
use Del\Exception\UserException;
use Del\Factory\CountryFactory;
use Del\Form\Field\Text\EmailAddress;
use Del\Icon;
use Del\Service\UserService;
use Del\SessionManager;
use Del\Value\User\State;
use Exception;
use Psr\Http\Message\ResponseInterface;
use Psr\Http\Message\ServerRequestInterface;
use Laminas\Diactoros\Response\RedirectResponse;
use Laminas\Diactoros\Uri;

class BoneUserController extends Controller implements SessionAwareInterface
{
    use HasSessionTrait;
    use HasSiteConfigTrait;

    /** @var UserService $userService */
    private $userService;

    /** @var MailService $mailService */
    private $mailService;

    /** @var string $loginRedirectRoute */
    private $loginRedirectRoute;

    /** @var string $logo */
    private $logo;

    /** @var string $adminLayout */
    private $adminLayout;

    /** @var bool $registrationEnabled */
    private $registrationEnabled;

    /** @var bool $profileRequired */
    private $profileRequired;

    /** @var bool $rememberMeCookie */
    private $rememberMeCookie;

    /** @var PasetoService $pasetoService */
    private $pasetoService;

    /**
     * BoneUserController constructor.
     * @param UserService $userService
     * @param MailService $mailService
     */
    public function __construct(UserService $userService, MailService $mailService, string $loginRedirectRoute,
                                string $adminLayout, PasetoService $pasetoService, bool $registrationEnabled = true, $profileRequired = false,
                                bool $rememberMeCookie = true)
    {
        $this->userService = $userService;
        $this->mailService = $mailService;
        $this->loginRedirectRoute = $loginRedirectRoute;
        $this->adminLayout = $adminLayout;
        $this->registrationEnabled = $registrationEnabled;
        $this->profileRequired = $profileRequired;
        $this->rememberMeCookie = $rememberMeCookie;
        $this->profileRequired = $profileRequired;
        $this->pasetoService = $pasetoService;
    }

    /**
     * @return string
     */
    public function getLogo(): string
    {
        if (!$this->logo) {
            $this->logo = $this->getSiteConfig()->getLogo();
        }

        return $this->logo;
    }

    /**
     * @param ServerRequestInterface $request
     * @return ResponseInterface $response
     * @throws \Exception
     */
    public function indexAction(ServerRequestInterface $request): ResponseInterface
    public function indexAction(/** @scrutinizer ignore-unused */ ServerRequestInterface $request): ResponseInterface
    {
        if ($this->getSession()->get('user')) {
            return new RedirectResponse('/user/home');
        }

        $body = $this->getView()->render('boneuser::index', [
            'logo' => $this->getLogo(),
            'canRegister' => $this->registrationEnabled
        ]
    );

        return new HtmlResponse($body);
    }

    /**
     * @param ServerRequestInterface $request
     * @return ResponseInterface
     * @throws UserException
     */
    public function registerAction(ServerRequestInterface $request): ResponseInterface
    {
        $form = new RegistrationForm('register', $this->getTranslator());
        $message = null;

        if ($request->getMethod() === 'POST') {

            $formData = $request->getParsedBody();
            $form->populate($formData);
            $form->populate(/** @scrutinizer ignore-type */ $formData);

            if ($form->isValid()) {
                $data = $form->getValues();

                try {
                    $user = $this->userService->registerUser($data);
                    $link = $this->userService->generateEmailLink($user);
                    $mail = $this->mailService;

                    $env = $mail->getSiteConfig()->getEnvironment();
                    $email = $user->getEmail();
                    $token = $link->getToken();

                    $mail = new EmailMessage();
                    $mail->setTo($user->getEmail());
                    $mail->setSubject($this->getTranslator()->translate('email.user.register.thankswith', 'user') . ' ' . $this->mailService->getSiteConfig()->getTitle());
                    $mail->setTemplate('email.user::user_registration/user_registration');
                    $mail->setViewData([
                        'siteUrl' => $env->getSiteURL(),
                        'logo' => $this->getSiteConfig()->getEmailLogo(),
                        'address' => $this->getSiteConfig()->getAddress(),
                        'activationLink' => '/user/activate/' . $email . '/' . $token,
                    ]);
                    $this->mailService->sendEmail($mail);
                    $body = $this->getView()->render('boneuser::thanks-for-registering', ['logo' => $this->getLogo()]);

                    return new HtmlResponse($body);

                } catch (UserException $e) {
                    $message = [$e->getMessage(), 'danger'];
                }
            } else {
                $message = [Icon::WARNING . ' There was a problem with your form.', 'danger'];
            }
        }

        $body = $this->getView()->render('boneuser::register', ['form' => $form, 'message' => $message, 'logo' => $this->getLogo()]);

        return new HtmlResponse($body);
    }

    /**
     * @param ServerRequestInterface $request
     * @return ResponseInterface
     * @throws \Doctrine\ORM\ORMException
     * @throws \Doctrine\ORM\OptimisticLockException
     */
    public function activateAction(ServerRequestInterface $request): ResponseInterface
    {
        $email = $request->getAttribute('email');
        $token = $request->getAttribute('token');
        $translator = $this->getTranslator();
        $userService = $this->userService;
        $loginRedirect = $this->loginRedirectRoute;
        $message = null;

        try {
            $link = $userService->findEmailLink($email, $token);
            $user = $link->getUser();
            $user->setState(new State(State::STATE_ACTIVATED));
            $user->setLastLogin(new DateTime());
            $userService->saveUser($user);
            $userService->deleteEmailLink($link);
            $this->getSession()->set('user', $user->getId());

            if ($this->profileRequired && !$this->userService->hasProfile($user)) {
                $this->loginRedirectRoute = '/user/edit-profile';

                return new RedirectResponse($this->loginRedirectRoute);
            }
        } catch (EmailLinkException $e) {
            switch ($e->getMessage()) {
                case EmailLinkException::LINK_EXPIRED:
                    $message = [$translator->translate('login.activation.expired', 'user')
                        . ' <a href="/user/resend-activation-mail/' . $email . '">'
                        . $translator->translate('login.activation.expired2', 'user') . '</a>', 'danger'];
                    break;
                default:
                    $message = [$e->getMessage(), 'danger'];
                    break;
            }
        }

        $body = $this->getView()->render('boneuser::activate-user-account', [
            'loginRedirect' => $loginRedirect,
            'message' => $message,
            'logo' => $this->getLogo(),
        ]);

        return new HtmlResponse($body);
    }

    private function initForm(LoginForm $form)
    {
        $this->rememberMeCookie === false ? $form->getFields()->removeByName('remember') : null;
    }


    /**
     * @param ServerRequestInterface $request
     * @return ResponseInterface
     */
    public function loginAction(ServerRequestInterface $request): ResponseInterface
    public function loginAction(/** @scrutinizer ignore-unused */ ServerRequestInterface $request): ResponseInterface
    {
        $form = new LoginForm('userlogin', $this->getTranslator());
        $this->initForm($form);
        $body = $this->getView()->render('boneuser::login', ['form' => $form, 'logo' => $this->getLogo()]);

        return new HtmlResponse($body);
    }


    /**
     * @param ServerRequestInterface $request
     * @return ResponseInterface
     */
    public function loginFormAction(ServerRequestInterface $request): ResponseInterface
    {
        $translator = $this->getTranslator();
        $form = new LoginForm('userlogin', $translator);
        $this->initForm($form);
        $post = $request->getParsedBody();
        $form->populate($post);
        $form->populate(/** @scrutinizer ignore-type */ $post);
        $params = ['form' => $form];

        try {
            if ($form->isValid()) {
                $data = $form->getValues();
                $email = $data['email'];
                $pass = $data['password'];
                $userId = $this->userService->authenticate($email, $pass);
                $locale = $translator->getLocale();
                $session = $this->getSession();
                $session->set('user', $userId);
                $session->set('locale', $locale);
                $this->rememberMeCookie && isset($data['remember']) ? $this->setCookie((int)$data['remember'], $userId) : null;

                if ($route = $session->get('loginRedirectRoute')) {
                    $this->loginRedirectRoute = $route;
                    $session->unset('loginRedirectRoute');
                }

                $user = $this->userService->findUserById($userId);
                $user->setLastLogin(new DateTime());
                $this->userService->saveUser($user);
                $this->userService->saveUser(/** @scrutinizer ignore-type */ $user);

                if ($this->profileRequired && !$this->userService->hasProfile($user)) {
                if ($this->profileRequired && !$this->userService->hasProfile(/** @scrutinizer ignore-type */ $user)) {
                    $this->loginRedirectRoute = '/user/edit-profile';
                }

                return new RedirectResponse('/' . $locale . $this->loginRedirectRoute);
            }
        } catch (UserException $e) {
            switch ($e->getMessage()) {
                case UserException::USER_NOT_FOUND:
                case UserException::WRONG_PASSWORD:
                    $message = [Icon::WARNING . ' ' . $translator->translate('login.error.password', 'user') . '<a href="/user/lost-password/' . $email . '">' . $translator->translate('login.error.password2', 'user') . '</a>', 'danger'];

                    break;
                case UserException::USER_UNACTIVATED:
                    $message = [Icon::WARNING . ' ' . $translator->translate('login.unactivated', 'user') . '<a href="/user/resend-activation-mail/' . $email . '">' . $translator->translate('login.unactivated2', 'user') . '</a>', 'danger'];
                    break;
                case UserException::USER_DISABLED:
                case UserException::USER_BANNED:
                    $message = [Icon::REMOVE . ' ' . $translator->translate('login.activation.banned', 'user'), 'danger'];
                    break;
                default:
                    $message = $e->getMessage();
                    break;
            }

            $params['message'] = $message;
        }

        $params['logo'] = $this->getLogo();
        $body = $this->getView()->render('boneuser::login', $params);

        return new HtmlResponse($body);

    }

    /**
     * @param int $length
     * @param int $userId
     * @throws \ParagonIE\Paseto\Exception\InvalidKeyException
     * @throws \ParagonIE\Paseto\Exception\InvalidPurposeException
     * @throws \ParagonIE\Paseto\Exception\PasetoException
     */
    private function setCookie(int $length, int $userId): void
    {
        $times = [
            1 => 60 * 60 * 24 * 7,
            2 => 60 * 60 * 24 * 30,
            3 => 60 * 60 * 24 * 365,
        ];

        $intervals = [
            1 => 'P07D',
            2 => 'P30D',
            3 => 'P365D',
        ];

        $time = array_key_exists($length, $times) ? $times[$length] : 0;
        $time += \time();
        $expiry = \time() + $time;
        $interval = array_key_exists($length, $intervals) ? $intervals[$length] : 'P0D';
        $token = $this->pasetoService->encryptToken([
            'user' => $userId,
        ], $interval);
        \setcookie('resu', $token, $expiry, '/');
    }

    /**
     * @param ServerRequestInterface $request
     * @return ResponseInterface
     */
    public function homePageAction(ServerRequestInterface $request): ResponseInterface
    {
        if ($this->loginRedirectRoute !== '/user/home') {
            return new RedirectResponse($this->loginRedirectRoute);
        }

        $user = $request->getAttribute('user');

        if ($this->profileRequired && !$this->userService->hasProfile($user)) {
            $this->loginRedirectRoute = '/user/edit-profile';

            return new RedirectResponse($this->loginRedirectRoute);
        }

        $body = $this->getView()->render('boneuser::home', [
            'message' => [$this->getTranslator()->translate('home.loggedin', 'user'), 'success'],
            'user' => $user,
            'logo' => $this->getSiteConfig()->getLogo(),
        ]);

        return new LayoutResponse($body, $this->adminLayout);
    }

    /**
     * @param ServerRequestInterface $request
     * @return ResponseInterface
     */
    public function logoutAction(ServerRequestInterface $request): ResponseInterface
    public function logoutAction(/** @scrutinizer ignore-unused */ ServerRequestInterface $request): ResponseInterface
    {
        SessionManager::destroySession();
        \setcookie('resu', '', 1, '/');

        return new RedirectResponse(new Uri('/'));
    }

    /**
     * @param ServerRequestInterface $request
     * @return ResponseInterface
     */
    public function resendActivationEmailAction(ServerRequestInterface $request): ResponseInterface
    {
        $email = $request->getAttribute('email');
        $user = $this->userService->findUserByEmail($email);
        $message = [];
        $translator = $this->getTranslator();

        if (!$user) {
            throw new Exception(UserException::USER_NOT_FOUND, 404);
        }

        if ($user->getState()->getValue() == State::STATE_ACTIVATED) {
            $message = [UserException::USER_ACTIVATED, 'danger'];
        } else {
            try {
                $link = $this->userService->generateEmailLink($user);
                $mail = $this->mailService;

                $env = $mail->getSiteConfig()->getEnvironment();
                $email = $user->getEmail();
                $token = $link->getToken();

                $mail = new EmailMessage();
                $mail->setTo($user->getEmail());
                $mail->setSubject($translator->translate('email.user.register.thankswith', 'user') . ' ' . $this->mailService->getSiteConfig()->getTitle());
                $mail->setTemplate('email.user::user_registration/user_registration');
                $mail->setViewData([
                    'siteUrl' => $env->getSiteURL(),
                    'logo' => $this->getSiteConfig()->getEmailLogo(),
                    'address' => $this->getSiteConfig()->getAddress(),
                    'activationLink' => '/user/activate/' . $email . '/' . $token,
                ]);
                $this->mailService->sendEmail($mail);

            } catch (Exception $e) {
                $message = [$translator->translate('login.resendactivation.error', 'user')
                    . $this->getSiteConfig()->getContactEmail() . '', 'danger'];
            }
        }

        $body = $this->getView()->render('boneuser::resend-activation', [
            'message' => $message,
            'logo' => $this->getLogo(),
        ]);

        return new HtmlResponse($body);
    }


    /**
     * @param ServerRequestInterface $request
     * @return ResponseInterface
     */
    public function forgotPasswordAction(ServerRequestInterface $request): ResponseInterface
    {
        $email = $request->getAttribute('email');
        $user = $this->userService->findUserByEmail($email);

        if (!$user) {
            throw new Exception(UserException::USER_NOT_FOUND, 404);
        }

        if ($user->getState()->getValue() == State::STATE_UNACTIVATED) {
            return new RedirectResponse('/user/resend-activation-mail/' . $email);
        }

        try {
            $link = $this->userService->generateEmailLink($user);
            $email = $user->getEmail();
            $token = $link->getToken();
            $env = $this->getSiteConfig()->getEnvironment();
            $mail = new EmailMessage();
            $mail->setTo($email);
            $mail->setSubject($this->getTranslator()->translate('email.forgotpass.subject', 'user') . $this->mailService->getSiteConfig()->getTitle() . '.');
            $mail->setTemplate('email.user::user_registration/reset_password');
            $mail->setViewData([
                'siteUrl' => $env->getSiteURL(),
                'logo' => $this->getSiteConfig()->getEmailLogo(),
                'address' => $this->getSiteConfig()->getAddress(),
                'resetLink' => '/user/reset-password/' . $email . '/' . $token,
            ]);
            $this->mailService->sendEmail($mail);
        } catch (Exception $e) {
            $this->view->message = [$e->getMessage(), 'danger'];

        }

        $body = $this->getView()->render('boneuser::forgot-password', ['logo' => $this->getLogo()]);

        return new HtmlResponse($body);
    }


    /**
     * @param ServerRequestInterface $request
     * @return ResponseInterface
     */
    public function resetPasswordAction(ServerRequestInterface $request): ResponseInterface
    {
        $email = $request->getAttribute('email');
        $token = $request->getAttribute('token');
        $form = new ResetPasswordForm('resetpass');
        $translator = $this->getTranslator();
        $params = [];
        $success = false;
        $user = $this->userService->findUserByEmail($email);

        if (!$user) {
            throw new Exception(UserException::USER_NOT_FOUND, 404);
        }

        try {
            $link = $this->userService->findEmailLink($email, $token);

            if ($request->getMethod() === 'POST') {
                $data = $request->getParsedBody();
                $form->populate($data);
                $form->populate(/** @scrutinizer ignore-type */ $data);

                if ($form->isValid()) {
                    $data = $form->getValues();

                    if ($data['password'] === $data['confirm']) {
                        $this->userService->changePassword($user, $data['password']);
                        $this->userService->deleteEmailLink($link);
                        $message = [$translator->translate('email.resetpass.success', 'user'), 'success'];
                        $success = true;
                        $this->getSession()->set('user', $user->getId());
                    } else {
                        $message = [$translator->translate('email.resetpass.nomatch', 'user'), 'danger'];
                        $form = new ResetPasswordForm('resetpass');
                    }
                }
            }
        } catch (EmailLinkException $e) {
            $message = [$e->getMessage(), 'danger'];
        } catch (Exception $e) {
            throw $e;
        }

        if (isset($message)) {
            $params['message'] = $message;
        }

        $params['success'] = $success;
        $params['form'] = $form;
        $params['logo'] = $this->getLogo();
        $body = $this->getView()->render('boneuser::reset-pass', $params);

        return new HtmlResponse($body);
    }

    /**
     * @param ServerRequestInterface $request
     * @return ResponseInterface
     */
    public function changePasswordAction(ServerRequestInterface $request): ResponseInterface
    {
        $user = $request->getAttribute('user');
        $form = new ResetPasswordForm('resetpass');
        $translator = $this->getTranslator();
        $message = null;
        $success = false;

        if ($request->getMethod() === 'POST') {
            $data = $request->getParsedBody();
            $form->populate($data);

            if ($form->isValid()) {
                $data = $form->getValues();

                if ($data['password'] === $data['confirm']) {
                    $this->userService->changePassword($user, $data['password']);
                    $message = [Icon::CHECK_CIRCLE . ' ' . $translator->translate('email.resetpass.success', 'user'), 'success'];
                    $success = true;
                } else {
                    $message = [Icon::WARNING . ' ' . $translator->translate('email.resetpass.nomatch', 'user'), 'danger'];
                    $form = new ResetPasswordForm('resetpass');
                }
            } else {
                $message = [Icon::WARNING . ' There was a problem with your form.', 'danger'];
            }
        }

        $params['success'] = $success;

        $params['form'] = $form;
        $params['logo'] = $this->getLogo();

        $body = $this->getView()->render('boneuser::change-pass', [
            'success' => $success,
            'form' => $form,
            'logo' => $this->getLogo(),
            'message' => $message
        ]);

        return new HtmlResponse($body);
    }

    /**
     * @param ServerRequestInterface $request
     * @return ResponseInterface
     */
    public function changeEmailAction(ServerRequestInterface $request): ResponseInterface
    {
        $user = $request->getAttribute('user');
        $form = new LoginForm('changeemail', $this->getTranslator());
        $form->getField('email')->setLabel('New email');
        $form->getField('submit')->setValue('Submit');
        $translator = $this->getTranslator();
        $params = [
            'form' => $form
        ];

        if ($request->getMethod() === 'POST') {
            $data = $request->getParsedBody();
            $form->populate($data);
            $message = null;

            if ($form->isValid()) {

                $newEmail = $form->getField('email')->getValue();
                $password = $form->getField('password')->getValue();
                $existing = $this->userService->findUserByEmail($newEmail);

                if ($existing) {
                    $message = [$translator->translate('email.changeemail.registered', 'user') . $this->getSiteConfig()->getTitle() . '.', 'danger'];
                } else {
                    if ($this->userService->checkPassword($user, $password)) {

                        try {

                            $link = $this->userService->generateEmailLink($user);
                            $email = $user->getEmail();
                            $token = $link->getToken();
                            $env = $this->getSiteConfig()->getEnvironment();
                            $mail = new EmailMessage();
                            $mail->setTo($email);
                            $mail->setSubject($translator->translate('email.changeemail.subject', 'user') . $this->mailService->getSiteConfig()->getTitle() . '.');
                            $mail->setTemplate('email.user::user_registration/change_email');
                            $mail->setViewData([
                                'siteUrl' => $env->getSiteURL(),
                                'logo' => $this->getSiteConfig()->getEmailLogo(),
                                'address' => $this->getSiteConfig()->getAddress(),
                                'resetLink' => '/user/reset-email/' . $email . '/' . $newEmail . '/' . $token,
                            ]);
                            $this->mailService->sendEmail($mail);
                            $message = [$translator->translate('email.changeemail.sent', 'user'), 'info'];
                            unset ($params['form']);

                        } catch (Exception $e) {
                            $message = [$translator->translate('email.changeemail.notsent', 'user') . $this->getSiteConfig()->getContactEmail() . '.', 'danger'];
                        }

                    } else {
                        $message = [$translator->translate('email.changeemail.wrongpass', 'user'), 'danger'];
                    }
                }
            }

            $params['message'] = $message;
        }

        $params['logo'] = $this->getLogo();
        $body = $this->getView()->render('boneuser::change-email', $params);

        return new LayoutResponse($body, 'layouts::admin');
    }

    /**
     * @param ServerRequestInterface $request
     * @return ResponseInterface
     */
    public function editProfileAction(ServerRequestInterface $request): ResponseInterface
    {
        $user = $request->getAttribute('user');
        $person = $user->getPerson();
        $image = $person->getImage();
        $form = new PersonForm('profile', $this->getTranslator());
        $array = $this->userService->getPersonSvc()->toArray($person);
        $form->populate($array);

        if ($request->getMethod() === 'POST') {
            $post = $request->getParsedBody();
            $form->populate($post);
            $form->populate(/** @scrutinizer ignore-type */ $post);

            if ($form->isValid()) {
                $data = $form->getValues();
                $data['image'] = $image;
                $dateFormat = $this->getSiteConfig()->getAttribute('i18n')['date_format'];
                $data['dob'] = DateTime::createFromFormat($dateFormat, $data['dob']);
                $data['country'] = CountryFactory::generate($data['country']);
                $this->userService->getPersonSvc()->populateFromArray($person, $data);
                $this->userService->saveUser($user);
            }
        }

        $body = $this->getView()->render('boneuser::edit-profile', [
            'person' => $person,
            'form' => $form->render(),
        ]);

        return new LayoutResponse($body, $this->adminLayout);
    }

    /**
     * @param ServerRequestInterface $requestApiController
     * @return ResponseInterface
     */
    public function resetEmailAction(ServerRequestInterface $request): ResponseInterface
    {
        $email = $request->getAttribute('email');
        $newEmail = $request->getAttribute('new-email');
        $token = $request->getAttribute('token');
        $translator = $this->getTranslator();

        try {
            $link = $this->userService->findEmailLink($email, $token);
            $user = $link->getUser();
            $user->setEmail($newEmail);
            $this->userService->saveUser($user);
            $this->userService->deleteEmailLink($link);
            $message = [$translator->translate('email.changeemail.success', 'user') . $newEmail . $translator->translate('email.changeemail.success2', 'user'), 'success'];
            SessionManager::getInstance()->set('user', $user->getId());
        } catch (EmailLinkException $e) {
            $message = [$e->getMessage(), 'danger'];
        }

        $body = $this->getView()->render('boneuser::reset-email', ['message' => $message, 'logo' => $this->getLogo()]);

        return new HtmlResponse($body);
    }
}

delboy1978uk / bone-user

Push — master ( e4b148...d70af7 )

BoneUserController::__construct() A

Complexity

Size

Duplication

Code Coverage

Importance

How to fix Many Parameters

Many Parameters

Duplication Side-by-Side

Filter issues like
