Bone\User\Http\Middleware\SessionAuth

Complexity

Total Complexity

6

Size/Duplication

Total Lines	52
Duplicated Lines	0 %

Test Coverage

Coverage

100%

Importance

Changes	4
Bugs	0	Features	0

2 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	5	1
A	process()	0	30	5

<?php

namespace Bone\User\Http\Middleware;

use Bone\Http\Response;
use Bone\Paseto\PasetoService;
use Bone\Server\SessionAwareInterface;
use Bone\Server\Traits\HasSessionTrait;
use Del\Exception\UserException;
use Del\Service\UserService;
use Del\SessionManager;
use Psr\Http\Message\ResponseInterface;
use Psr\Http\Message\ServerRequestInterface;
use Psr\Http\Server\MiddlewareInterface;
use Psr\Http\Server\RequestHandlerInterface;

class SessionAuth implements MiddlewareInterface, SessionAwareInterface
{
    use HasSessionTrait;

    /** @var UserService $userService */
    private $userService;

    /** @var PasetoService $pasetoService */
    private $pasetoService;

    public function __construct(SessionManager $sessionManager, UserService $userService, PasetoService $pasetoService)
    {
        $this->setSession($sessionManager);
        $this->userService = $userService;
        $this->pasetoService = $pasetoService;
    }

    /**
     * @param ServerRequestInterface $request
     * @param RequestHandlerInterface $handler
     * @return ResponseInterface
     */
    public function process(ServerRequestInterface $request, RequestHandlerInterface $handler): ResponseInterface
    {
        $cookies = $request->getCookieParams();
        $id = $this->getSession()->get('user');

        if (!$id && isset($cookies['resu'])) {
            $string = $cookies['resu'];
            $token = $this->pasetoService->decryptToken($string);
            $id = $token->getClaims()['user'];
            $this->getSession()->set('user', $id);
        }

        if ($id) {
            $user = $this->userService->findUserById($id);

It seems like $id can also be of type string; however, parameter $id of Del\Service\UserService::findUserById() does only seem to accept integer, maybe add an additional type check?

            $request = $request->withAttribute('user', $user);
            $response = $handler->handle($request);

            if ($response instanceof Response) {
                $response->setAttribute('user', $user);
            }

            $person = $user->getPerson();
            $person = $this->userService->getPersonSvc()->toArray($person);
            $userArray = $this->userService->toArray($user);

It seems like $user can also be of type null; however, parameter $user of Del\Service\UserService::toArray() does only seem to accept Del\Entity\UserInterface, maybe add an additional type check?

            $userArray['person'] = $person;

            return $response->withHeader('user', json_encode($userArray));
        }

        throw new UserException(UserException::UNAUTHORISED, 401);
    }
}