Bone\User\Http\Middleware\SessionAuth::process()

Complexity

Conditions	6
Paths	9

Size

Total Lines	35
Code Lines	22

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	20
CRAP Score	6.027

Importance

Changes	5
Bugs	0	Features	0

<?php
    public function process(ServerRequestInterface $request, RequestHandlerInterface $handler): ResponseInterface
    {
        $cookies = $request->getCookieParams();
        $id = $this->getSession()->get('user');

        if (!$id && isset($cookies['resu'])) {
            $string = $cookies['resu'];

            try {
                $token = $this->pasetoService->decryptToken($string);
                $id = $token->getClaims()['user'];
                $this->getSession()->set('user', $id);
            } catch (Exception $e) {
                return new RedirectResponse($this->redirectUrl);
            }
        }

        if ($id) {
            $user = $this->userService->findUserById($id);

It seems like $id can also be of type string; however, parameter $id of Del\Service\UserService::findUserById() does only seem to accept integer, maybe add an additional type check?

            $request = $request->withAttribute('user', $user);
            $response = $handler->handle($request);

            if ($response instanceof Response) {
                $response->setAttribute('user', $user);
            }

            $person = $user->getPerson();
            $person = $this->userService->getPersonSvc()->toArray($person);
            $userArray = $this->userService->toArray($user);

It seems like $user can also be of type null; however, parameter $user of Del\Service\UserService::toArray() does only seem to accept Del\Entity\UserInterface, maybe add an additional type check?

            $userArray['person'] = $person;

            return $response->withHeader('user', json_encode($userArray));
        }

        throw new UserException(UserException::UNAUTHORISED, 401);
    }
}