delboy1978uk / bone-social-auth

src/Service/SocialAuthService.php

<?php declare(strict_types=1);

namespace Bone\SocialAuth\Service;

use Bone\Server\SessionAwareInterface;
use Bone\Server\Traits\HasSessionTrait;
use Bone\SocialAuth\Provider\CustomOauth2Provider;

The type Bone\SocialAuth\Provider\CustomOauth2Provider was not found. Maybe you did not declare it correctly or list all dependencies?

use DateTime;
use Del\Entity\User;
use Del\Factory\CountryFactory;
use Del\Person\Entity\Person;
use Del\Service\UserService;
use Del\Value\User\State;
use Exception;
use Hybridauth\Hybridauth;
use Hybridauth\Adapter\AdapterInterface;
use Hybridauth\User\Profile;

class SocialAuthService implements SessionAwareInterface
{
    use HasSessionTrait;

    /** @var array $config */
    private $config;

    /** @var array $customProviderConfigs */
    private $customProviderConfigs = [];

    /** @var UserService $userService */
    private $userService;

    /** @var string $uploadsDir */
    private $uploadsDir;

    /** @var string $imgDir */
    private $imgDir;

    /** @var SocialAuthAdapterFactory $factory */
    private $factory;

    /**
     * SocialAuthService constructor.
     * @param array $config
     */
    public function __construct(array $config, UserService $userService, string $uploadsDir, string $imgDir, SocialAuthAdapterFactory $factory)
    {
        $this->config = $config;
        $this->userService = $userService;
        $this->uploadsDir = $uploadsDir;
        $this->imgDir = $imgDir;
        $this->factory = $factory;

        if (array_key_exists('custom', $this->config)) {
            $this->customProviderConfigs = $this->config['custom']['providers'];
            unset ($this->config['custom']);
        }
    }

    /**
     * @param string $provider
     * @return \Hybridauth\Adapter\AdapterInterface
     * @throws \Hybridauth\Exception\InvalidArgumentException
     * @throws \Hybridauth\Exception\UnexpectedValueException
     */
    public function getAuthAdapter(string $provider): AdapterInterface
    {
        if (array_key_exists($provider, $this->customProviderConfigs)) {
            $this->config['providers'][$provider] = $this->customProviderConfigs[$provider];
        }

        if (array_key_exists($provider, $this->config['providers'])) {
            return $this->getAdapter($this->config, $provider);
        }

        throw new Exception('SocialAuth Adapter not found', 404);
    }

    /**
     * @param array $config
     * @param string $provider
     * @return AdapterInterface
     */
    private function getAdapter(array $config, string $provider): AdapterInterface
    {
        $config['callback'] .= '/' . strtolower($provider);
        $hybridauth = $this->factory->factory($config);
        $adapter = $hybridauth->authenticate($provider);

        return $adapter;
    }

    /**
     * @param Profile $profile
     * @return User
     */
    public function logInUser(Profile $profile): User
    {
        $email = $profile->email;

        if($user = $this->userService->findUserByEmail($email)) {

It seems like $email can also be of type null; however, parameter $email of Del\Service\UserService::findUserByEmail() does only seem to accept string, maybe add an additional type check?

            $user->setLastLogin(new DateTime());
            $this->userService->saveUser($user);
        }

        if (!$user) {
            $user = $this->createUser($profile);
        }

        $this->session->set('user', $user->getId());

        return $user;

The expression return $user could return the type Del\Entity\UserInterface which includes types incompatible with the type-hinted return Del\Entity\User. Consider adding an additional type-check to rule them out.

    }

    /**
     * @param Profile $profile
     * @return User
     * @throws \Doctrine\ORM\OptimisticLockException
     */
    private function createUser(Profile $profile): User
    {
        $now = new DateTime();
        $user = new User();
        $person = new Person();

        $user->setEmail($profile->email);

It seems like $profile->email can also be of type null; however, parameter $email of Del\Entity\BaseUser::setEmail() does only seem to accept string, maybe add an additional type check?

        $user->setLastLogin($now);
        $user->setRegistrationDate($now);
        $user->setState(new State(State::STATE_ACTIVATED));
        $user->setPerson($person);

        if ($profile->photoURL) {
            $contents = file_get_contents($profile->photoURL);
            $file = $this->imgDir . md5(microtime()) . '.jpg';
            file_put_contents($this->uploadsDir . $file, $contents);
            $person->setImage($file);
        }

        $person->setFirstname($profile->firstName);
        $person->setLastname($profile->lastName);

        $this->userService->getPersonSvc()->savePerson($person);
        $this->userService->changePassword($user, microtime()); // this saves user too

        return $user;
    }
}