I18nPackage::getGlobalMiddleware() - Code Metrics - Inspection of "use global middleware registration" - delboy1978uk/bone-i18n - Measure and Improve Code Quality continuously with Scrutinizer

Test Failed

Push — master ( 677242...ecef3d )

by Derek Stephen

created 2020-11-23 13:13 UTC

I18nPackage::getGlobalMiddleware() A

↳ Parent: I18nPackage

Complexity

Conditions	3
Paths	2

Size

Total Lines	4
Code Lines	2

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	0
CRAP Score	12

Importance

Changes

Metric	Value
eloc	2
c	0
b	0
f	0
dl	0
loc	4
ccs	0
cts	0
cp	0
rs	10
cc	3
nc	2
nop	1
crap	12

<?php declare(strict_types=1);

namespace Bone\I18n;

use Barnacle\Container;
use Barnacle\Exception\NotFoundException;
use Barnacle\RegistrationInterface;
use Bone\Http\GlobalMiddlewareRegistrationInterface;
filter:
    dependency_paths: ["lib/*"]
use Bone\Http\Middleware\Stack;
use Bone\I18n\Http\Middleware\I18nMiddleware;
use Bone\I18n\View\Extension\LocaleLink;
use Bone\I18n\View\Extension\Translate;
use Bone\View\ViewEngine;
use Bone\I18n\Service\TranslatorFactory;
use Laminas\I18n\Translator\Translator;
use Locale;

class I18nPackage implements RegistrationInterface, GlobalMiddlewareRegistrationInterface
{
    /**
     * @param Container $c
     * @throws Exception
     */
    public function addToContainer(Container $c)
    {
        if ($c->has('i18n')) {
            $i18n = $c->get('i18n');
            $factory = new TranslatorFactory();
            $translator = $factory->createTranslator($i18n);
            $engine = $c->get(ViewEngine::class);
            $engine->loadExtension(new Translate($translator));
            $engine->loadExtension(new LocaleLink($i18n['enabled']));
            $defaultLocale = $i18n['default_locale'] ?: 'en_GB';
            $translator->setLocale($defaultLocale);
            Locale::setDefault($defaultLocale);
            $c[Translator::class] = $translator;
        } else {
            throw new NotFoundException('I18nPackage is registered but there is no i18n config. See the 
            delboy1978uk/bone-i18n README.', 418);
        }
    }

    /**
     * @param Container $c
     * @return array
     */
    public function getMiddleware(Container $c): array
    {
        if ($c->has('i18n')) {
            $i18n = $c->get('i18n');
            $translator = $c->get(Translator::class);
            $i18nMiddleware = new I18nMiddleware($translator, $i18n['supported_locales'], $i18n['default_locale'], $i18n['enabled']);

            return [$i18nMiddleware];
        }

        return [];
    }

    /**
     * @return array
     */
    public function getGlobalMiddleware(Container $c): array
    {
        if ($c->has('i18n') && $c->get('i18n')['enabled']) {
            return [I18nMiddleware::class];
        }
interface ReturnsInt {
    public function returnsIntHinted(): int;
}

class MyClass implements ReturnsInt {
    public function returnsIntHinted(): int
    {
        if (foo()) {
            return 123;
        }
        // here: null is implicitly returned
    }
}
    }
}


1		<?php declare(strict_types=1);
2
3		namespace Bone\I18n;
4
5		use Barnacle\Container;
6		use Barnacle\Exception\NotFoundException;
7		use Barnacle\RegistrationInterface;
8		use Bone\Http\GlobalMiddlewareRegistrationInterface;
		0 ignored issues – show Bug introduced 2020-11-23 13:21 UTC by Report Bug Copy Issue Report The type `Bone\Http\GlobalMiddlewareRegistrationInterface` was not found. Maybe you did not declare it correctly or list all dependencies? The issue could also be caused by a filter entry in the build configuration. If the path has been excluded in your configuration, e.g. `excluded_paths: ["lib/"]`, you can move it to the dependency path list as follows: filter: dependency_paths: ["lib/"] For further information see https://scrutinizer-ci.com/docs/tools/php/php-scrutinizer/#list-dependency-paths Loading history...
9		use Bone\Http\Middleware\Stack;
10		use Bone\I18n\Http\Middleware\I18nMiddleware;
11		use Bone\I18n\View\Extension\LocaleLink;
12		use Bone\I18n\View\Extension\Translate;
13		use Bone\View\ViewEngine;
14		use Bone\I18n\Service\TranslatorFactory;
15		use Laminas\I18n\Translator\Translator;
16		use Locale;
17
18		class I18nPackage implements RegistrationInterface, GlobalMiddlewareRegistrationInterface
19		{
20		/**
21		* @param Container $c
22		* @throws Exception
23		*/
24	5	public function addToContainer(Container $c)
25		{
26	5	if ($c->has('i18n')) {
27	4	$i18n = $c->get('i18n');
28	4	$factory = new TranslatorFactory();
29	4	$translator = $factory->createTranslator($i18n);
30	4	$engine = $c->get(ViewEngine::class);
31	4	$engine->loadExtension(new Translate($translator));
32	4	$engine->loadExtension(new LocaleLink($i18n['enabled']));
33	4	$defaultLocale = $i18n['default_locale'] ?: 'en_GB';
34	4	$translator->setLocale($defaultLocale);
35	4	Locale::setDefault($defaultLocale);
36	4	$c[Translator::class] = $translator;
37		} else {
38	1	throw new NotFoundException('I18nPackage is registered but there is no i18n config. See the
39	1	delboy1978uk/bone-i18n README.', 418);
40		}
41	4	}
42
43		/**
44		* @param Container $c
45		* @return array
46	4	*/
47		public function getMiddleware(Container $c): array
48	4	{
49	4	if ($c->has('i18n')) {
50	4	$i18n = $c->get('i18n');
51	4	$translator = $c->get(Translator::class);
52	4	$i18nMiddleware = new I18nMiddleware($translator, $i18n['supported_locales'], $i18n['default_locale'], $i18n['enabled']);
53
54	4	return [$i18nMiddleware];
55		}
56
57		return [];
58		}
59
60		/**
61		* @return array
62		*/
63		public function getGlobalMiddleware(Container $c): array
64		{
65		if ($c->has('i18n') && $c->get('i18n')['enabled']) {
66		return [I18nMiddleware::class];
67		}
		0 ignored issues – show Bug Best Practice introduced 2020-11-23 13:21 UTC by Report Bug Copy Issue Report The function implicitly returns `null` when the `if` condition on line 65 is `false`. This is incompatible with the type-hinted return `array`. Consider adding a return statement or allowing `null` as return value. For hinted functions/methods where all return statements with the correct type are only reachable via conditions, ?null? gets implicitly returned which may be incompatible with the hinted type. Let?s take a look at an example: interface ReturnsInt { public function returnsIntHinted(): int; } class MyClass implements ReturnsInt { public function returnsIntHinted(): int { if (foo()) { return 123; } // here: null is implicitly returned } } Loading history...
68		}
69		}
70

delboy1978uk / bone-i18n

Push — master ( 677242...ecef3d )

I18nPackage::getGlobalMiddleware() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like