Issues in BtcE.php (master) - Issues in master - delboy1978uk/BTCExchange - Measure and Improve Code Quality continuously with Scrutinizer

Issues (7)

Security Analysis no request data

Cross-Site Scripting

Cross-Site Scripting enables an attacker to inject code into the response of a web-request that is viewed by other users. It can for example be used to bypass access controls, or even to take over other users' accounts.

File Exposure

File Exposure allows an attacker to gain access to local files that he should not be able to access. These files can for example include database credentials, or other configuration files.

File Manipulation

File Manipulation enables an attacker to write custom data to files. This potentially leads to injection of arbitrary code on the server.

Object Injection

Object Injection enables an attacker to inject an object into PHP code, and can lead to arbitrary code execution, file exposure, or file manipulation attacks.

Code Injection

Code Injection enables an attacker to execute arbitrary code on the server.

Response Splitting

Response Splitting can be used to send arbitrary responses.

File Inclusion

File Inclusion enables an attacker to inject custom files into PHP's file loading mechanism, either explicitly passed to include, or for example via PHP's auto-loading mechanism.

Command Injection

Command Injection enables an attacker to inject a shell command that is execute with the privileges of the web-server. This can be used to expose sensitive data, or gain access of your server.

SQL Injection

SQL Injection enables an attacker to execute arbitrary SQL code on your database server gaining access to user data, or manipulating user data.

XPath Injection

XPath Injection enables an attacker to modify the parts of XML document that are read. If that XML document is for example used for authentication, this can lead to further vulnerabilities similar to SQL Injection.

LDAP Injection

LDAP Injection enables an attacker to inject LDAP statements potentially granting permission to run unauthorized queries, or modify content inside the LDAP tree.

Header Injection

Other Vulnerability

This category comprises other attack vectors such as manipulating the PHP runtime, loading custom extensions, freezing the runtime, or similar.

Regex Injection

Regex Injection enables an attacker to execute arbitrary code in your PHP process.

XML Injection

XML Injection enables an attacker to read files on your local filesystem including configuration files, or can be abused to freeze your web-server process.

Variable Injection

Variable Injection enables an attacker to overwrite program variables with custom data, and can lead to further vulnerabilities.

Unfortunately, the security analysis is currently not available for your project. If you are a non-commercial open-source project, please contact support to gain access.

src/Exchange/BtcE.php (2 issues)

Labels

Severity

Minor 2

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php

namespace Del\Exchange;

use GuzzleHttp\Client;

class BtcE extends ExchangeAbstract
{
    private $nonce = false;


    /**
     * @param $uri
     * @param array $params
     * @return mixed
     * @throws \Exception
     */
    public function send($uri, array $params = [])
    {
        if(!$this->nonce) {

            $nonce = explode(' ', microtime());
            $this->nonce = + $nonce[1].($nonce[0] * 1000000);
$answer = 42;

$correct = false;

$correct = (bool) $answer;
            $this->nonce = substr($this->nonce,5);
$answer = 42;

$correct = false;

$correct = (bool) $answer;

            $this->nonce = explode(' ', microtime())[1];
//            $this->nonce = (int) 10000 * microtime(true);
        } else {
            $this->nonce ++ ;
        }


        $params['nonce'] = $this->nonce;
        $params['method'] = $uri;

        // generate the POST data string
        $post_data = http_build_query($params, '', '&');
        $sign = hash_hmac('sha512', $post_data, $this->config->getSecret());



        $headers = [
            'Sign: '.$sign,
            'Key: '.$this->config->getKey(),
        ];


        static $ch = null;
        if (is_null($ch)) {
            $ch = curl_init();
            curl_setopt($ch, CURLOPT_RETURNTRANSFER, true);
            curl_setopt($ch, CURLOPT_USERAGENT, 'Mozilla/4.0 (compatible; BTCE PHP client; '.php_uname('s').'; PHP/'.phpversion().')');
        }
        curl_setopt($ch, CURLOPT_URL, 'https://wex.nz/tapi/');
        curl_setopt($ch, CURLOPT_POSTFIELDS, $post_data);
        curl_setopt($ch, CURLOPT_HTTPHEADER, $headers);
        curl_setopt($ch, CURLOPT_SSL_VERIFYHOST, 0);
        curl_setopt($ch, CURLOPT_SSL_VERIFYPEER, 0);

        // run the query
        $res = curl_exec($ch);
        if ($res === false) throw new \Exception('Could not get reply: '.curl_error($ch));
        $dec = json_decode($res, true);
        if (!$dec) throw new \Exception('Invalid data received, please make sure connection is working and requested API exists');
        if($dec['success'] == 0) {
            throw new \Exception($dec['error']);
        }
        return $dec['return'];

    }

    /**
     *
     */
    public function setClient()
    {
        $this->client = new Client(['base_uri' => 'https://wex.nz/tapi/']);
    }

    /**
     * @param $btc
     * @param $price
     * @return mixed
     * @throws \Exception
     */
    public function buyOrder($btc, $price)
    {
        return $this->send('Trade',[
            'pair' => 'btc_usd',
            'type' => 'buy',
            'rate' => $price,
            'amount' => $btc
        ]);
    }

    /**
     * @param $btc
     * @param $price
     * @return mixed
     * @throws \Exception
     */
    public function sellOrder($btc, $price)
    {
        return $this->send('Trade',[
            'pair' => 'btc_usd',
            'type' => 'sell',
            'rate' => $price,
            'amount' => $btc
        ]);
    }

    /**
     * @return mixed
     * @throws \Exception
     */
    public function getInfo()
    {
        return $this->send('getInfo');
    }

    /**
     * @return mixed
     */
    public function getTicker()
    {
        return json_decode($this->client->get('https://wex.nz/api/3/ticker/btc_usd')->getBody()->getContents(), true);
    }


    /**
     * @return array
     */
    public function getOrderBook($pair = 'btc_usd')
    {
        return json_decode($this->client->get('https://wex.nz/api/3/depth/' . $pair)->getBody()->getContents(), true);
    }


    /**
     * @return mixed
     * @throws \Exception
     */
    public function getOrders()
    {
        return $this->send('ActiveOrders',[
            'pair' => 'btc_usd'
        ]);
    }

    /**
     * @return mixed
     * @throws \Exception
     */
    public function getTransactionHistory()
    {
        return $this->send('TransHistory',[]);
    }

    /**
     * @return mixed
     * @throws \Exception
     */
    public function getTradeHistory()
    {
        return $this->send('TradeHistory',[]);
    }


    /**
     * @param $order_id
     * @return mixed
     * @throws \Exception
     */
    public function cancelOrder($order_id)
    {
        return $this->send('CancelOrder',[
            'order_id' => $order_id
        ]);
    }


}

1		<?php
2
3		namespace Del\Exchange;
4
5		use GuzzleHttp\Client;
6
7		class BtcE extends ExchangeAbstract
8		{
9		private $nonce = false;
10
11
12		/**
13		* @param $uri
14		* @param array $params
15		* @return mixed
16		* @throws \Exception
17		*/
18	7	public function send($uri, array $params = [])
19		{
20	7	if(!$this->nonce) {
21
22	7	$nonce = explode(' ', microtime());
23	7	$this->nonce = + $nonce[1].($nonce[0] * 1000000);
		0 ignored issues – show Documentation Bug introduced 2018-01-09 19:40 UTC by Report Bug Copy Issue Report Show Similar Issues like this The property `$nonce` was declared of type `boolean`, but `+$nonce[1] . $nonce[0] * 1000000` is of type `string`. Maybe add a type cast? This check looks for assignments to scalar types that may be of the wrong type. To ensure the code behaves as expected, it may be a good idea to add an explicit type cast. $answer = 42; $correct = false; $correct = (bool) $answer; Loading history...
24	7	$this->nonce = substr($this->nonce,5);
		0 ignored issues – show Documentation Bug introduced 2018-01-09 19:40 UTC by Report Bug Copy Issue Report Show Similar Issues like this The property `$nonce` was declared of type `boolean`, but `substr($this->nonce, 5)` is of type `string`. Maybe add a type cast? This check looks for assignments to scalar types that may be of the wrong type. To ensure the code behaves as expected, it may be a good idea to add an explicit type cast. $answer = 42; $correct = false; $correct = (bool) $answer; Loading history...
25
26	7	$this->nonce = explode(' ', microtime())[1];
27		// $this->nonce = (int) 10000 * microtime(true);
28		} else {
29		$this->nonce ++ ;
30		}
31
32
33	7	$params['nonce'] = $this->nonce;
34	7	$params['method'] = $uri;
35
36		// generate the POST data string
37	7	$post_data = http_build_query($params, '', '&');
38	7	$sign = hash_hmac('sha512', $post_data, $this->config->getSecret());
39
40
41
42		$headers = [
43	7	'Sign: '.$sign,
44	7	'Key: '.$this->config->getKey(),
45		];
46
47
48	7	static $ch = null;
49	7	if (is_null($ch)) {
50	1	$ch = curl_init();
51	1	curl_setopt($ch, CURLOPT_RETURNTRANSFER, true);
52	1	curl_setopt($ch, CURLOPT_USERAGENT, 'Mozilla/4.0 (compatible; BTCE PHP client; '.php_uname('s').'; PHP/'.phpversion().')');
53		}
54	7	curl_setopt($ch, CURLOPT_URL, 'https://wex.nz/tapi/');
55	7	curl_setopt($ch, CURLOPT_POSTFIELDS, $post_data);
56	7	curl_setopt($ch, CURLOPT_HTTPHEADER, $headers);
57	7	curl_setopt($ch, CURLOPT_SSL_VERIFYHOST, 0);
58	7	curl_setopt($ch, CURLOPT_SSL_VERIFYPEER, 0);
59
60		// run the query
61	7	$res = curl_exec($ch);
62	7	if ($res === false) throw new \Exception('Could not get reply: '.curl_error($ch));
63	7	$dec = json_decode($res, true);
64	7	if (!$dec) throw new \Exception('Invalid data received, please make sure connection is working and requested API exists');
65	7	if($dec['success'] == 0) {
66	7	throw new \Exception($dec['error']);
67		}
68		return $dec['return'];
69
70		}
71
72		/**
73		*
74		*/
75	9	public function setClient()
76		{
77	9	$this->client = new Client(['base_uri' => 'https://wex.nz/tapi/']);
78	9	}
79
80		/**
81		* @param $btc
82		* @param $price
83		* @return mixed
84		* @throws \Exception
85		*/
86	1	public function buyOrder($btc, $price)
87		{
88	1	return $this->send('Trade',[
89	1	'pair' => 'btc_usd',
90	1	'type' => 'buy',
91	1	'rate' => $price,
92	1	'amount' => $btc
93		]);
94		}
95
96		/**
97		* @param $btc
98		* @param $price
99		* @return mixed
100		* @throws \Exception
101	1	*/
102		public function sellOrder($btc, $price)
103	1	{
104	1	return $this->send('Trade',[
105	1	'pair' => 'btc_usd',
106	1	'type' => 'sell',
107	1	'rate' => $price,
108		'amount' => $btc
109		]);
110		}
111
112		/**
113		* @return mixed
114		* @throws \Exception
115	1	*/
116		public function getInfo()
117	1	{
118		return $this->send('getInfo');
119		}
120
121		/**
122		* @return mixed
123	1	*/
124		public function getTicker()
125	1	{
126		return json_decode($this->client->get('https://wex.nz/api/3/ticker/btc_usd')->getBody()->getContents(), true);
127		}
128
129
130	1	/**
131		* @return array
132	1	*/
133	1	public function getOrderBook($pair = 'btc_usd')
134		{
135		return json_decode($this->client->get('https://wex.nz/api/3/depth/' . $pair)->getBody()->getContents(), true);
136		}
137
138	1
139		/**
140	1	* @return mixed
141		* @throws \Exception
142		*/
143	1	public function getOrders()
144		{
145	1	return $this->send('ActiveOrders',[
146		'pair' => 'btc_usd'
147		]);
148		}
149
150	1	/**
151		* @return mixed
152	1	* @throws \Exception
153	1	*/
154		public function getTransactionHistory()
155		{
156		return $this->send('TransHistory',[]);
157		}
158
159		/**
160		* @return mixed
161		* @throws \Exception
162		*/
163		public function getTradeHistory()
164		{
165		return $this->send('TradeHistory',[]);
166		}
167
168
169		/**
170		* @param $order_id
171		* @return mixed
172		* @throws \Exception
173		*/
174		public function cancelOrder($order_id)
175		{
176		return $this->send('CancelOrder',[
177		'order_id' => $order_id
178		]);
179		}
180
181
182		}

delboy1978uk / BTCExchange

Issues (7)

Security Analysis no request data

src/Exchange/BtcE.php (2 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like