BtcE::getOrders() - Code Metrics - Inspection of "get order book method" - delboy1978uk/BTCExchange - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( dbc3c2...b8cb7c )

by Derek Stephen

created 2018-01-10 00:48 UTC

BtcE::getOrders() A

↳ Parent: BtcE

Complexity

Conditions	1
Paths	1

Size

Total Lines	6
Code Lines	3

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	2
CRAP Score	1

Importance

Changes

Metric	Value
dl	0
loc	6
ccs	2
cts	2
cp	1
rs	9.4285
c	0
b	0
f	0
cc	1
eloc	3
nc	1
nop	0
crap	1

<?php

namespace Del\Exchange;

use GuzzleHttp\Client;

class BtcE extends ExchangeAbstract
{
    private $nonce = false;


    /**
     * @param $uri
     * @param array $params
     * @return mixed
     * @throws \Exception
     */
    public function send($uri, array $params = [])
    {
        if(!$this->nonce) {

            $nonce = explode(' ', microtime());
            $this->nonce = + $nonce[1].($nonce[0] * 1000000);
$answer = 42;

$correct = false;

$correct = (bool) $answer;
            $this->nonce = substr($this->nonce,5);
$answer = 42;

$correct = false;

$correct = (bool) $answer;

            $this->nonce = explode(' ', microtime())[1];
//            $this->nonce = (int) 10000 * microtime(true);

        } else {
            $this->nonce ++ ;
        }


        $params['nonce'] = $this->nonce;
        $params['method'] = $uri;

        // generate the POST data string
        $post_data = http_build_query($params, '', '&');
        $sign = hash_hmac('sha512', $post_data, $this->config->getSecret());



        $headers = [
            'Sign: '.$sign,
            'Key: '.$this->config->getKey(),
        ];


        static $ch = null;
        if (is_null($ch)) {
            $ch = curl_init();
            curl_setopt($ch, CURLOPT_RETURNTRANSFER, true);
            curl_setopt($ch, CURLOPT_USERAGENT, 'Mozilla/4.0 (compatible; BTCE PHP client; '.php_uname('s').'; PHP/'.phpversion().')');
        }
        curl_setopt($ch, CURLOPT_URL, 'https://wex.nz/tapi/');
        curl_setopt($ch, CURLOPT_POSTFIELDS, $post_data);
        curl_setopt($ch, CURLOPT_HTTPHEADER, $headers);
        curl_setopt($ch, CURLOPT_SSL_VERIFYHOST, 0);
        curl_setopt($ch, CURLOPT_SSL_VERIFYPEER, 0);

        // run the query
        $res = curl_exec($ch);
        if ($res === false) throw new \Exception('Could not get reply: '.curl_error($ch));
        $dec = json_decode($res, true);
        if (!$dec) throw new \Exception('Invalid data received, please make sure connection is working and requested API exists');
        if($dec['success'] == 0) {
            throw new \Exception($dec['error']);
        }
        return $dec['return'];

    }

    /**
     *
     */
    public function setClient()
    {
        $this->client = new Client(['base_uri' => 'https://wex.nz/tapi/']);
    }

    /**
     * @param $btc
     * @param $price
     * @return mixed
     * @throws \Exception
     */
    public function buyOrder($btc, $price)

    {
        return $this->send('Trade',[
            'pair' => 'btc_usd',
            'type' => 'buy',
            'rate' => $price,
            'amount' => $btc
        ]);
    }

    /**
     * @param $btc
     * @param $price
     * @return mixed
     * @throws \Exception
     */
    public function sellOrder($btc, $price)

    {
        return $this->send('Trade',[
            'pair' => 'btc_usd',
            'type' => 'sell',
            'rate' => $price,
            'amount' => $btc
        ]);
    }

    /**
     * @return mixed
     * @throws \Exception
     */
    public function getInfo()
    {
        return $this->send('getInfo');
    }

    /**
     * @return mixed
     */
    public function getTicker()
    {
        return json_decode($this->client->get('https://wex.nz/api/3/ticker/btc_usd')->getBody()->getContents(), true);
    }


    /**
     * @return array
     */
    public function getOrderBook($pair = 'btc_usd')
    {
        return json_decode($this->client->get('https://wex.nz/api/3/trades/' . $pair)->getBody()->getContents(), true);
    }


    /**
     * @return mixed
     * @throws \Exception
     */
    public function getOrders()
    {
        return $this->send('ActiveOrders',[
            'pair' => 'btc_usd'
        ]);
    }

    /**
     * @return mixed
     * @throws \Exception
     */
    public function getTransactionHistory()
    {
        return $this->send('TransHistory',[]);
    }

    /**
     * @return mixed
     * @throws \Exception
     */
    public function getTradeHistory()
    {
        return $this->send('TradeHistory',[]);
    }


    /**
     * @param $order_id
     * @return mixed
     * @throws \Exception
     */
    public function cancelOrder($order_id)
    {
        return $this->send('CancelOrder',[
            'order_id' => $order_id
        ]);
    }


}

1			<?php
2
3			namespace Del\Exchange;
4
5			use GuzzleHttp\Client;
6
7			class BtcE extends ExchangeAbstract
8			{
9			private $nonce = false;
10
11
12			/**
13			* @param $uri
14			* @param array $params
15			* @return mixed
16			* @throws \Exception
17			*/
18	7		public function send($uri, array $params = [])
19			{
20	7		if(!$this->nonce) {
21
22	7		$nonce = explode(' ', microtime());
23	7		$this->nonce = + $nonce[1].($nonce[0] * 1000000);
			0 ignored issues – show Documentation Bug introduced 2018-01-09 19:40 UTC by Report Bug Copy Issue Report The property `$nonce` was declared of type `boolean`, but `+$nonce[1] . $nonce[0] * 1000000` is of type `string`. Maybe add a type cast? This check looks for assignments to scalar types that may be of the wrong type. To ensure the code behaves as expected, it may be a good idea to add an explicit type cast. $answer = 42; $correct = false; $correct = (bool) $answer; Loading history...
24	7		$this->nonce = substr($this->nonce,5);
			0 ignored issues – show Documentation Bug introduced 2018-01-09 19:40 UTC by Report Bug Copy Issue Report The property `$nonce` was declared of type `boolean`, but `substr($this->nonce, 5)` is of type `string`. Maybe add a type cast? This check looks for assignments to scalar types that may be of the wrong type. To ensure the code behaves as expected, it may be a good idea to add an explicit type cast. $answer = 42; $correct = false; $correct = (bool) $answer; Loading history...
25
26	7		$this->nonce = explode(' ', microtime())[1];
27			// $this->nonce = (int) 10000 * microtime(true);
			0 ignored issues – show Unused Code Comprehensibility introduced 2018-01-09 19:40 UTC by Report Bug Copy Issue Report `45%` of this comment could be valid code. Did you maybe forget this after debugging? Sometimes obsolete code just ends up commented out instead of removed. In this case it is better to remove the code once you have checked you do not need it. The code might also have been commented out for debugging purposes. In this case it is vital that someone uncomments it again or your project may behave in very unexpected ways in production. This check looks for comments that seem to be mostly valid code and reports them. Loading history...
28			} else {
29			$this->nonce ++ ;
30			}
31
32
33	7		$params['nonce'] = $this->nonce;
34	7		$params['method'] = $uri;
35
36			// generate the POST data string
37	7		$post_data = http_build_query($params, '', '&');
38	7		$sign = hash_hmac('sha512', $post_data, $this->config->getSecret());
39
40
41
42			$headers = [
43	7		'Sign: '.$sign,
44	7		'Key: '.$this->config->getKey(),
45			];
46
47
48	7		static $ch = null;
49	7		if (is_null($ch)) {
50	1		$ch = curl_init();
51	1		curl_setopt($ch, CURLOPT_RETURNTRANSFER, true);
52	1		curl_setopt($ch, CURLOPT_USERAGENT, 'Mozilla/4.0 (compatible; BTCE PHP client; '.php_uname('s').'; PHP/'.phpversion().')');
53			}
54	7		curl_setopt($ch, CURLOPT_URL, 'https://wex.nz/tapi/');
55	7		curl_setopt($ch, CURLOPT_POSTFIELDS, $post_data);
56	7		curl_setopt($ch, CURLOPT_HTTPHEADER, $headers);
57	7		curl_setopt($ch, CURLOPT_SSL_VERIFYHOST, 0);
58	7		curl_setopt($ch, CURLOPT_SSL_VERIFYPEER, 0);
59
60			// run the query
61	7		$res = curl_exec($ch);
62	7		if ($res === false) throw new \Exception('Could not get reply: '.curl_error($ch));
63	7		$dec = json_decode($res, true);
64	7		if (!$dec) throw new \Exception('Invalid data received, please make sure connection is working and requested API exists');
65	7		if($dec['success'] == 0) {
66	7		throw new \Exception($dec['error']);
67			}
68			return $dec['return'];
69
70			}
71
72			/**
73			*
74			*/
75	9		public function setClient()
76			{
77	9		$this->client = new Client(['base_uri' => 'https://wex.nz/tapi/']);
78	9		}
79
80			/**
81			* @param $btc
82			* @param $price
83			* @return mixed
84			* @throws \Exception
85			*/
86	1	View Code Duplication	public function buyOrder($btc, $price)
			0 ignored issues – show Duplication introduced 2018-01-09 19:40 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
87			{
88	1		return $this->send('Trade',[
89	1		'pair' => 'btc_usd',
90	1		'type' => 'buy',
91	1		'rate' => $price,
92	1		'amount' => $btc
93			]);
94			}
95
96			/**
97			* @param $btc
98			* @param $price
99			* @return mixed
100			* @throws \Exception
101	1		*/
102		View Code Duplication	public function sellOrder($btc, $price)
			0 ignored issues – show Duplication introduced 2018-01-09 19:40 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
103	1		{
104	1		return $this->send('Trade',[
105	1		'pair' => 'btc_usd',
106	1		'type' => 'sell',
107	1		'rate' => $price,
108			'amount' => $btc
109			]);
110			}
111
112			/**
113			* @return mixed
114			* @throws \Exception
115	1		*/
116			public function getInfo()
117	1		{
118			return $this->send('getInfo');
119			}
120
121			/**
122			* @return mixed
123	1		*/
124			public function getTicker()
125	1		{
126			return json_decode($this->client->get('https://wex.nz/api/3/ticker/btc_usd')->getBody()->getContents(), true);
127			}
128
129
130	1		/**
131			* @return array
132	1		*/
133	1		public function getOrderBook($pair = 'btc_usd')
134			{
135			return json_decode($this->client->get('https://wex.nz/api/3/trades/' . $pair)->getBody()->getContents(), true);
136			}
137
138	1
139			/**
140	1		* @return mixed
141			* @throws \Exception
142			*/
143	1		public function getOrders()
144			{
145	1		return $this->send('ActiveOrders',[
146			'pair' => 'btc_usd'
147			]);
148			}
149
150	1		/**
151			* @return mixed
152	1		* @throws \Exception
153	1		*/
154			public function getTransactionHistory()
155			{
156			return $this->send('TransHistory',[]);
157			}
158
159			/**
160			* @return mixed
161			* @throws \Exception
162			*/
163			public function getTradeHistory()
164			{
165			return $this->send('TradeHistory',[]);
166			}
167
168
169			/**
170			* @param $order_id
171			* @return mixed
172			* @throws \Exception
173			*/
174			public function cancelOrder($order_id)
175			{
176			return $this->send('CancelOrder',[
177			'order_id' => $order_id
178			]);
179			}
180
181
182			}

delboy1978uk / BTCExchange

Push — master ( dbc3c2...b8cb7c )

BtcE::getOrders() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like