Dekalee\NightlyTaskBundle\Command\AbstractNightlyTaskCommand

Complexity

Total Complexity

6

Size/Duplication

Total Lines	66
Duplicated Lines	0 %

Coupling/Cohesion

Components	2
Dependencies	3

Test Coverage

Coverage

0%

Importance

Changes

0

4 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	6	1
A	getTasks()	0	4	1
A	beforeExecute()	0	5	1
A	fillTasks()	0	9	3

<?php

namespace Dekalee\NightlyTaskBundle\Command;

use Dekalee\NightlyTaskBundle\Bag\TasksBag;
use Psr\Log\LoggerInterface;
use Symfony\Component\Console\Command\Command;
use Symfony\Component\Console\Descriptor\ApplicationDescription;
use Symfony\Component\Console\Input\InputInterface;
use Symfony\Component\Console\Output\OutputInterface;

/**
 * Class AbstractNightlyTaskCommand
 */
abstract class AbstractNightlyTaskCommand extends Command
{
    /**
     * @var InputInterface
     */
    protected $input;

    /**
     * @var OutputInterface
     */
    protected $output;

    /**
     * @var LoggerInterface
     */
    protected $logger;

    /**
     * @var TasksBag
     */
    private $taskBag;

    /**
     * @param TasksBag        $taskBag
     * @param LoggerInterface $logger
     */
    public function __construct(TasksBag $taskBag, LoggerInterface $logger)
    {
        parent::__construct();
        $this->logger = $logger;
        $this->taskBag = $taskBag;
    }

    /**
     * @return array
     */
    protected function getTasks()
    {
        return $this->taskBag->getTasks();
    }

    /**
     * Initialize fields
     *
     * @param InputInterface  $input
     * @param OutputInterface $output
     */
    protected function beforeExecute(InputInterface $input, OutputInterface $output)
    {
        $this->input = $input;
        $this->output = $output;
    }

    /**
     * Fill task lists
     */
    protected function fillTasks()
    {
        $description = new ApplicationDescription($this->getApplication());

It seems like $this->getApplication() can be null; however, __construct() does not accept null, maybe add an additional type check?

        foreach ($description->getCommands() as $command) {
            if ($command instanceof NightlyCommandInterface) {
                $this->taskBag->addTask($command, $command->getPriority());
            }
        }
    }
}