ContactListSubscriber::addContactToList() - Code Metrics - Inspection of "add contact list creator" - dekalee/mailjet-bundle - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Pull Request — master (#2)

by nicolas

created 2016-05-31 16:02 UTC

ContactListSubscriber::addContactToList() A

↳ Parent: ContactListSubscriber

Complexity

Conditions	1
Paths	1

Size

Total Lines	6
Code Lines	4

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	5
CRAP Score	1

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
c	1
b	0
f	0
dl	0
loc	6
rs	9.4285
ccs	5
cts	5
cp	1
cc	1
eloc	4
nc	1
nop	3
crap	1

<?php

namespace Dekalee\MailjetBundle\Manager;

use Dekalee\MailjetBundle\Convertor\ContactListConvertor;
use Dekalee\MailjetBundle\Creator\ContactCreator;

/**
 * Class ContactListSubscriber
 */
class ContactListSubscriber
{
    protected $contactCreator;
    protected $contactListConvertor;

    /**
     * @param ContactListConvertor $contactListConvertor
     * @param ContactCreator       $contactCreator
     */
    public function __construct(
        ContactListConvertor $contactListConvertor,
        ContactCreator $contactCreator
    ) {
        $this->contactCreator = $contactCreator;
        $this->contactListConvertor = $contactListConvertor;
    }

    /**
     * @param string $name
     * @param string $contact
     * @param array  $parameters
     *
     * @throws \Dekalee\MailjetBundle\Exception\ContactListNotCreated
     */
    public function addContactToList($name, $contact, array $parameters = [])
    {
        $contactListId = $this->contactListConvertor->convert($name);
        $this->contactCreator->create($name, $contact, $parameters);
        $this->contactCreator->addToList($contactListId, $contact);
    }
}


1		<?php
2
3		namespace Dekalee\MailjetBundle\Manager;
4
5		use Dekalee\MailjetBundle\Convertor\ContactListConvertor;
6		use Dekalee\MailjetBundle\Creator\ContactCreator;
7
8		/**
9		* Class ContactListSubscriber
10		*/
11		class ContactListSubscriber
12		{
13		protected $contactCreator;
14		protected $contactListConvertor;
15
16		/**
17		* @param ContactListConvertor $contactListConvertor
18		* @param ContactCreator $contactCreator
19		*/
20	2	public function __construct(
21		ContactListConvertor $contactListConvertor,
22		ContactCreator $contactCreator
23		) {
24	2	$this->contactCreator = $contactCreator;
25	2	$this->contactListConvertor = $contactListConvertor;
26	2	}
27
28		/**
29		* @param string $name
30		* @param string $contact
31		* @param array $parameters
32		*
33		* @throws \Dekalee\MailjetBundle\Exception\ContactListNotCreated
34		*/
35	1	public function addContactToList($name, $contact, array $parameters = [])
36		{
37	1	$contactListId = $this->contactListConvertor->convert($name);
38	1	$this->contactCreator->create($name, $contact, $parameters);
39	1	$this->contactCreator->addToList($contactListId, $contact);
40	1	}
41		}
42

dekalee / mailjet-bundle

Pull Request — master (#2)

ContactListSubscriber::addContactToList() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like