Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.
Common duplication problems, and corresponding solutions are:
1 | <?php |
||
8 | class MysqliScriptCache implements ScriptCacheInterface |
||
9 | { |
||
10 | protected $connection; |
||
11 | |||
12 | const ADBACK_ANALYTICS_SCRIPT = 'adback_analytics_script'; |
||
13 | const ADBACK_ANALYTICS_URL = 'adback_analytics_url'; |
||
14 | const ADBACK_MESSAGE_SCRIPT = 'adback_message_script'; |
||
15 | const ADBACK_MESSAGE_URL = 'adback_message_url'; |
||
16 | const ADBACK_AUTOPROMO_BANNER_SCRIPT = 'adback_autopromo_banner_script'; |
||
17 | const ADBACK_AUTOPROMO_BANNER_URL = 'adback_autopromo_banner_url'; |
||
18 | const ADBACK_PRODUCT_SCRIPT = 'adback_product_script'; |
||
19 | const ADBACK_PRODUCT_URL = 'adback_product_url'; |
||
20 | |||
21 | /** |
||
22 | * @param mixed $connection Mysqli Connection |
||
23 | */ |
||
24 | public function __construct($connection) |
||
28 | |||
29 | /** |
||
30 | * @return bool |
||
31 | */ |
||
32 | public function isAnalyticsConfigured() |
||
36 | |||
37 | /** |
||
38 | * @param string $domain |
||
39 | */ |
||
40 | public function setAnalyticsUrl($domain) |
||
44 | |||
45 | /** |
||
46 | * @return string |
||
47 | */ |
||
48 | public function getAnalyticsUrl() |
||
52 | |||
53 | /** |
||
54 | * @param string $script |
||
55 | */ |
||
56 | public function setAnalyticsScript($script) |
||
60 | |||
61 | /** |
||
62 | * @return string |
||
63 | */ |
||
64 | public function getAnalyticsScript() |
||
68 | |||
69 | /** |
||
70 | * @return bool |
||
71 | */ |
||
72 | public function isMessageConfigured() |
||
76 | |||
77 | /** |
||
78 | * @return bool |
||
79 | */ |
||
80 | public function isAutopromoBannerConfigured() |
||
84 | |||
85 | /** |
||
86 | * @param string $domain |
||
87 | */ |
||
88 | public function setMessageUrl($domain) |
||
92 | |||
93 | /** |
||
94 | * @return string |
||
95 | */ |
||
96 | public function getMessageUrl() |
||
100 | |||
101 | /** |
||
102 | * @param string $script |
||
103 | */ |
||
104 | public function setMessageScript($script) |
||
108 | |||
109 | /** |
||
110 | * @return string |
||
111 | */ |
||
112 | public function getMessageScript() |
||
116 | |||
117 | /** |
||
118 | * @param string $domain |
||
119 | */ |
||
120 | public function setAutopromoBannerUrl($domain) |
||
124 | |||
125 | /** |
||
126 | * @return string |
||
127 | */ |
||
128 | public function getAutopromoBannerUrl() |
||
132 | |||
133 | /** |
||
134 | * @param string $domain |
||
135 | */ |
||
136 | public function setProductUrl($domain) |
||
140 | |||
141 | /** |
||
142 | * @return string |
||
143 | */ |
||
144 | public function getProductUrl() |
||
148 | |||
149 | /** |
||
150 | * @param string $script |
||
151 | */ |
||
152 | public function setAutopromoBannerScript($script) |
||
156 | |||
157 | /** |
||
158 | * @return string |
||
159 | */ |
||
160 | public function getAutopromoBannerScript() |
||
164 | |||
165 | /** |
||
166 | * @param string $script |
||
167 | */ |
||
168 | public function setProductScript($script) |
||
172 | |||
173 | /** |
||
174 | * @return string |
||
175 | */ |
||
176 | public function getProductScript() |
||
180 | |||
181 | /** |
||
182 | * Clear analytics data |
||
183 | */ |
||
184 | public function clearAnalyticsData() |
||
189 | |||
190 | /** |
||
191 | * Clear message data |
||
192 | */ |
||
193 | public function clearMessageData() |
||
198 | |||
199 | /** |
||
200 | * Clear autopromo banner data |
||
201 | */ |
||
202 | public function clearAutopromoBannerData() |
||
207 | |||
208 | /** |
||
209 | * Clear autopromo banner data |
||
210 | */ |
||
211 | public function clearProductData() |
||
216 | |||
217 | /** |
||
218 | * @param string $key |
||
219 | * |
||
220 | * @return string|null |
||
221 | */ |
||
222 | protected function get($key) |
||
235 | |||
236 | /** |
||
237 | * @param string $key |
||
238 | * @param string $value |
||
239 | */ |
||
240 | View Code Duplication | protected function set($key, $value) |
|
247 | |||
248 | /** |
||
249 | * @param string $key |
||
250 | */ |
||
251 | protected function clear($key) |
||
257 | } |
||
258 |