DP\GameServer\GameServerBundle\Controller\GameServerController

Complexity

Total Complexity

22

Size/Duplication

Total Lines	164
Duplicated Lines	23.17 %

Coupling/Cohesion

Components	1
Dependencies	16

Importance

Changes

0

7 Methods

Rating	Name	Duplication	Size	Complexity
A	setContainer()	14	14	2
A	installProgressAction()	0	15	4
A	regenAction()	0	9	1
B	logsAction()	24	24	2
B	rconAction()	0	42	6
B	pluginAction()	0	37	6
A	createRconForm()	0	9	1

<?php

/**
 * This file is part of Dedipanel project
 *
 * (c) 2010-2015 Dedipanel <http://www.dedicated-panel.net>
 *
 * For the full copyright and license information, please view the LICENSE
 * file that was distributed with this source code.
 */

namespace DP\GameServer\GameServerBundle\Controller;

use DP\Core\CoreBundle\Controller\Server\ServerController;
use DP\GameServer\GameServerBundle\Entity\GameServer;
use Symfony\Component\HttpKernel\Exception\AccessDeniedHttpException;
use DP\Core\CoreBundle\Exception\NotImplementedException;
use Symfony\Component\HttpFoundation\Request;
use Symfony\Component\DependencyInjection\ContainerInterface;
use Symfony\Component\HttpKernel\Exception\NotFoundHttpException;
use Symfony\Component\Security\Core\Exception\AccessDeniedException;

class GameServerController extends ServerController
{
    /**
     * @var GameServerDomainManager
     */
    protected $domainManager;

    public function setContainer(ContainerInterface $container = null)

This method seems to be duplicated in your project.

    {
        parent::setContainer($container);

        if ($container !== null) {
            $this->domainManager = new GameServerDomainManager(
                $container->get($this->config->getServiceName('manager')),
                $container->get('event_dispatcher'),
                $this->flashHelper,
                $this->config,
                $container->get('twig')
            );
        }
    }

    public function installProgressAction(Request $request)
    {
        if (!$this->isGranted('CREATE', $this->find($request)) && !$this->isGranted('UPDATE', $this->find($request))) {
            throw new AccessDeniedException;
        }

        /** @var GameServer $server */
        $server = $this->findOr404($request);

        if (!$server->isInstallationEnded()) {
            $this->domainManager->getInstallationProgress($server);
        }
        
        return $this->redirectHandler->redirectToReferer();
    }
    
    public function regenAction(Request $request)
    {
        $this->isGrantedOr403('ADMIN', $this->find($request));
        
        $server = $this->findOr404($request);
        $this->domainManager->regenerateConfig($server);

        return $this->redirectHandler->redirectToReferer();
    }
    
    public function logsAction(Request $request)

This method seems to be duplicated in your project.

    {
        $this->isGrantedOr403('ADMIN', $this->find($request));
        
        $config = $this->getConfiguration();   
        $server = $this->findOr404($request);

        $logs = $this->domainManager->getServerLogs($server);

        if ($logs === null) {
            return $this->redirectHandler->redirectToReferer();
        }
        
        $view = $this
            ->view()
            ->setTemplate($config->getTemplate('logs.html'))
            ->setData(array(
                $config->getResourceName() => $server,
                'logs'                     => $logs
            ))
        ;

        return $this->handleView($view);
    }

    public function rconAction(Request $request)
    {
        $this->isGrantedOr403('RCON', $this->find($request));
        
        $config = $this->getConfiguration();
        $server = $this->findOr404($request);
        $form = $this->createRconForm();
        
        $logs = $server->getServerLogs() . "\n";

        if (!$this->domainManager->isAccessibleFromQuery($server)) {
            return $this->redirectHandler->redirectToReferer();
        }

        if ($request->isMethod('POST') && $form->submit($request)->isValid()) {
            $data = $form->getData();
            $cmd = $data['cmd'];

            $ret = $this->domainManager->executeRconCmd($server, $cmd);
            $logs .= '> ' . $cmd . "\n" . $ret . "\n";

            if ($config->isApiRequest()) {
                return $this->handleView($this->view(array('log' => $logs, 'cmd' => $cmd, 'ret' => $ret)));
            }
        }
        
        if ($config->isApiRequest()) {
            return $this->handleView($this->view(array('form' => $form, 'log' => $logs)));
        }

        $view = $this
            ->view()
            ->setTemplate($config->getTemplate('rcon.html'))
            ->setData(array(
                $config->getResourceName() => $server,
                'form'                     => $form->createView(), 
                'log'                      => $logs,
            ))
        ;

        return $this->handleView($view);
    }
    
    public function pluginAction(Request $request)
    {
        $this->isGrantedOr403('PLUGIN', $this->find($request));
        
        $config = $this->getConfiguration();
        $server = $this->findOr404($request);

        $pluginId = $request->get('plugin');
        $action   = $request->get('action');
        
        if ($pluginId && $action) {
            $em = $this->getDoctrine()->getManager();
            $plugin = $em->getRepository('DPGameBundle:Plugin')->findOneBy(array('id' => $pluginId));

            if (!$plugin) {
                throw new NotFoundHttpException('Requested plugin does not exist.');
            }
            if ($action != 'install' && $action != 'uninstall') {
                throw new NotImplementedException();
            }

            $method = $action . 'Plugin';
            $server = $this->domainManager->{$method}($server, $plugin);

$server is not used, you could remove the assignment.

            return $this->redirectHandler->redirectToReferer();
        }
        
        $view = $this
            ->view()
            ->setTemplate($config->getTemplate('plugin.html'))
            ->setData(array(
                $config->getResourceName() => $server,
            ))
        ;

        return $this->handleView($view);
    }

    public function createRconForm(array $default = array())
    {
        $form = $this
            ->createFormBuilder($default)
            ->add('cmd', 'text', array('label' => 'game.rcon.command'))
        ;

        return $form->getForm();
    }
}