dedalozzo / eoc-client

src/EoC/Opt/ChangesFeedOpts.php

Braces +30 added lines, -24 removed lines

@@ -81,10 +81,11 @@ 
    * @param[in] integer $since Sequence number to start results. Allowed values: positive integers | 'now'.
    */
   public function setSince($since = 0) {
-    if (($since == "now") or (is_int($since) and ($since >= 0)))
-      $this->options["since"] = $since;
-    else
-      throw new \InvalidArgumentException("\$since must be a non-negative integer or can be 'now'.");
+    if (($since == "now") or (is_int($since) and ($since >= 0))) {
+          $this->options["since"] = $since;
+    } else {
+          throw new \InvalidArgumentException("\$since must be a non-negative integer or can be 'now'.");
+    }
 
     return $this;
   }
@@ -95,10 +96,11 @@ 
    * @param[in] integer $limit Maximum number of rows to return. Must be a positive integer.
    */
   public function setLimit($limit) {
-    if (is_int($limit) and ($limit > 0))
-      $this->options["limit"] = $limit;
-    else
-      throw new \InvalidArgumentException("\$value must be a positive integer.");
+    if (is_int($limit) and ($limit > 0)) {
+          $this->options["limit"] = $limit;
+    } else {
+          throw new \InvalidArgumentException("\$value must be a positive integer.");
+    }
 
     return $this;
   }
@@ -117,10 +119,11 @@ 
    * @param[in] string $type Type of feed.
    */
   public function setFeedType($type) {
-    if (array_key_exists($type, self::$supportedTypes))
-      $this->options["feed"] = $type;
-    else
-      throw new \InvalidArgumentException("Invalid feed type.");
+    if (array_key_exists($type, self::$supportedTypes)) {
+          $this->options["feed"] = $type;
+    } else {
+          throw new \InvalidArgumentException("Invalid feed type.");
+    }
   }
 
 
@@ -130,10 +133,11 @@ 
    * @param[in] bool $style The feed style.
    */
   public function setStyle($style) {
-    if (array_key_exists($style, self::$supportedStyles))
-      $this->options["style"] = $style;
-    else
-      throw new \InvalidArgumentException("Invalid feed style.");
+    if (array_key_exists($style, self::$supportedStyles)) {
+          $this->options["style"] = $style;
+    } else {
+          throw new \InvalidArgumentException("Invalid feed style.");
+    }
   }
 
 
@@ -146,11 +150,12 @@ 
   public function setHeartbeat($heartbeat = self::DEFAULT_HEARTBEAT) {
     $feed = $this->options['feed'];
 
-    if (($feed == self::CONTINUOUS_TYPE) or ($feed == self::LONGPOLL_TYPE))
-      if (is_int($heartbeat) and ($heartbeat >= 0))
+    if (($feed == self::CONTINUOUS_TYPE) or ($feed == self::LONGPOLL_TYPE)) {
+          if (is_int($heartbeat) and ($heartbeat >= 0))
         $this->options["heartbeat"] = $heartbeat;
-      else
-        throw new \InvalidArgumentException("\$heartbeat must be a non-negative integer.");
+    } else {
+              throw new \InvalidArgumentException("\$heartbeat must be a non-negative integer.");
+      }
   }
 
 
@@ -163,11 +168,12 @@ 
   public function setTimeout($timeout = self::DEFAULT_TIMEOUT) {
     $feed = $this->options['feed'];
 
-    if (($feed == self::CONTINUOUS_TYPE) or ($feed == self::LONGPOLL_TYPE))
-      if (is_int($timeout) and ($timeout > 0))
+    if (($feed == self::CONTINUOUS_TYPE) or ($feed == self::LONGPOLL_TYPE)) {
+          if (is_int($timeout) and ($timeout > 0))
         $this->options["timeout"] = $timeout;
-      else
-        throw new \InvalidArgumentException("\$timeout must be a positive integer.");
+    } else {
+              throw new \InvalidArgumentException("\$timeout must be a positive integer.");
+      }
   }
 
 

src/EoC/Opt/DbUpdatesFeedOpts.php

Braces +10 added lines, -8 removed lines

@@ -63,10 +63,11 @@ 
    * @param[in] string $type Type of feed.
    */
   public function setFeedType($type) {
-    if (array_key_exists($type, self::$supportedTypes))
-      $this->options["feed"] = $type;
-    else
-      throw new \InvalidArgumentException("Invalid feed type.");
+    if (array_key_exists($type, self::$supportedTypes)) {
+          $this->options["feed"] = $type;
+    } else {
+          throw new \InvalidArgumentException("Invalid feed type.");
+    }
 
     return $this;
   }
@@ -81,11 +82,12 @@ 
   public function setTimeout($timeout = self::DEFAULT_TIMEOUT) {
     $feed = $this->options['feed'];
 
-    if ($feed == self::CONTINUOUS_TYPE)
-      if (is_int($timeout) and ($timeout > 0))
+    if ($feed == self::CONTINUOUS_TYPE) {
+          if (is_int($timeout) and ($timeout > 0))
         $this->options["timeout"] = $timeout;
-      else
-        throw new \InvalidArgumentException("\$timeout must be a positive integer.");
+    } else {
+              throw new \InvalidArgumentException("\$timeout must be a positive integer.");
+      }
 
     return $this;
   }

src/EoC/Opt/DocOpts.php

Braces +5 added lines, -4 removed lines

@@ -143,10 +143,11 @@
    * @param[in] string|array $revs The revision(s) identifier(s).
    */
   public function includeOpenRevs($revs = 'all') {
-    if (is_array($revs))
-      $this->options['open_revs'] = json_encode($revs);
-    else
-      $this->options['open_revs'] = 'all';
+    if (is_array($revs)) {
+          $this->options['open_revs'] = json_encode($revs);
+    } else {
+          $this->options['open_revs'] = 'all';
+    }
 
     return $this;
   }

src/EoC/Message/Message.php

Braces +26 added lines, -20 removed lines

@@ -206,8 +206,9 @@ 
    */
   public function getHeaderAsArray() {
     $wellformedHeader = [];
-    foreach ($this->header as $name => $value)
-      $wellformedHeader[] = $name.": ".$value;
+    foreach ($this->header as $name => $value) {
+          $wellformedHeader[] = $name.": ".$value;
+    }
 
     return $wellformedHeader;
   }
@@ -238,10 +239,11 @@ 
    * @retval string
    */
   public function getHeaderFieldValue($name) {
-    if ($this->hasHeaderField($name))
-      return $this->header[$name];
-    else
-      return FALSE;
+    if ($this->hasHeaderField($name)) {
+          return $this->header[$name];
+    } else {
+          return FALSE;
+    }
   }
 
 
@@ -251,10 +253,11 @@ 
    * @param[in] string $value The header field value.
    */
   public function setHeaderField($name, $value) {
-    if (array_key_exists($name, static::$supportedHeaderFields))
-      $this->header[$name] = $value;
-    else
-      throw new \Exception("$name header field is not supported.");
+    if (array_key_exists($name, static::$supportedHeaderFields)) {
+          $this->header[$name] = $value;
+    } else {
+          throw new \Exception("$name header field is not supported.");
+    }
   }
 
 
@@ -263,8 +266,9 @@ 
    * @param[in] string $name The header field name.
    */
   public function removeHeaderField($name) {
-    if (array_key_exists($name, static::$supportedHeaderFields))
-      unset($this->header[$name]);
+    if (array_key_exists($name, static::$supportedHeaderFields)) {
+          unset($this->header[$name]);
+    }
   }
 
 
@@ -273,11 +277,12 @@ 
    * @param[in] array $headerFields An associative array of header fields.
    */
   public function setMultipleHeaderFieldsAtOnce(array $headerFields) {
-    if (Helper\ArrayHelper::isAssociative($headerFields))
-      foreach ($headerFields as $name => $value)
+    if (Helper\ArrayHelper::isAssociative($headerFields)) {
+          foreach ($headerFields as $name => $value)
         $this->setHeaderField($name, $value);
-    else
-      throw new \Exception("\$headerFields must be an associative array.");
+    } else {
+          throw new \Exception("\$headerFields must be an associative array.");
+    }
   }
 
 
@@ -286,10 +291,11 @@ 
    * @param[in] string $name Header field name.
    */
   public static function addCustomHeaderField($name) {
-    if (array_key_exists($name, static::$supportedHeaderFields))
-      throw new \Exception("$name header field is supported but already exists.");
-    else
-      static::$supportedHeaderFields[] = $name;
+    if (array_key_exists($name, static::$supportedHeaderFields)) {
+          throw new \Exception("$name header field is supported but already exists.");
+    } else {
+          static::$supportedHeaderFields[] = $name;
+    }
   }
 
 

src/EoC/Adapter/AbstractAdapter.php

Braces +3 added lines, -2 removed lines

@@ -68,9 +68,10 @@
       $this->scheme = isset($matches['scheme']) ? $matches['scheme'] : "tcp://";
       $this->host = isset($matches['host']) ? $matches['host'] : self::DEFAULT_HOST;
       $this->port = isset($matches['port']) ? substr($matches['port'], 1) : self::DEFAULT_PORT;
-    }
-    else // Match attempt failed.
+    } else {
+      // Match attempt failed.
       throw new \InvalidArgumentException(sprintf("'%s' is not a valid URI.", $server));
+    }
 
     $this->userName = (string)$userName;
     $this->password = (string)$password;

src/EoC/Adapter/CurlAdapter.php

Braces +12 added lines, -10 removed lines

@@ -52,8 +52,9 @@ 
    * @copydoc AbstractAdapter::initialize()
    */
   public function initialize() {
-    if (!extension_loaded("curl"))
-      throw new \RuntimeException("The cURL extension is not loaded.");
+    if (!extension_loaded("curl")) {
+          throw new \RuntimeException("The cURL extension is not loaded.");
+    }
   }
 
 
@@ -64,8 +65,9 @@ 
     $opts = [];
 
     // Resets all the cURL options. The curl_reset() function is available only since PHP 5.5.
-    if (function_exists('curl_reset'))
-      curl_reset($this->handle);
+    if (function_exists('curl_reset')) {
+          curl_reset($this->handle);
+    }
 
     // Sets the methods and its related options.
     switch ($request->getMethod()) {
@@ -100,9 +102,9 @@ 
 
             $opts[CURLOPT_INFILE] = $fd;
             $opts[CURLOPT_INFILESIZE] = $request->getBodyLength();
+          } else {
+                      throw new \RuntimeException("Cannot create the stream.");
           }
-          else
-            throw new \RuntimeException("Cannot create the stream.");
         }
 
         break;
@@ -143,8 +145,9 @@ 
     // This fix a known cURL bug: see http://the-stickman.com/web-development/php-and-curl-disabling-100-continue-header/
     // cURL sets the Expect header field automatically, ignoring the fact that a client may not need it for the specific
     // request.
-    if (!$request->hasHeaderField(Request::EXPECT_HF))
-      curl_setopt($this->handle, CURLOPT_HTTPHEADER, array("Expect:"));
+    if (!$request->hasHeaderField(Request::EXPECT_HF)) {
+          curl_setopt($this->handle, CURLOPT_HTTPHEADER, array("Expect:"));
+    }
 
     // Sets the request header.
     // Due to a stupid bug, using curl_setopt_array(), cURL doesn't override the Content-Type header field. So we must
@@ -176,8 +179,7 @@ 
       $response = new Response($header);
       $response->setBody($result);
       return $response;
-    }
-    else {
+    } else {
       $error = curl_error($this->handle);
       throw new \RuntimeException($error);
     }

src/EoC/Handler/ViewHandler.php

Braces +18 added lines, -12 removed lines

@@ -144,8 +144,9 @@ 
   public static function checkFn($fnImpl, $fnDef, $fnRegex) {
     Lint::checkSourceCode($fnImpl);
 
-    if (!preg_match($fnRegex, $fnImpl))
-      throw new \Exception("The \$closure must be defined like: $fnDef");
+    if (!preg_match($fnRegex, $fnImpl)) {
+          throw new \Exception("The \$closure must be defined like: $fnDef");
+    }
   }
 
 
@@ -153,14 +154,17 @@ 
     $view = [];
     $view['map'] = $this->mapFn;
 
-    if (!empty($this->language))
-      $view['language'] = $this->language;
+    if (!empty($this->language)) {
+          $view['language'] = $this->language;
+    }
 
-    if (!empty($this->reduceFn))
-      $view['reduce'] = $this->reduceFn;
+    if (!empty($this->reduceFn)) {
+          $view['reduce'] = $this->reduceFn;
+    }
 
-    if (!empty($this->options))
-      $view['options'] = $this->options;
+    if (!empty($this->options)) {
+          $view['options'] = $this->options;
+    }
 
     return $view;
   }
@@ -225,8 +229,9 @@ 
   public function setMapFn($value) {
     $fn = stripslashes((string)$value);
 
-    if ($this->language == "php")
-      self::checkFn($fn, self::MAP_DEFINITION, self::MAP_REGEX);
+    if ($this->language == "php") {
+          self::checkFn($fn, self::MAP_DEFINITION, self::MAP_REGEX);
+    }
 
     $this->mapFn = $fn;
   }
@@ -240,8 +245,9 @@ 
   public function setReduceFn($value) {
     $fn = stripslashes((string)$value);
 
-    if ($this->language == "php")
-      self::checkFn($fn, self::REDUCE_DEFINITION, self::REDUCE_REGEX);
+    if ($this->language == "php") {
+          self::checkFn($fn, self::REDUCE_DEFINITION, self::REDUCE_REGEX);
+    }
 
     $this->reduceFn = $fn;
   }

src/EoC/Result/QueryResult.php

Spacing +2 added lines, -2 removed lines

@@ -54,7 +54,7 @@ 
    * arrays.
    * @retval array An array of rows.
    */
-  public function asArray()  {
+  public function asArray() {
     return $this->result['rows'];
   }
 
@@ -105,7 +105,7 @@ 
    * @param[in] integer $offset The offset to retrieve.
    * @retval mixed Can return all value types.
    */
-  public function offsetGet($offset)  {
+  public function offsetGet($offset) {
     return $this->result['rows'][$offset];
   }
 

src/EoC/Adapter/SocketAdapter.php

Indentation +1 added lines, -1 removed lines

@@ -47,7 +47,7 @@
   /**
    * @copydoc AbstractAdapter::__construct()
    * @param[in] bool $persistent (optional) When `true` the client uses a persistent connection.
-  */
+   */
   public function __construct($server = parent::DEFAULT_SERVER, $userName = "", $password = "", $persistent = TRUE) {
     $this->initialize();
 

Braces +46 added lines, -32 removed lines

@@ -56,13 +56,15 @@ 
     $this->timeout = static::$defaultSocketTimeout;
 
     // Establishes a connection within the server.
-    if ($persistent)
-      $this->handle = @pfsockopen($this->scheme.$this->host, $this->port, $errno, $errstr, $this->timeout);
-    else
-      $this->handle = @fsockopen($this->scheme.$this->host, $this->port, $errno, $errstr, $this->timeout);
+    if ($persistent) {
+          $this->handle = @pfsockopen($this->scheme.$this->host, $this->port, $errno, $errstr, $this->timeout);
+    } else {
+          $this->handle = @fsockopen($this->scheme.$this->host, $this->port, $errno, $errstr, $this->timeout);
+    }
 
-    if (!is_resource($this->handle))
-      throw new \ErrorException($errstr, $errno);
+    if (!is_resource($this->handle)) {
+          throw new \ErrorException($errstr, $errno);
+    }
   }
 
 
@@ -123,8 +125,9 @@ 
       $statusCodeAndHeader .= $buffer;
 
       // The header is separated from the body by a newline, so we break when we read it.
-      if ($buffer == Message::CRLF)
-        break;
+      if ($buffer == Message::CRLF) {
+              break;
+      }
     }
 
     return $statusCodeAndHeader;
@@ -144,18 +147,21 @@ 
 
       // If it's only a newline, this normally means it's read the total amount of data requested minus the newline
       // continue to next loop to make sure we're done.
-      if ($line == Message::CRLF)
-        continue;
+      if ($line == Message::CRLF) {
+              continue;
+      }
 
       // The length of the block is expressed in hexadecimal.
       $length = hexdec($line);
 
-      if (!is_int($length))
-        throw new \RuntimeException("The response doesn't seem chunk encoded.");
+      if (!is_int($length)) {
+              throw new \RuntimeException("The response doesn't seem chunk encoded.");
+      }
 
       // Zero is sent when at the end of the chunks or the end of the stream.
-      if ($length < 1)
-        break;
+      if ($length < 1) {
+              break;
+      }
 
       // Reads the chunk.
       // When reading from network streams or pipes, such as those returned when reading remote files or from popen()
@@ -168,18 +174,21 @@ 
         $size = min(self::BUFFER_LENGTH, $length);
         $data = fread($this->handle, $size);
 
-        if (strlen($data) == 0)
-          break; // EOF
+        if (strlen($data) == 0) {
+                  break;
+        }
+        // EOF
 
         $buffer .= $data;
         $length -= strlen($data);
       }
 
       // If a function has been hooked, calls it, else just adds the buffer to the body.
-      if (is_null($chunkHook))
-        $body .= $buffer;
-      else
-        $chunkHook->process($buffer);
+      if (is_null($chunkHook)) {
+              $body .= $buffer;
+      } else {
+              $chunkHook->process($buffer);
+      }
     }
 
     // A chunk response might have some footer, but CouchDB doesn't use them, so we simply ignore them.
@@ -188,8 +197,9 @@ 
       $buffer = fgets($this->handle, self::BUFFER_LENGTH);
 
       // The chunk response ends with a newline, so we break when we read it.
-      if ($buffer == Message::CRLF)
-        break;
+      if ($buffer == Message::CRLF) {
+              break;
+      }
     }
 
     return $body;
@@ -216,8 +226,9 @@ 
         $body .= $buffer;
         $bytes += strlen($buffer);
 
-        if ($bytes >= $length)
-          break;
+        if ($bytes >= $length) {
+                  break;
+        }
       }
     }
 
@@ -232,10 +243,11 @@ 
    * @return string
    */
   protected function readResponseBody(Response $response, $chunkHook) {
-    if ($response->getHeaderFieldValue(Response::TRANSFER_ENCODING_HF) == "chunked")
-      return $this->readChunkedResponseBody($chunkHook);
-    else
-      return $this->readStandardResponseBody($response);
+    if ($response->getHeaderFieldValue(Response::TRANSFER_ENCODING_HF) == "chunked") {
+          return $this->readChunkedResponseBody($chunkHook);
+    } else {
+          return $this->readStandardResponseBody($response);
+    }
   }
 
 
@@ -245,12 +257,14 @@ 
   public function send(Request $request, IChunkHook $chunkHook = NULL) {
     $request->setHeaderField(Request::HOST_HF, $this->host.":".$this->port);
 
-    if (!empty($this->userName))
-      $request->setBasicAuth($this->userName, $this->password);
+    if (!empty($this->userName)) {
+          $request->setBasicAuth($this->userName, $this->password);
+    }
 
     // Sets the Content-Length header only when the given request has a message body.
-    if ($request->hasBody())
-      $request->setHeaderField(Message::CONTENT_LENGTH_HF, $request->getBodyLength());
+    if ($request->hasBody()) {
+          $request->setHeaderField(Message::CONTENT_LENGTH_HF, $request->getBodyLength());
+    }
 
     // Writes the request over the socket.
     $this->writeRequest($request);