UrlBuilder::buildMethodUrl() - Code Metrics - Inspection of "bugfixes" - ddlzz/amocrm-api-client - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — develop ( 36c731...cb55ce )

by Andrew

created 2017-12-05 20:52 UTC

UrlBuilder::buildMethodUrl() B

↳ Parent: UrlBuilder

Complexity

Conditions	5
Paths	4

Size

Total Lines	19
Code Lines	10

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	11
CRAP Score	5

Importance

Changes

Metric	Value
dl	0
loc	19
ccs	11
cts	11
cp	1
rs	8.8571
c	0
b	0
f	0
cc	5
eloc	10
nc	4
nop	2
crap	5

<?php


namespace ddlzz\AmoAPI\Request;

use ddlzz\AmoAPI\Exceptions\InvalidArgumentException;
use ddlzz\AmoAPI\SettingsStorage;


/**
 * Class UrlBuilder
 * @package ddlzz\AmoAPI\Request
 * @author ddlzz
 */
class UrlBuilder
{
    /** @var SettingsStorage */
    private $settings;

    /** @var string */
    private $subdomain;

    /**
     * UrlBuilder constructor.
     * @param SettingsStorage $settings
     * @param string $subdomain
     */
    public function __construct(SettingsStorage $settings, $subdomain)
    {
        $this->settings = $settings;
        $this->subdomain = $subdomain;
    }

    /**
     * @param string $code
     * @param array $params
     * @return string
     * @throws InvalidArgumentException
     */
    public function buildMethodUrl($code, $params = [])
    {
        $host = $this->makeUserHost($this->subdomain);
        $path = $this->settings->getMethodPath($code);

        if (!empty($params)) {
            $query = '?';
            foreach ($params as $key => $param) {
                $query .= $key . '=' . $param;

                if ($param !== end($params)) {
                    $query .= '&';
                }
            }
        }

        $result = isset($query) ? $host . $path . $query : $host . $path;

        return $result;
    }

    /**
     * @param string $subdomain
     * @return string
     */
    private function makeUserHost($subdomain)
    {
        return $this->settings->getScheme() . '://' . $subdomain . '.' . $this->settings->getDomain();
    }
}

1		<?php
2
3
4		namespace ddlzz\AmoAPI\Request;
5
6		use ddlzz\AmoAPI\Exceptions\InvalidArgumentException;
7		use ddlzz\AmoAPI\SettingsStorage;
8
9
10		/**
11		* Class UrlBuilder
12		* @package ddlzz\AmoAPI\Request
13		* @author ddlzz
14		*/
15		class UrlBuilder
16		{
17		/** @var SettingsStorage */
18		private $settings;
19
20		/** @var string */
21		private $subdomain;
22
23		/**
24		* UrlBuilder constructor.
25		* @param SettingsStorage $settings
26		* @param string $subdomain
27		*/
28	9	public function __construct(SettingsStorage $settings, $subdomain)
29		{
30	9	$this->settings = $settings;
31	9	$this->subdomain = $subdomain;
32	9	}
33
34		/**
35		* @param string $code
36		* @param array $params
37		* @return string
38		* @throws InvalidArgumentException
39		*/
40	8	public function buildMethodUrl($code, $params = [])
41		{
42	8	$host = $this->makeUserHost($this->subdomain);
43	8	$path = $this->settings->getMethodPath($code);
44
45	8	if (!empty($params)) {
46	2	$query = '?';
47	2	foreach ($params as $key => $param) {
48	2	$query .= $key . '=' . $param;
49
50	2	if ($param !== end($params)) {
51	2	$query .= '&';
52		}
53		}
54		}
55
56	8	$result = isset($query) ? $host . $path . $query : $host . $path;
57
58	8	return $result;
59		}
60
61		/**
62		* @param string $subdomain
63		* @return string
64		*/
65	8	private function makeUserHost($subdomain)
66		{
67	8	return $this->settings->getScheme() . '://' . $subdomain . '.' . $this->settings->getDomain();
68		}
69		}

ddlzz / amocrm-api-client

Push — develop ( 36c731...cb55ce )

UrlBuilder::buildMethodUrl() B

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like