PageTransformer - Code Metrics - Inspection of "Merge branch 'develop'" - ddimaria/Laravel-REST-CMS - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 509012...3eafe2 )

by David

created 2016-01-13 23:35 UTC

PageTransformer A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	34
Duplicated Lines	0 %

Coupling/Cohesion

Components	0
Dependencies	3

Importance

Changes	2
Bugs	0	Features	0

Metric	Value
wmc	2
c	2
b	0
f	0
lcom	0
cbo	3
dl	0
loc	34
rs	10

2 Methods

Rating	Name	Duplication	Size	Complexity
A	includeDetail()	0	4	1
A	includeTemplate()	0	4	1

<?php namespace App\LaravelRestCms\Page;

use App\LaravelRestCms\BaseModel;
use App\LaravelRestCms\BaseTransformer;
use App\LaravelRestCms\Page\Page;
use App\LaravelRestCms\Page\PageDetailTransformer;
use App\LaravelRestCms\Template\TemplateTransformer;

class PageTransformer extends BaseTransformer {

	/**
	 * List of resources possible to include
	 *
	 * @var array
	 */
	protected $availableIncludes = [
		'detail',
		'template',
	];

    /**
     * Include Page Detail
     * 
     * @param \App\LaravelRestCms\Page\Page
     * @return \League\Fractal\ItemResource
     */
    public function includeDetail(Page $page)
    {
        return $this->collection($page->detail, new PageDetailTransformer);
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
    }

    /**
     * Include Template
     *
     * @param \App\LaravelRestCms\Page\Page
     * @return \League\Fractal\ItemResource
     */
    public function includeTemplate(Page $page)
    {
        return $this->collection($page->template, new TemplateTransformer);
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
    }
}

1			<?php namespace App\LaravelRestCms\Page;
2
3			use App\LaravelRestCms\BaseModel;
4			use App\LaravelRestCms\BaseTransformer;
5			use App\LaravelRestCms\Page\Page;
6			use App\LaravelRestCms\Page\PageDetailTransformer;
7			use App\LaravelRestCms\Template\TemplateTransformer;
8
9			class PageTransformer extends BaseTransformer {
10
11			/**
12			* List of resources possible to include
13			*
14			* @var array
15			*/
16			protected $availableIncludes = [
17			'detail',
18			'template',
19			];
20
21			/**
22			* Include Page Detail
23			*
24			* @param \App\LaravelRestCms\Page\Page
25			* @return \League\Fractal\ItemResource
26			*/
27			public function includeDetail(Page $page)
28			{
29			return $this->collection($page->detail, new PageDetailTransformer);
			0 ignored issues – show Documentation introduced 2016-01-13 23:37 UTC by Report Bug Copy Issue Report The property `detail` does not exist on `object<App\LaravelRestCms\Page\Page>`. Since you implemented `__get`, maybe consider adding a @property annotation. Since your code implements the magic getter `_get`, this function will be called for any read access on an undefined variable. You can add the `@property` annotation to your class or interface to document the existence of this variable. <?php /** * @property int $x * @property int $y * @property string $text */ class MyLabel { private $properties; private $allowedProperties = array('x', 'y', 'text'); public function __get($name) { if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) { return $properties[$name]; } else { return null; } } public function __set($name, $value) { if (in_array($name, $this->allowedProperties)) { $properties[$name] = $value; } else { throw new \LogicException("Property $name is not defined."); } } } If the property has read access only, you can use the @property-read annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property. Loading history... Documentation introduced 2016-01-13 23:37 UTC by Report Bug Copy Issue Report `new \App\LaravelRestCms\...PageDetailTransformer()` is of type `object<App\LaravelRestCm...\PageDetailTransformer>`, but the function expects a `callable`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
30			}
31
32			/**
33			* Include Template
34			*
35			* @param \App\LaravelRestCms\Page\Page
36			* @return \League\Fractal\ItemResource
37			*/
38			public function includeTemplate(Page $page)
39			{
40			return $this->collection($page->template, new TemplateTransformer);
			0 ignored issues – show Documentation introduced 2016-01-13 23:37 UTC by Report Bug Copy Issue Report The property `template` does not exist on `object<App\LaravelRestCms\Page\Page>`. Since you implemented `__get`, maybe consider adding a @property annotation. Since your code implements the magic getter `_get`, this function will be called for any read access on an undefined variable. You can add the `@property` annotation to your class or interface to document the existence of this variable. <?php /** * @property int $x * @property int $y * @property string $text */ class MyLabel { private $properties; private $allowedProperties = array('x', 'y', 'text'); public function __get($name) { if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) { return $properties[$name]; } else { return null; } } public function __set($name, $value) { if (in_array($name, $this->allowedProperties)) { $properties[$name] = $value; } else { throw new \LogicException("Property $name is not defined."); } } } If the property has read access only, you can use the @property-read annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property. Loading history... Documentation introduced 2016-01-13 23:37 UTC by Report Bug Copy Issue Report `new \App\LaravelRestCms\...e\TemplateTransformer()` is of type `object<App\LaravelRestCm...te\TemplateTransformer>`, but the function expects a `callable`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
41			}
42			}

ddimaria / Laravel-REST-CMS

Push — master ( 509012...3eafe2 )

PageTransformer A

Complexity

Size/Duplication

Coupling/Cohesion

Importance

2 Methods

Duplication Side-by-Side

Filter issues like