HierarchyTransformerTrait::includeParent() - Code Metrics - Inspection of "Merge branch 'develop'" - ddimaria/Laravel-REST-CMS - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( a964bf...08af9f )

by David

created 2016-01-19 13:41 UTC

HierarchyTransformerTrait::includeParent() A

↳ Parent: HierarchyTransformerTrait

Complexity

Conditions	1
Paths	1

Size

Total Lines	4
Code Lines	2

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
c	1
b	0
f	0
dl	0
loc	4
rs	10
cc	1
eloc	2
nc	1
nop	1

<?php namespace App\LaravelRestCms;

use App\LaravelRestCms\BaseTransformer;

trait HierarchyTransformerTrait {
	
	/**
	 * Constructor
	 */
    public function __construct()
    {
        parent::addToIncludes('parent');
class Daddy
{
    protected function getFirstName()
    {
        return "Eidur";
    }

    protected function getSurName()
    {
        return "Gudjohnsen";
    }
}

class Son
{
    public function getFirstName()
    {
        return parent::getSurname();
    }
}
    }

    /**
     * Include Parent
     * 
     * @param \App\LaravelRestCms\BaseModel
     * @return \League\Fractal\ItemResource
     */
    public function includeParent(BaseModel $model)
    {
        return $this->collection($model->parent, new $this->parentTransformer);
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
    }
    
}

1			<?php namespace App\LaravelRestCms;
2
3			use App\LaravelRestCms\BaseTransformer;
4
5			trait HierarchyTransformerTrait {
6
7			/**
8			* Constructor
9			*/
10			public function __construct()
11			{
12			parent::addToIncludes('parent');
			0 ignored issues – show Comprehensibility Bug introduced 2016-01-19 13:45 UTC by Report Bug Copy Issue Report It seems like you call parent on a different method (`addToIncludes()` instead of `__construct()`). Are you sure this is correct? If so, you might want to change this to `$this->addToIncludes()`. This check looks for a call to a parent method whose name is different than the method from which it is called. Consider the following code: class Daddy { protected function getFirstName() { return "Eidur"; } protected function getSurName() { return "Gudjohnsen"; } } class Son { public function getFirstName() { return parent::getSurname(); } } The `getFirstName()` method in the `Son` calls the wrong method in the parent class. Loading history...
13			}
14
15			/**
16			* Include Parent
17			*
18			* @param \App\LaravelRestCms\BaseModel
19			* @return \League\Fractal\ItemResource
20			*/
21			public function includeParent(BaseModel $model)
22			{
23			return $this->collection($model->parent, new $this->parentTransformer);
			0 ignored issues – show Documentation introduced 2016-01-19 13:45 UTC by Report Bug Copy Issue Report The property `parent` does not exist on `object<App\LaravelRestCms\BaseModel>`. Since you implemented `__get`, maybe consider adding a @property annotation. Since your code implements the magic getter `_get`, this function will be called for any read access on an undefined variable. You can add the `@property` annotation to your class or interface to document the existence of this variable. <?php /** * @property int $x * @property int $y * @property string $text */ class MyLabel { private $properties; private $allowedProperties = array('x', 'y', 'text'); public function __get($name) { if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) { return $properties[$name]; } else { return null; } } public function __set($name, $value) { if (in_array($name, $this->allowedProperties)) { $properties[$name] = $value; } else { throw new \LogicException("Property $name is not defined."); } } } If the property has read access only, you can use the @property-read annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property. Loading history... Bug introduced 2016-01-19 13:45 UTC by Report Bug Copy Issue Report The property `parentTransformer` does not exist. Did you maybe forget to declare it? In PHP it is possible to write to properties without declaring them. For example, the following is perfectly valid PHP code: class MyClass { } $x = new MyClass(); $x->foo = true; Generally, it is a good practice to explictly declare properties to avoid accidental typos and provide IDE auto-completion: class MyClass { public $foo; } $x = new MyClass(); $x->foo = true; Loading history... Bug introduced 2016-01-19 13:45 UTC by Report Bug Copy Issue Report It seems like `collection()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
24			}
25
26			}

ddimaria / Laravel-REST-CMS

Push — master ( a964bf...08af9f )

HierarchyTransformerTrait::includeParent() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like